Skip to contentSkip to conversation

spl: Add support for CONFIG_OF_EMBED=y

PATCH In review Michal Simek 3 participants 5 messages Nov 9, 2015 – Nov 13, 2015 Kbuild

lore
Share & tools
lore

Michal Simek

author
#0 lore raw

PATCH 1/1 spl: Add support for CONFIG_OF_EMBED=y

CONFIG_OF_EMBED=y is the option which is here only for testing purpose and shouldn't be enabled by default as is describe at:
"dts: Add a comment about CONFIG_OF_EMBED being for local use" (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c)

But still enabling this option locally shouldn't end up with compilation error when you build SPL. This patch fix it.

Compilation error:
lib/built-in.o: In function `fdtdec_setup':
/mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to `__dtb_dt_begin'

Signed-off-by Michal Simek <[email protected]>

---

 scripts/Makefile.spl | 1 +
 1 file changed, 1 insertion(+)
scripts/Makefile.spl +1 -0
index dd235b9d7ad6..8f690eb70c47 100644
@@ -56,6 +56,7 @@ libs-y += common/init/
 libs-$(CONFIG_SPL_LIBCOMMON_SUPPORT) += common/
 libs-$(CONFIG_SPL_LIBDISK_SUPPORT) += disk/
 libs-y += drivers/
+libs-y += dts/
 libs-y += fs/
 libs-$(CONFIG_SPL_LIBGENERIC_SUPPORT) += lib/
 libs-$(CONFIG_SPL_POST_MEM_SUPPORT) += post/drivers/
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 spl: Add support for CONFIG_OF_EMBED=y

Quoted 8 lines · Michal Simek

CONFIG_OF_EMBED=y is the option which is here only for testing purpose and shouldn't be enabled by default as is describe at:
"dts: Add a comment about CONFIG_OF_EMBED being for local use" (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c)

But still enabling this option locally shouldn't end up with compilation error when you build SPL. This patch fix it.

Quoted 6 lines

Compilation error:
lib/built-in.o: In function `fdtdec_setup':
/mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to `__dtb_dt_begin'

Signed-off-by Michal Simek <[email protected]>

Off-list but I _think_ patchwork will pick this up still:

Reported-by Tom Rini <[email protected]>

And:

Reviewed-by Tom Rini <[email protected]>

Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151109/ec6c06ea/attachment.sig>
#2 lore raw

PATCH 1/1 spl: Add support for CONFIG_OF_EMBED=y

Quoted 15 lines · Tom Rini
Quoted 13 lines · Michal Simek

CONFIG_OF_EMBED=y is the option which is here only for testing purpose and shouldn't be enabled by default as is describe at:
"dts: Add a comment about CONFIG_OF_EMBED being for local use" (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c)

But still enabling this option locally shouldn't end up with compilation error when you build SPL. This patch fix it.

Compilation error:
lib/built-in.o: In function `fdtdec_setup':
/mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to `__dtb_dt_begin'

Quoted 6 lines
Quoted 1 line
Signed-off-by Michal Simek <[email protected]>

Off-list but I _think_ patchwork will pick this up still:

Reported-by Tom Rini <[email protected]>

And:

Reviewed-by Tom Rini <[email protected]>
Reviewed-by Simon Glass <[email protected]>
author
#3 lore raw

PATCH 1/1 spl: Add support for CONFIG_OF_EMBED=y

In reply to Tom Rini
Quoted 15 lines · Tom Rini
Quoted 13 lines · Michal Simek

CONFIG_OF_EMBED=y is the option which is here only for testing purpose and shouldn't be enabled by default as is describe at:
"dts: Add a comment about CONFIG_OF_EMBED being for local use" (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c)

But still enabling this option locally shouldn't end up with compilation error when you build SPL. This patch fix it.

Compilation error:
lib/built-in.o: In function `fdtdec_setup':
/mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to `__dtb_dt_begin'

Quoted 4 lines
Quoted 1 line
Signed-off-by Michal Simek <[email protected]>

Off-list but I _think_ patchwork will pick this up still:

Reported-by Tom Rini <[email protected]>

:-) yep. TBH I was aware about this problem for a while - just didn't send patch out.

Cheers,
Michal

#4 lore raw
In reply to Michal Simek
Quoted 13 lines · Michal Simek

CONFIG_OF_EMBED=y is the option which is here only for testing purpose and shouldn't be enabled by default as is describe at:
"dts: Add a comment about CONFIG_OF_EMBED being for local use" (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c)

But still enabling this option locally shouldn't end up with compilation error when you build SPL. This patch fix it.

Compilation error:
lib/built-in.o: In function `fdtdec_setup':
/mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to `__dtb_dt_begin'

Quoted 4 lines
Signed-off-by Michal Simek <[email protected]>
Reported-by Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151112/35b8e178/attachment.sig>