Skip to contentSkip to conversation

ARM: shmobile: r8a7793: Add PFC to DT

PATCH New Simon Horman 3 participants 5 messages Nov 9, 2015 – Nov 10, 2015

Subsystems (2)
Device tree bindings SuperH
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

cover ARM: shmobile: r8a7793: Add PFC to DT

This short series adds PFC support to the r8a7793 and its gose board.

The PFC driver is already present and is the same driver as the r8a7791.

Simon Horman (2):
ARM: shmobile: r8a7793: Add PFC to DT
ARM: shmobile: gose: Configure PFC in DT

 arch/arm/boot/dts/r8a7793-gose.dts | 31 +++++++++++++++++++++++++++++++
 arch/arm/boot/dts/r8a7793.dtsi     |  6 ++++++
 2 files changed, 37 insertions(+)
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/2 ARM: shmobile: r8a7793: Add PFC to DT

Instantiate PFC device in r8a7793 DT.

Based on similar work for the r8a7791 by Magnus Damm.

Cc Magnus Damm <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7793.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/r8a7793.dtsi +6 -0
index fcafa87616fa..6597207cd55e 100644
@@ -114,6 +114,12 @@
 		power-domains = <&cpg_clocks>;
 	};
 
+	pfc: pfc at e6060000 {
+		compatible = "renesas,pfc-r8a7793";
+		reg = <0 0xe6060000 0 0x250>;
+		#gpio-range-cells = <3>;
+	};
+
 	scif0: serial at e6e60000 {
 		compatible = "renesas,scif-r8a7793", "renesas,scif";
 		reg = <0 0xe6e60000 0 64>;
Signature · 1 line
2.1.4
author
#2 lore raw

PATCH 2/2 ARM: shmobile: gose: Configure PFC in DT

In reply to Simon Horman

Configure PFC for the already enabled scif and ethernet devices in the device tree for the gose board.

Based on similar work for the koelsch board by Laurent Pinchart and Sergei Shtylyov.

Cc Laurent Pinchart <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
arch/arm/boot/dts/r8a7793-gose.dts +31 -0
index 96443ec5f6ab..1575ef759047 100644
@@ -37,7 +37,32 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif0_pins: serial0 {
+		renesas,groups = "scif0_data_d";
+		renesas,function = "scif0";
+	};
+
+	scif1_pins: serial1 {
+		renesas,groups = "scif1_data_d";
+		renesas,function = "scif1";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	phy1_pins: phy1 {
+		renesas,groups = "intc_irq0";
+		renesas,function = "intc";
+	};
+};
+
 &ether {
+	pinctrl-0 = <&ether_pins &phy1_pins>;
+	pinctrl-names = "default";
+
 	phy-handle = <&phy1>;
 	renesas,ether-link-active-low;
 	status = "okay";

@@ -55,9 +80,15 @@
 };
 
 &scif0 {
+	pinctrl-0 = <&scif0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &scif1 {
+	pinctrl-0 = <&scif1_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
Signature · 1 line
2.1.4
#3 lore raw

PATCH 2/2 ARM: shmobile: gose: Configure PFC in DT

Hi Simon,

Quoted 5 lines · On Monday 09 November 2015 10:33:19 Simon Horman wrote:

Configure PFC for the already enabled scif and ethernet devices in the device tree for the gose board.

Based on similar work for the koelsch board by Laurent Pinchart and Sergei Shtylyov.

I can't really comment on the patch due to lack of a schematics for the Goose board, but it looks good to me in principle.

Acked-by Laurent Pinchart <[email protected]>
Quoted 61 lines
Cc Laurent Pinchart <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/r8a7793-gose.dts index 96443ec5f6ab..1575ef759047 100644

arch/arm/boot/dts/r8a7793-gose.dts +31 -0
@@ -37,7 +37,32 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif0_pins: serial0 {
+		renesas,groups = "scif0_data_d";
+		renesas,function = "scif0";
+	};
+
+	scif1_pins: serial1 {
+		renesas,groups = "scif1_data_d";
+		renesas,function = "scif1";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	phy1_pins: phy1 {
+		renesas,groups = "intc_irq0";
+		renesas,function = "intc";
+	};
+};
+
 &ether {
+	pinctrl-0 = <&ether_pins &phy1_pins>;
+	pinctrl-names = "default";
+
 	phy-handle = <&phy1>;
 	renesas,ether-link-active-low;
 	status = "okay";

@@ -55,9 +80,15 @@
 };
 
 &scif0 {
+	pinctrl-0 = <&scif0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &scif1 {
+	pinctrl-0 = <&scif1_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw

PATCH 2/2 ARM: shmobile: gose: Configure PFC in DT

Quoted 6 lines · Laurent Pinchart

Hi Simon,

Quoted 3 lines · On Monday 09 November 2015 10:33:19 Simon Horman wrote:

Configure PFC for the already enabled scif and ethernet devices in the device tree for the gose board.

Quoted 7 lines
Quoted 2 lines

Based on similar work for the koelsch board by Laurent Pinchart and Sergei Shtylyov.

I can't really comment on the patch due to lack of a schematics for the Goose board, but it looks good to me in principle.

Acked-by Laurent Pinchart <[email protected]>

Thanks, I have queued up both patches of this series.