Skip to contentSkip to conversation

Add support for Thumb-1 builds

PATCH Superseded Albert ARIBAUD 1 participant 7 messages Oct 23, 2015 – Nov 10, 2015

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v7 cover Add support for Thumb-1 builds

This series implements essential changes for thumb-1 support and activates thumb-1 build for openrd and tricorder as a proof of concept as well as a fix to bring the image sizes of openrd and tricorder targets back under an acceptable limit.

For other targets, some additional files might need to be forced to ARM building, notably architecture-specific instances of lowlevel_init.S or of cpu.c. This should be handled on a case-by-case basis.

This series has two unfixed checkpatch diagnostics:

warning: arch/arm/mach-kirkwood/Kconfig,7:
please write a paragraph that describes the config symbol fully

(no option in this Kconfig has help info)

check: board/Marvell/openrd/openrd.c,42: Avoid CamelCase: <MPP6_SYSRST_OUTn>

(this is actually not an OpenRD problem and will be fixed in another patch)

IMPORTANT NOTE:

The whole set has been build-tested across all ARM targets and no build regression was detected -- actually, the series does fix the x600 board which otherwise fails assembling an mcr instruction.

Patch 1 has been confirmed to be binary-invariant.

Patch 2 has been build- and run-tested on ED Mini V2 (switched temporarily to Thumb build) and confirmed to be binary-invariant for non-thumb target Wireless Space.

Patches 3 through 6 have been build-tested BUT HAVE NOT BEEN RUN-TESTED so far.

I will test on OpenRD (client) before the end of the merge window, but:

*********************************************************
Open-RD and Tricorder owners, PLEASE run-test this series and report on the mailing list whether the target works.
*********************************************************

Changes in v7:
- remove openrd lines from doc/README.scrapyard

Changes in v6:
- revive OpenRD targets and assume maintainership
- switch OpenRD to generic board and Thumb
- fix checkpatch warning and checks

Changes in v5:
- switched tricorder[_flash] to Thumb-1 build

Changes in v4:
- Made stm32f429-discovery explicitly state that it builds for Thumb

Changes in v3:
- added arch/arm/lib/mem{set,cpy}.S to the list of modules which should always be built in ARM state.
- Selected HAS_THUMB2 for CPU_V7M.
- Fixed invalidate_l2_cache() when building for Thumb-1.

Changes in v2:
- fixed a typo in the commit message
- added file arch/arm/thumb1/include/asm/proc-armv/system.h, which overrides arch/arm/include/asm/proc-armv/system.h when building for Thumb-1 and provides non-functional but Thumb-compilable IRQ and FIQ related macros and functions.

Albert ARIBAUD (5):
stm32f429-discovery: add CONFIG_SYS_THUMB_BUILD
arm: support Thumb-1 with CONFIG_SYS_THUMB_BUILD
tricorder: switch to CONFIG_SYS_THUMB_BUILD
kirkwood: support CONFIG_SYS_THUMB_BUILD Revive OpenRD targets

 Makefile                                       |   2 +
 arch/arm/Kconfig                               |   5 +
 arch/arm/cpu/arm926ejs/Makefile                |  11 ++
 arch/arm/cpu/arm926ejs/cache.c                 |   5 +
 arch/arm/include/asm/cache.h                   |   4 +
 arch/arm/lib/Makefile                          |  24 ++++
 arch/arm/lib/cache.c                           |  11 ++
 arch/arm/lib/memcpy.S                          |   4 +-
 arch/arm/lib/memset.S                          |   2 +-
 arch/arm/mach-kirkwood/Kconfig                 |   4 +
 arch/arm/mach-kirkwood/Makefile                |   6 +
 arch/arm/mach-orion5x/Makefile                 |  10 ++
 arch/arm/thumb1/include/asm/proc-armv/system.h |  69 +++++++++++
 board/Marvell/openrd/Kconfig                   |  12 ++
 board/Marvell/openrd/MAINTAINERS               |  12 ++
 board/Marvell/openrd/Makefile                  |  14 +++
 board/Marvell/openrd/kwbimage.cfg              | 152 +++++++++++++++++++++++
 board/Marvell/openrd/openrd.c                  | 160 +++++++++++++++++++++++++
 board/Marvell/openrd/openrd.h                  |  30 +++++
 configs/openrd_base_defconfig                  |   7 ++
 configs/openrd_client_defconfig                |   7 ++
 configs/openrd_ultimate_defconfig              |   7 ++
 doc/README.scrapyard                           |   3 -
 examples/standalone/Makefile                   |  10 ++
 include/configs/openrd.h                       | 140 ++++++++++++++++++++++
 include/configs/stm32f429-discovery.h          |   1 +
 include/configs/tricorder.h                    |   1 +
 27 files changed, 707 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/thumb1/include/asm/proc-armv/system.h
 create mode 100644 board/Marvell/openrd/Kconfig
 create mode 100644 board/Marvell/openrd/MAINTAINERS
 create mode 100644 board/Marvell/openrd/Makefile
 create mode 100644 board/Marvell/openrd/kwbimage.cfg
 create mode 100644 board/Marvell/openrd/openrd.c
 create mode 100644 board/Marvell/openrd/openrd.h
 create mode 100644 configs/openrd_base_defconfig
 create mode 100644 configs/openrd_client_defconfig
 create mode 100644 configs/openrd_ultimate_defconfig
 create mode 100644 include/configs/openrd.h
Signature · 1 line
2.1.4
#1 lore raw

PATCH v7 1/5 stm32f429-discovery: add CONFIG_SYS_THUMB_BUILD

This target is ARMv7-M therefore can only build for Thumb, but it did not #define CONFIG_SYS_THUMB_BUILD, so the U-Boot code did not know it had to build for Thumb(2), not ARM.

This patch is binary-invariant: builds of stm32f429-discovery with and without this patch were compared and found to differ only by their U-Boot version strings.

---

Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4:
- Made stm32f429-discovery explicitly state that it builds for Thumb

Changes in v3: None
Changes in v2: None

 include/configs/stm32f429-discovery.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/stm32f429-discovery.h +1 -0
index 19d9cf9..e773de4 100644
@@ -9,6 +9,7 @@
 #define __CONFIG_H
 
 #define CONFIG_STM32F4
+#define CONFIG_SYS_THUMB_BUILD
 #define CONFIG_STM32F4DISCOVERY
 #define CONFIG_SYS_GENERIC_BOARD
 
Signature · 1 line
2.1.4
#2 lore raw

PATCH v7 2/5 arm: support Thumb-1 with CONFIG_SYS_THUMB_BUILD

In reply to Albert ARIBAUD

When building a Thumb-1-only target with CONFIG_SYS_THUMB_BUILD, some files fail to build, most of the time because they include mcr instructions, which only exist for Thumb-2.

This patch introduces a Kconfig option CONFIG_THUMB2 and uses it to select between Thumb-2 and ARM mode for the aforementioned files.

---
This patch has been build-tested and run-tested on ED Mini V2, above the "edmini: switch to SPL" patch, and found to reduce U-Boot size by 25% and SPL size by 14%... and to run fine. :)

This patch has also been tested against side effects on the non-Thumb wireless_space target. The binaries produced with and without this patch were found to differ only by their version string.

Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- added arch/arm/lib/mem{set,cpy}.S to the list of modules which should always be built in ARM state.
- Selected HAS_THUMB2 for CPU_V7M.
- Fixed invalidate_l2_cache() when building for Thumb-1.

Changes in v2:
- fixed a typo in the commit message
- added file arch/arm/thumb1/include/asm/proc-armv/system.h, which overrides arch/arm/include/asm/proc-armv/system.h when building for Thumb-1 and provides non-functional but Thumb-compilable IRQ and FIQ related macros and functions.

 Makefile                                       |  2 +
 arch/arm/Kconfig                               |  5 ++
 arch/arm/cpu/arm926ejs/Makefile                | 11 ++++
 arch/arm/cpu/arm926ejs/cache.c                 |  5 ++
 arch/arm/include/asm/cache.h                   |  4 ++
 arch/arm/lib/Makefile                          | 24 +++++++++
 arch/arm/lib/cache.c                           | 11 ++++
 arch/arm/lib/memcpy.S                          |  4 +-
 arch/arm/lib/memset.S                          |  2 +-
 arch/arm/mach-orion5x/Makefile                 | 10 ++++
 arch/arm/thumb1/include/asm/proc-armv/system.h | 69 ++++++++++++++++++++++++++
 examples/standalone/Makefile                   | 10 ++++
 12 files changed, 154 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/thumb1/include/asm/proc-armv/system.h
Makefile +2 -0
index d4c35ba..d7fbf95 100644
@@ -605,6 +605,8 @@ KBUILD_CFLAGS += $(KCFLAGS)
 UBOOTINCLUDE    := \
 		-Iinclude \
 		$(if $(KBUILD_SRC), -I$(srctree)/include) \
+		$(if $(CONFIG_SYS_THUMB_BUILD), $(if $(CONFIG_HAS_THUMB2),, \
+			-I$(srctree)/arch/$(ARCH)/thumb1/include),) \
 		-I$(srctree)/arch/$(ARCH)/include \
 		-include $(srctree)/include/linux/kconfig.h
 
arch/arm/Kconfig +5 -0
index 2632099..18aca86 100644
@@ -10,6 +10,9 @@ config ARM64
 config HAS_VBAR
         bool
 
+config HAS_THUMB2
+        bool
+
 config CPU_ARM720T
         bool
 
@@ -32,9 +35,11 @@ config CPU_ARM1176
 config CPU_V7
         bool
         select HAS_VBAR
+        select HAS_THUMB2
 
 config CPU_V7M
 	bool
+        select HAS_THUMB2
 
 config CPU_PXA
         bool
arch/arm/cpu/arm926ejs/Makefile +11 -0
index 63fa159..fe78922 100644
@@ -20,3 +20,14 @@ obj-$(CONFIG_MX25) += mx25/
 obj-$(CONFIG_MX27) += mx27/
 obj-$(if $(filter mxs,$(SOC)),y) += mxs/
 obj-$(if $(filter spear,$(SOC)),y) += spear/
+
+# some files can only build in ARM or THUMB2, not THUMB1
+
+ifdef CONFIG_SYS_THUMB_BUILD
+ifndef CONFIG_HAS_THUMB2
+
+CFLAGS_cpu.o := -marm
+CFLAGS_cache.o := -marm
+
+endif
+endif
arch/arm/cpu/arm926ejs/cache.c +5 -0
index e5c1a6a..2839c86 100644
@@ -82,4 +82,9 @@ void flush_dcache_all(void)
 /*
  * Stub implementations for l2 cache operations
  */
+
 __weak void l2_cache_disable(void) {}
+
+#if defined CONFIG_SYS_THUMB_BUILD
+__weak void invalidate_l2_cache(void) {}
+#endif
arch/arm/include/asm/cache.h +4 -0
index a836e9f..1f63127 100644
@@ -16,6 +16,9 @@
 /*
  * Invalidate L2 Cache using co-proc instruction
  */
+#ifdef CONFIG_SYS_THUMB_BUILD
+void invalidate_l2_cache(void);
+#else
 static inline void invalidate_l2_cache(void)
 {
 	unsigned int val=0;
@@ -24,6 +27,7 @@ static inline void invalidate_l2_cache(void)
 		: : "r" (val) : "cc");
 	isb();
 }
+#endif
 
 void l2_cache_enable(void);
 void l2_cache_disable(void);
arch/arm/lib/Makefile +24 -0
index 2bdfaba..f3db7b5 100644
@@ -60,3 +60,27 @@ obj-$(CONFIG_DEBUG_LL)	+= debug.o
 ifneq (,$(findstring -mabi=aapcs-linux,$(PLATFORM_CPPFLAGS)))
 extra-y	+= eabi_compat.o
 endif
+
+# some files can only build in ARM or THUMB2, not THUMB1
+
+ifdef CONFIG_SYS_THUMB_BUILD
+ifndef CONFIG_HAS_THUMB2
+
+# for C files, just apend -marm, which will override previous -mthumb*
+
+CFLAGS_cache.o := -marm
+CFLAGS_cache-cp15.o := -marm
+
+# For .S, drop -mthumb* and other thumb-related options.
+# CFLAGS_REMOVE_* would not have an effet, so AFLAGS_REMOVE_*
+# was implemented and is used here.
+# Also, define ${target}_NO_THUMB_BUILD for these two targets
+# so that the code knows it should not use Thumb.
+
+AFLAGS_REMOVE_memset.o := -mthumb -mthumb-interwork
+AFLAGS_REMOVE_memcpy.o := -mthumb -mthumb-interwork
+AFLAGS_memset.o := -DMEMSET_NO_THUMB_BUILD
+AFLAGS_memcpy.o := -DMEMCPY_NO_THUMB_BUILD
+
+endif
+endif
arch/arm/lib/cache.c +11 -0
index cd13db3..3bd8710 100644
@@ -88,3 +88,14 @@ phys_addr_t noncached_alloc(size_t size, size_t align)
 	return next;
 }
 #endif /* CONFIG_SYS_NONCACHED_MEMORY */
+
+#if defined(CONFIG_SYS_THUMB_BUILD)
+void invalidate_l2_cache(void)
+{
+	unsigned int val = 0;
+
+	asm volatile("mcr p15, 1, %0, c15, c11, 0 @ invl l2 cache"
+		: : "r" (val) : "cc");
+	isb();
+}
+#endif
arch/arm/lib/memcpy.S +2 -2
index eeaf003..7d9fc0f 100644
@@ -13,7 +13,7 @@
 #include <linux/linkage.h>
 #include <asm/assembler.h>
 
-#ifdef CONFIG_SYS_THUMB_BUILD
+#if defined(CONFIG_SYS_THUMB_BUILD) && !defined(MEMCPY_NO_THUMB_BUILD)
 #define W(instr)	instr.w
 #else
 #define W(instr)	instr
@@ -62,7 +62,7 @@
 
 /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */
 	.syntax unified
-#ifdef CONFIG_SYS_THUMB_BUILD
+#if defined(CONFIG_SYS_THUMB_BUILD) && !defined(MEMCPY_NO_THUMB_BUILD)
 	.thumb
 	.thumb_func
 #endif
arch/arm/lib/memset.S +1 -1
index 7208f20..df053a3 100644
@@ -16,7 +16,7 @@
 	.align	5
 
 	.syntax unified
-#ifdef CONFIG_SYS_THUMB_BUILD
+#if defined(CONFIG_SYS_THUMB_BUILD) && !defined(MEMSET_NO_THUMB_BUILD)
 	.thumb
 	.thumb_func
 #endif
arch/arm/mach-orion5x/Makefile +10 -0
index 546ebcb..33dcad4 100644
@@ -16,3 +16,13 @@ obj-y	+= timer.o
 ifndef CONFIG_SKIP_LOWLEVEL_INIT
 obj-y	+= lowlevel_init.o
 endif
+
+# some files can only build in ARM or THUMB2, not THUMB1
+
+ifdef CONFIG_SYS_THUMB_BUILD
+ifndef CONFIG_HAS_THUMB2
+
+CFLAGS_cpu.o := -marm
+
+endif
+endif
arch/arm/thumb1/include/asm/proc-armv/system.h new file +69 -0

69 lines not on this page · raw message

examples/standalone/Makefile +10 -0
index 0863a8c..5a6ae00 100644
@@ -73,3 +73,13 @@ $(obj)/%.srec: $(obj)/% FORCE
 $(obj)/%.bin: OBJCOPYFLAGS := -O binary
 $(obj)/%.bin: $(obj)/% FORCE
 	$(call if_changed,objcopy)
+
+# some files can only build in ARM or THUMB2, not THUMB1
+
+ifdef CONFIG_SYS_THUMB_BUILD
+ifndef CONFIG_HAS_THUMB2
+
+CFLAGS_stubs.o := -marm
+
+endif
+endif
Signature · 1 line
2.1.4
#3 lore raw

PATCH v7 3/5 tricorder: switch to CONFIG_SYS_THUMB_BUILD

In reply to Albert ARIBAUD

The tricorder and tricorder_flash boards have grown too big. Reduce their size by building them with CONFIG_SYS_THUMB_BUILD.

---

Changes in v7: None
Changes in v6: None
Changes in v5:
- switched tricorder[_flash] to Thumb-1 build

Changes in v4: None
Changes in v3: None
Changes in v2: None

 include/configs/tricorder.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/tricorder.h +1 -0
index f04b572..2ac141c 100644
@@ -17,6 +17,7 @@
 #define __CONFIG_H
 
 /* High Level Configuration Options */
+#define CONFIG_SYS_THUMB_BUILD
 #define CONFIG_OMAP			/* in a TI OMAP core */
 #define CONFIG_OMAP_COMMON
 /* Common ARM Erratas */
Signature · 1 line
2.1.4
#4 lore raw

PATCH v7 4/5 kirkwood: support CONFIG_SYS_THUMB_BUILD

In reply to Albert ARIBAUD

Kirkwood files cpu.c and cache.c cannot build in Thumb state; force them in ARM state even under CONFIG_SYS_THUMB_BUILD.

---

Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 arch/arm/mach-kirkwood/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/mach-kirkwood/Makefile +6 -0
index df4756e..5abcf70 100644
@@ -9,3 +9,9 @@
 obj-y	= cpu.o
 obj-y	+= cache.o
 obj-y	+= mpp.o
+
+# cpu.o and cache.o contain CP15 instructions which cannot be run in
+# Thumb state, so build them for ARM state even with CONFIG_SYS_THUMB_BUILD
+
+CFLAGS_cpu.o := -marm
+CFLAGS_cache.o := -marm
Signature · 1 line
2.1.4
#5 lore raw

PATCH v7 5/5 Revive OpenRD targets

In reply to Albert ARIBAUD

Revert commit 7a2c1b13 which dropped OpenRD boards. Assume maintainership of OpenRD.
Remove OpenRD from scrapyard.
Switch OpenRD to generic board.
Switch to Thumb build.

---

Changes in v7:
- remove openrd lines from doc/README.scrapyard

Changes in v6:
- revive OpenRD targets and assume maintainership
- switch OpenRD to generic board and Thumb
- fix checkpatch warning and checks

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 arch/arm/mach-kirkwood/Kconfig    |   4 +
 board/Marvell/openrd/Kconfig      |  12 +++
 board/Marvell/openrd/MAINTAINERS  |  12 +++
 board/Marvell/openrd/Makefile     |  14 ++++
 board/Marvell/openrd/kwbimage.cfg | 152 ++++++++++++++++++++++++++++++++++++
 board/Marvell/openrd/openrd.c     | 160 ++++++++++++++++++++++++++++++++++++++
 board/Marvell/openrd/openrd.h     |  30 +++++++
 configs/openrd_base_defconfig     |   7 ++
 configs/openrd_client_defconfig   |   7 ++
 configs/openrd_ultimate_defconfig |   7 ++
 doc/README.scrapyard              |   3 -
 include/configs/openrd.h          | 140 +++++++++++++++++++++++++++++++++
 12 files changed, 545 insertions(+), 3 deletions(-)
 create mode 100644 board/Marvell/openrd/Kconfig
 create mode 100644 board/Marvell/openrd/MAINTAINERS
 create mode 100644 board/Marvell/openrd/Makefile
 create mode 100644 board/Marvell/openrd/kwbimage.cfg
 create mode 100644 board/Marvell/openrd/openrd.c
 create mode 100644 board/Marvell/openrd/openrd.h
 create mode 100644 configs/openrd_base_defconfig
 create mode 100644 configs/openrd_client_defconfig
 create mode 100644 configs/openrd_ultimate_defconfig
 create mode 100644 include/configs/openrd.h
arch/arm/mach-kirkwood/Kconfig +4 -0
index aab5d19..f7737bf 100644
@@ -4,6 +4,9 @@ choice
 	prompt "Marvell Kirkwood board select"
 	optional
 
+config TARGET_OPENRD
+	bool "Marvell OpenRD Board"
+
 config TARGET_DREAMPLUG
 	bool "DreamPlug Board"
 
@@ -51,6 +54,7 @@ endchoice
 config SYS_SOC
 	default "kirkwood"
 
+source "board/Marvell/openrd/Kconfig"
 source "board/Marvell/dreamplug/Kconfig"
 source "board/Marvell/guruplug/Kconfig"
 source "board/Marvell/sheevaplug/Kconfig"
board/Marvell/openrd/Kconfig new file +12 -0
new file mode 100644
index 0000000..124b66d
@@ -0,0 +1,12 @@
+if TARGET_OPENRD
+
+config SYS_BOARD
+	default "openrd"
+
+config SYS_VENDOR
+	default "Marvell"
+
+config SYS_CONFIG_NAME
+	default "openrd"
+
+endif
board/Marvell/openrd/MAINTAINERS new file +12 -0
new file mode 100644
index 0000000..3789a04
@@ -0,0 +1,12 @@
+OPENRD BOARD
+M:	Albert ARIBAUD <[email protected]>
+S:	Maintained
+F:	board/Marvell/openrd/
+F:	include/configs/openrd.h
+F:	configs/openrd_base_defconfig
+
+OPENRD_CLIENT BOARD
+M:	Albert ARIBAUD <[email protected]>
+S:	Maintained
+F:	configs/openrd_client_defconfig
+F:	configs/openrd_ultimate_defconfig
board/Marvell/openrd/Makefile new file +14 -0
new file mode 100644
index 0000000..8f95b79
@@ -0,0 +1,14 @@
+#
+# (C) Copyright 2009
+# Net Insight <www.netinsight.net>
+# Written-by: Simon Kagstrom <[email protected]>
+#
+# Based on sheevaplug:
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y	:= openrd.o
board/Marvell/openrd/kwbimage.cfg new file +152 -0

152 lines not on this page · raw message

board/Marvell/openrd/openrd.c new file +160 -0

160 lines not on this page · raw message

board/Marvell/openrd/openrd.h new file +30 -0
new file mode 100644
index 0000000..56dfeea
@@ -0,0 +1,30 @@
+/*
+ * (C) Copyright 2009
+ * Net Insight <www.netinsight.net>
+ * Written-by: Simon Kagstrom <[email protected]>
+ *
+ * Based on sheevaplug.h:
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef __OPENRD_BASE_H
+#define __OPENRD_BASE_H
+
+#define OPENRD_OE_LOW		(~(1<<28))        /* RS232 / RS485 */
+#define OPENRD_OE_HIGH		(~(1<<2))         /* SD / UART1 */
+#define OPENRD_OE_VAL_LOW		(0)       /* Sel RS232 */
+#define OPENRD_OE_VAL_HIGH		(1 << 2)  /* Sel SD */
+
+/* PHY related */
+#define MV88E1116_LED_FCTRL_REG		10
+#define MV88E1116_CPRSP_CR3_REG		21
+#define MV88E1116_MAC_CTRL_REG		21
+#define MV88E1116_PGADR_REG		22
+#define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
+#define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
+
+#endif /* __OPENRD_BASE_H */
configs/openrd_base_defconfig new file +7 -0
new file mode 100644
index 0000000..1686139
@@ -0,0 +1,7 @@
+CONFIG_ARM=y
+CONFIG_KIRKWOOD=y
+CONFIG_TARGET_OPENRD=y
+CONFIG_SYS_EXTRA_OPTIONS="BOARD_IS_OPENRD_BASE"
+# CONFIG_CMD_IMLS is not set
+# CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_SETEXPR is not set
configs/openrd_client_defconfig new file +7 -0
new file mode 100644
index 0000000..c342315
@@ -0,0 +1,7 @@
+CONFIG_ARM=y
+CONFIG_KIRKWOOD=y
+CONFIG_TARGET_OPENRD=y
+CONFIG_SYS_EXTRA_OPTIONS="BOARD_IS_OPENRD_CLIENT"
+# CONFIG_CMD_IMLS is not set
+# CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_SETEXPR is not set
configs/openrd_ultimate_defconfig new file +7 -0
new file mode 100644
index 0000000..530ba4d
@@ -0,0 +1,7 @@
+CONFIG_ARM=y
+CONFIG_KIRKWOOD=y
+CONFIG_TARGET_OPENRD=y
+CONFIG_SYS_EXTRA_OPTIONS="BOARD_IS_OPENRD_ULTIMATE"
+# CONFIG_CMD_IMLS is not set
+# CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_SETEXPR is not set
doc/README.scrapyard +0 -3
index 2760f60..5d1d11e 100644
@@ -60,9 +60,6 @@ nhk8815          arm         arm926ejs      0abdd9d0    2015-08-30  Nomadik Linu
 nhk8815_onenand  arm         arm926ejs      0abdd9d0    2015-08-30  Nomadik Linux Team <[email protected]>
 omap3_mvblx      arm         armv7          8dc372f9    2015-08-30  Michael Jones <[email protected]>
 omap3_sdp3430    arm         armv7          93b25c08    2015-08-30  Nishanth Menon <[email protected]>
-openrd_base      arm         arm926ejs      7a2c1b13    2015-08-30  Prafulla Wadaskar <[email protected]>
-openrd_client    arm         arm926ejs      7a2c1b13    2015-08-30  Prafulla Wadaskar <[email protected]>
-openrd_ultimate  arm         arm926ejs      7a2c1b13    2015-08-30  Prafulla Wadaskar <[email protected]>
 otc570           arm         arm926ejs      819216dd    2015-08-30  Daniel Gorsulowski <[email protected]>
 otc570_dataflash arm         arm926ejs      819216dd    2015-08-30  Daniel Gorsulowski <[email protected]>
 palmld           arm         pxa            35782e9c    2015-08-30  Marek Vasut <[email protected]>
include/configs/openrd.h new file +140 -0

140 lines not on this page · raw message

Signature · 1 line
2.1.4
#6 lore raw

v7 cover Add support for Thumb-1 builds

In reply to Albert ARIBAUD

Hello Albert,

Quoted 37 lines · Albert ARIBAUD

This series implements essential changes for thumb-1 support and activates thumb-1 build for openrd and tricorder as a proof of concept as well as a fix to bring the image sizes of openrd and tricorder targets back under an acceptable limit.

For other targets, some additional files might need to be forced to ARM building, notably architecture-specific instances of lowlevel_init.S or of cpu.c. This should be handled on a case-by-case basis.

This series has two unfixed checkpatch diagnostics:

warning: arch/arm/mach-kirkwood/Kconfig,7:
please write a paragraph that describes the config symbol fully

(no option in this Kconfig has help info)

check: board/Marvell/openrd/openrd.c,42: Avoid CamelCase: <MPP6_SYSRST_OUTn>

(this is actually not an OpenRD problem and will be fixed in another patch)

IMPORTANT NOTE:

The whole set has been build-tested across all ARM targets and no build regression was detected -- actually, the series does fix the x600 board which otherwise fails assembling an mcr instruction.

Patch 1 has been confirmed to be binary-invariant.

Patch 2 has been build- and run-tested on ED Mini V2 (switched temporarily to Thumb build) and confirmed to be binary-invariant for non-thumb target Wireless Space.

Patches 3 through 6 have been build-tested BUT HAVE NOT BEEN RUN-TESTED so far.

Quoted 7 lines

I will test on OpenRD (client) before the end of the merge window, but:

*********************************************************
Open-RD and Tricorder owners, PLEASE run-test this series and report on the mailing list whether the target works.
*********************************************************

Tests on OpenRD-Client uncovered an issue with commit 5ba534d2 (which introduced board_init_f_mem for crt0.S) and gcc 5.2.1. Because of this, the series was not applied so far, and a fix to 5ba534d2 was posted, on which I intended to have the series depend (and I have verified that with the fix, the series boots fine on OpenRD-Client).

However, there is already at least one board broken by 5ba534d2 (cgtqmx6eval, see <http://patchwork.ozlabs.org/patch/542266/>) for which a revert was posted.

Since there is already breakage in u-boot/master, and since there will be a fix to 5ba534d2 eventually, and since this Thumb-1 series has lingered for long enough:

Applied to u-boot-arm/master.

Amicalement,

Signature · 1 line
Albert.