asus-wmi: fix error handling in store_sys_wmi()
PATCH 1/1 asus-wmi: fix error handling in store_sys_wmi()
The asus_wmi_get_devstate_simple() returns 0-1 on success. In theory according to static checkers, it can return either -EIO or -ENODEV on failure. Currently the error handling code only handles -ENODEV and -EIO is treated as success. Let's make it handle the -EIO error as well.
It's possible that it can't actually return -EIO and this patch is not needed but in that case this patch is harmless and silences a static checker warning so it's still worth it.
drivers/platform/x86/asus-wmi.c +1 -1
@@ -1682,7 +1682,7 @@ static ssize_t store_sys_wmi(struct asus_wmi *asus, int devid,int rv, err, value; value =asus_wmi_get_devstate_simple (asus, devid); -if (value = -ENODEV )/* Check device presence */ +if (value <0 )return value; rv =parse_arg (buf, count, &value);
Quoted 11 lines · Dan Carpenter
The
asus_wmi_get_devstate_simple()returns 0-1 on success. In theory according to static checkers, it can return either-EIOor-ENODEVon failure. Currently the error handling code only handles-ENODEVand-EIOis treated as success. Let's make it handle the-EIOerror as well.It's possible that it can't actually return
-EIOand this patch is not needed but in that case this patch is harmless and silences a static checker warning so it's still worth it.Signed-off-by Dan Carpenter <[email protected]>
Thank you Dan, queued to testing.
Signature · 2 lines
Darren Hart Intel Open Source Technology Center