Skip to contentSkip to conversation

vhost-user: set link down when the char device is closed

PATCH In review Wen Congyang 3 participants 4 messages Nov 11, 2015 – Nov 23, 2015 Networking

lore
Share & tools
lore

Wen Congyang

author
#0 lore raw

PATCH 1/1 vhost-user: set link down when the char device is closed

Signed-off-by Wen Congyang <[email protected]>
---
 net/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/vhost-user.c +1 -1
index 0ebd7df..5071602 100644
@@ -188,7 +188,7 @@ static void net_vhost_user_event(void *opaque, int event)
         qmp_set_link(name, true, &err);
         break;
     case CHR_EVENT_CLOSED:
-        qmp_set_link(name, true, &err);
+        qmp_set_link(name, false, &err);
         vhost_user_stop(queues, ncs);
         break;
     }
Signature · 1 line
2.5.0
Reviewed-by on v1 1/1
#1 lore raw

Thanks.

Reviewed-by Yuanhan Liu <[email protected]>
	--yliu
Quoted 20 lines · Wen Congyang
Signed-off-by Wen Congyang <[email protected]>
---
 net/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/vhost-user.c +1 -1
index 0ebd7df..5071602 100644
@@ -188,7 +188,7 @@ static void net_vhost_user_event(void *opaque, int event)
         qmp_set_link(name, true, &err);
         break;
     case CHR_EVENT_CLOSED:
-        qmp_set_link(name, true, &err);
+        qmp_set_link(name, false, &err);
         vhost_user_stop(queues, ncs);
         break;
     }
Signature · 1 line
2.5.0
author
#2 lore raw
In reply to Wen Congyang

To Jason Wang:

I think this patch should be for qemu-2.5

Thanks
Wen Congyang

Quoted 19 lines · Wen Congyang
Signed-off-by Wen Congyang <[email protected]>
---
 net/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/vhost-user.c +1 -1
index 0ebd7df..5071602 100644
@@ -188,7 +188,7 @@ static void net_vhost_user_event(void *opaque, int event)
         qmp_set_link(name, true, &err);
         break;
     case CHR_EVENT_CLOSED:
-        qmp_set_link(name, true, &err);
+        qmp_set_link(name, false, &err);
         vhost_user_stop(queues, ncs);
         break;
     }
#3 lore raw
Quoted 6 lines · Wen

To Jason Wang:

I think this patch should be for qemu-2.5

Thanks
Wen Congyang

Hi:

I thought it was for vhost tree.

Michael:

Do you want to take this patch?

Quoted 22 lines · Wen Congyang
Quoted 19 lines
Signed-off-by Wen Congyang <[email protected]>
---
 net/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/vhost-user.c +1 -1
index 0ebd7df..5071602 100644
@@ -188,7 +188,7 @@ static void net_vhost_user_event(void *opaque, int event)
         qmp_set_link(name, true, &err);
         break;
     case CHR_EVENT_CLOSED:
-        qmp_set_link(name, true, &err);
+        qmp_set_link(name, false, &err);
         vhost_user_stop(queues, ncs);
         break;
     }