docs/manual: fix bash export syntax in example code
PATCH 1/1 docs/manual: fix bash export syntax in example code
To export a variable in .bashrc we shouldn't put a '$' at the beginning of the line, and there must be a '=' between key and value.
--- docs/manual/download-location.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/download-location.txt +1 -1
@@ -17,7 +17,7 @@ set, then the value of +BR2_DL_DIR+ in the Buildroot configuration is overridden. The following line should be added to +<~/.bashrc>+. ----------------- - $ export BR2_DL_DIR <shared download location> + export BR2_DL_DIR=<shared download location> ----------------- The download location can also be set in the +.config+ file, with the
Signature · 1 line
1.9.1
PATCH 1/1 docs/manual: fix bash export syntax in example code
Dear Luca Ceresoli,
Quoted 2 lines · Luca Ceresoli
To export a variable in .bashrc we shouldn't put a '$' at the beginning of the line, and there must be a '=' between key and value.
Well the $ is here to indicate that it's the shell prompt.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 docs/manual: fix bash export syntax in example code
Dear Thomas,
Quoted 7 lines · Thomas Petazzoni
Dear Luca Ceresoli,
Quoted 2 lines · Luca Ceresoli
To export a variable in .bashrc we shouldn't put a '$' at the beginning of the line, and there must be a '=' between key and value.
Well the $ is here to indicate that it's the shell prompt.
I would agree if this specific part of the manual were suggesting a shell command in general. Instead it's suggesting to add a line to ~/.bashrc, where a '$' does not make sense of course.
Maybe I should have explained it in my commit message?
Signature · 1 line
Luca
PATCH 1/1 docs/manual: fix bash export syntax in example code
Luca,
Quoted 3 lines · Luca Ceresoli
I would agree if this specific part of the manual were suggesting a shell command in general. Instead it's suggesting to add a line to ~/.bashrc, where a '$' does not make sense of course.
Ah, indeed, I missed that. Thanks for the explanation.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Thomas Petazzoni
AppliedPATCH 1/1 docs/manual: fix bash export syntax in example code
In reply to Luca CeresoliDear Luca Ceresoli,
Quoted 7 lines · Luca Ceresoli
To export a variable in .bashrc we shouldn't put a '$' at the beginning of the line, and there must be a '=' between key and value.
Signed-off-by Luca Ceresoli <[email protected]>--- docs/manual/download-location.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com