meta: fix gdbm and clutter-gst-3.0

PATCH In review Robert Yang 4 participants 9 messages Nov 12, 2015 – Nov 18, 2015

lore

Share & tools

lore

Robert Yang

author

2015-11-12 08:51 UTC #0 lore raw

cover meta: fix gdbm and clutter-gst-3.0

The following changes since commit e44ed8c18e395b9c055aefee113b90708e8a8a2f:

build-appliance-image: Update to jethro head revision (2015-11-03 14:02:57 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/2fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/2fixes

Robert Yang (2):
gdbm 1.8.3: install libgdbm_compat
clutter-gst-3.0: add --enable/disable-gudev

 meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
 .../0001-configure.ac-add-enable-gudev.patch       |   45 ++++++++++++++++++++
 meta/recipes-support/gdbm/gdbm_1.8.3.bb            |    1 +
 3 files changed, 60 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch

Signature · 1 line

1.7.9.5

Robert Yang

author

2015-11-12 08:51 UTC #1 lore raw

PATCH 1/2 gdbm 1.8.3: install libgdbm_compat

It has been built but not installed by default, while 1.11 builds and installs it.

Fixed when build non_gplv3 + perl:
powerpc64-wrs-linux-gcc -m64 -mhard-float -mcpu=e6500 --sysroot=/mnt/docker/test_p/bitbake_build/tmp/sysroots/fsl-t2xxx -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed - fstack-protector -shared NDBM_File.o -o
../../lib/auto/NDBM_File/NDBM_File.so \
-lgdbm -lgdbm_compat \

ld: cannot find -lgdbm_compat
collect2: error: ld returned 1 exit status
Makefile:473: recipe for target '../../lib/auto/NDBM_File/NDBM_File.so' failed

Signed-off-by Robert Yang <[email protected]>

---
 meta/recipes-support/gdbm/gdbm_1.8.3.bb |    1 +
 1 file changed, 1 insertion(+)

meta/recipes-support/gdbm/gdbm_1.8.3.bb +1 -0

index af01b6c..b253dc1 100644
@@ -19,6 +19,7 @@ inherit autotools texinfo
 BBCLASSEXTEND = "native nativesdk"
 
 do_install_append () {
+    oe_runmake install-compat DESTDIR=${D}
     install -d ${D}${includedir}/gdbm
     install -m 0644 ${S}/dbm.h ${D}${includedir}/
     install -m 0644 ${S}/ndbm.h ${D}${includedir}/

Signature · 1 line

1.7.9.5

Robert Yang

author

2015-11-12 08:51 UTC #2 lore raw

PATCH 2/2 clutter-gst-3.0: add --enable/disable-gudev

In reply to Robert Yang

Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either.

Fixed:
libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'

Signed-off-by Robert Yang <[email protected]>

---
 meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
 .../0001-configure.ac-add-enable-gudev.patch       |   45 ++++++++++++++++++++
 2 files changed, 59 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch

meta/recipes-graphics/clutter/clutter-gst-3.0.inc +14 -1

index d4fed71..c29bc7a 100644
@@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
 
 inherit clutter
 
-SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch"
+SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
+            file://0001-configure.ac-add-enable-gudev.patch \
+            "
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
 
 DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0"
 RDEPENDS_${PN} += "gstreamer1.0-meta-base"

@@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"
 
 EXTRA_OECONF += "--disable-introspection"
 
+python () {
+    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \
+        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
+            bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \
+                    d.getVar("PN", True))
+            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
+}
+
 FILES_${PN}          += "${libdir}/gstreamer-1.0/lib*.so"
 FILES_${PN}-dev      += "${libdir}/gstreamer-1.0/*.la"
 FILES_${PN}-dbg      += "${libdir}/gstreamer-1.0/.debug/lib*.so"

meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch new file +45 -0

45 lines not on this page · raw message

Signature · 1 line

1.7.9.5

Andreas Müller

2015-11-12 09:00 UTC #3 lore raw

Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

Quoted 34 lines · Robert Yang

Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either.

Fixed:
libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'

Signed-off-by Robert Yang <[email protected]>

---
 meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
 .../0001-configure.ac-add-enable-gudev.patch       |   45 ++++++++++++++++++++
 2 files changed, 59 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch

meta/recipes-graphics/clutter/clutter-gst-3.0.inc +6 -1

index d4fed71..c29bc7a 100644
@@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
 
 inherit clutter
 
-SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch"
+SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
+            file://0001-configure.ac-add-enable-gudev.patch \
+            "
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
 
 DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0"
 RDEPENDS_${PN} += "gstreamer1.0-meta-base"

@@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"

meta/recipes-graphics/clutter/clutter-gst-3.0.inc PACKAGES =+ "${PN}-examples" · line 27

Quoted 10 lines

meta/recipes-graphics/clutter/clutter-gst-3.0.inc +8 -0

 EXTRA_OECONF += "--disable-introspection"
 
+python () {
+    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \
+        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
+            bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \
+                    d.getVar("PN", True))
+            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
+}
+

I think this part of the patch is wrong: You have to replace udev by gudev in DEPENDS part of packageconfig above and skip python function complete.

Andreas

Robert Yang

author

2015-11-12 09:06 UTC #4 lore raw

Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

Quoted 37 lines · Andreas Müller

Quoted 36 lines · Robert Yang
Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either.
Fixed:
libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'
Signed-off-by Robert Yang <[email protected]>
---
  meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
  .../0001-configure.ac-add-enable-gudev.patch       |   45 ++++++++++++++++++++
  2 files changed, 59 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +6 -1
index d4fed71..c29bc7a 100644
@@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
 
  inherit clutter
 
-SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch"
+SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
+            file://0001-configure.ac-add-enable-gudev.patch \
+            "
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
 
  DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0"
  RDEPENDS_${PN} += "gstreamer1.0-meta-base"
@@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"
 
  EXTRA_OECONF += "--disable-introspection"
 

Quoted 10 lines

meta/recipes-graphics/clutter/clutter-gst-3.0.inc PACKAGES =+ "${PN}-examples" · line 27
Quoted 8 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +8 -0
+python () {
+    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \
+        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
+            bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \
+                    d.getVar("PN", True))
+            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
+}
+
I think this part of the patch is wrong: You have to replace udev by gudev in DEPENDS part of packageconfig above and skip python function

I think that there is no gudev but udev ? udev provides gudev, but systemd only provides udev, no gudev.

// Robert

Quoted 4 lines

complete.
Andreas

Andreas Müller

2015-11-12 09:17 UTC #5 lore raw

Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

Quoted 65 lines · Robert Yang

Quoted 47 lines · Andreas Müller
Quoted 44 lines · Robert Yang
Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either.
Fixed:
libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'
Signed-off-by Robert Yang <[email protected]>
---
  meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
  .../0001-configure.ac-add-enable-gudev.patch       |   45
++++++++++++++++++++
  2 files changed, 59 insertions(+), 1 deletion(-)
create mode 100644
meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +0 -1
index d4fed71..c29bc7a 100644
@@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
 
  inherit clutter
 
-SRC_URI +=
"file://0001-Install-example-binary-needed-for-core-image-clutter.patch" +SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +5 -0
+            file://0001-configure.ac-add-enable-gudev.patch \
+            "
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
 
  DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad
clutter-1.0"
RDEPENDS_${PN} += "gstreamer1.0-meta-base"
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +0 -0
@@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"
 
  EXTRA_OECONF += "--disable-introspection"
 
Quoted 13 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc PACKAGES =+ "${PN}-examples" · line 27
Quoted 10 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +8 -0
+python () {
+    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False,
 d) and \
+        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
+            bb.warn("%s: gudev can't be enabled since systemd doesn't
 provide libgudev" % \
+                    d.getVar("PN", True))
+            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
+}
+
I think this part of the patch is wrong: You have to replace udev by gudev in DEPENDS part of packageconfig above and skip python function

Quoted 3 lines

I think that there is no gudev but udev ? udev provides gudev, but systemd only provides udev, no gudev.

Sorry I meant libgudev - it is in meta-oe.

I think there two cases of interest (packageconfig 'gudev' not set is boring - so not a case :)

* distros with system: If packageconfig 'gudev' is set and meta-oe is not layers a parse error will occure similar to your python code.
* non-systemd-distros: If packageconfig is set udev is pulled in (udev provides gudev for non systemd distros)

Regards

Andreas

Robert Yang

author

2015-11-13 05:54 UTC #6 lore raw

Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

Quoted 71 lines · Andreas Müller

Quoted 65 lines · Robert Yang
Quoted 47 lines · Andreas Müller
Quoted 44 lines · Robert Yang
Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either.
Fixed:
libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'
Signed-off-by Robert Yang <[email protected]>
---
   meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
   .../0001-configure.ac-add-enable-gudev.patch       |   45
++++++++++++++++++++
   2 files changed, 59 insertions(+), 1 deletion(-)
create mode 100644
meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +0 -1
index d4fed71..c29bc7a 100644
@@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
 
   inherit clutter
 
-SRC_URI +=
"file://0001-Install-example-binary-needed-for-core-image-clutter.patch" +SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +5 -0
+            file://0001-configure.ac-add-enable-gudev.patch \
+            "
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
 
   DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad
clutter-1.0"
RDEPENDS_${PN} += "gstreamer1.0-meta-base"
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +0 -0
@@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"
 
   EXTRA_OECONF += "--disable-introspection"
 
Quoted 13 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc PACKAGES =+ "${PN}-examples" · line 27
Quoted 10 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +8 -0
+python () {
+    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False,
 d) and \
+        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
+            bb.warn("%s: gudev can't be enabled since systemd doesn't
 provide libgudev" % \
+                    d.getVar("PN", True))
+            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
+}
+
I think this part of the patch is wrong: You have to replace udev by gudev in DEPENDS part of packageconfig above and skip python function
Quoted 3 lines
I think that there is no gudev but udev ? udev provides gudev, but systemd only provides udev, no gudev.
Sorry I meant libgudev - it is in meta-oe.

Quoted 7 lines

I think there two cases of interest (packageconfig 'gudev' not set is boring - so not a case :)
* distros with system: If packageconfig 'gudev' is set and meta-oe is not layers a parse error will occure similar to your python code.
* non-systemd-distros: If packageconfig is set udev is pulled in (udev provides gudev for non systemd distros)

Sorry, what did you mean, please ? Are fine with this patch ?

// Robert

Quoted 5 lines

Regards
Andreas

Burton, Ross

2015-11-18 23:01 UTC #7 lore raw

Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

Quoted 2 lines · Robert Yang

Sorry, what did you mean, please ? Are fine with this patch ?

No. The code checks for libgudev but your adding a build dependency of udev, which only provides gudev when systemd isn't enabled.

Ross

Martin Jansa

2015-11-12 10:24 UTC #8 lore raw

Re: [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

In reply to Robert Yang

Quoted 51 lines · Robert Yang

Quoted 37 lines · Andreas Müller
Quoted 36 lines · Robert Yang
Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so it can't be enabled when systemd either.
Fixed:
libtool: error: cannot find the library 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'
Signed-off-by Robert Yang <[email protected]>
---
  meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
  .../0001-configure.ac-add-enable-gudev.patch       |   45 ++++++++++++++++++++
  2 files changed, 59 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +6 -1
index d4fed71..c29bc7a 100644
@@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
 
  inherit clutter
 
-SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch"
+SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
+            file://0001-configure.ac-add-enable-gudev.patch \
+            "
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
 
  DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0"
  RDEPENDS_${PN} += "gstreamer1.0-meta-base"
@@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"
 
  EXTRA_OECONF += "--disable-introspection"
 
Quoted 10 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc PACKAGES =+ "${PN}-examples" · line 27
Quoted 8 lines
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +8 -0
+python () {
+    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False, d) and \
+        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
+            bb.warn("%s: gudev can't be enabled since systemd doesn't provide libgudev" % \
+                    d.getVar("PN", True))
+            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
+}
+
I think this part of the patch is wrong: You have to replace udev by gudev in DEPENDS part of packageconfig above and skip python function

Quoted 2 lines

I think that there is no gudev but udev ? udev provides gudev, but systemd only provides udev, no gudev.

There is gudev in meta-oe (for people using systemd):
meta-oe/recipes-gnome/libgudev/libgudev_230.bb

Quoted 12 lines

// Robert

Quoted 4 lines

complete.
Andreas

Signature · 4 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]