Skip to contentSkip to conversation

common: Simplify get_clocks() #ifdef

PATCH New Peng Fan 3 participants 3 messages Oct 30, 2015 – Nov 13, 2015

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH v2 1/1 common: Simplify get_clocks() #ifdef

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate piece code. They can be merged into one snippet.

Signed-off-by Peng Fan <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Alexey Brodkin <[email protected]>
Cc "angelo at sysam.it" <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Stephen Warren <[email protected]>
Cc "Andreas Bie?mann" <[email protected]>
Reviewed-by Simon Glass <[email protected]>

---

Changes V2:
Refine patch subject as Simon suggested.
Add Simon's Reviewed-by

 common/board_f.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
common/board_f.c +1 -4
index 486e828..7bc05b1 100644
@@ -806,10 +806,7 @@ static init_fnc_t init_sequence_f[] = {
 #if defined(CONFIG_BOARD_POSTCLK_INIT)
 	board_postclk_init,
 #endif
-#ifdef CONFIG_FSL_CLK
-	get_clocks,
-#endif
-#ifdef CONFIG_M68K
+#if defined(CONFIG_FSL_CLK) || defined(CONFIG_M68K)
 	get_clocks,
 #endif
 	env_init,		/* initialize environment */
Signature · 1 line
1.8.4
#1 lore raw

PATCH v2 1/1 common: Simplify get_clocks() #ifdef

Hi Peng,

Quoted 29 lines · Peng Fan

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate piece code. They can be merged into one snippet.

Signed-off-by Peng Fan <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Alexey Brodkin <[email protected]>
Cc "angelo at sysam.it" <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Stephen Warren <[email protected]>
Cc "Andreas Bie?mann" <[email protected]>
Reviewed-by Simon Glass <[email protected]>

---

Changes V2:
Refine patch subject as Simon suggested.
Add Simon's Reviewed-by

  common/board_f.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
common/board_f.c +0 -0
index 486e828..7bc05b1 100644
@@ -806,10 +806,7 @@ static init_fnc_t init_sequence_f[] = {
  #if defined(CONFIG_BOARD_POSTCLK_INIT)

common/board_f.c static init_fnc_t init_sequence_f[] = { · line 812

Quoted 10 lines
common/board_f.c +1 -4
  	board_postclk_init,
  #endif
-#ifdef CONFIG_FSL_CLK
-	get_clocks,
-#endif
-#ifdef CONFIG_M68K
+#if defined(CONFIG_FSL_CLK) || defined(CONFIG_M68K)
  	get_clocks,
  #endif
  	env_init,		/* initialize environment */

change is ok for me.

Acked-by Angelo Dureghello <[email protected]>
#2 lore raw

PATCH v2 1/1 common: Simplify get_clocks() #ifdef

In reply to Peng Fan
Quoted 14 lines · Peng Fan

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate piece code. They can be merged into one snippet.

Signed-off-by Peng Fan <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Alexey Brodkin <[email protected]>
Cc "angelo at sysam.it" <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Stephen Warren <[email protected]>
Cc "Andreas Bie?mann" <[email protected]>
Reviewed-by Simon Glass <[email protected]>
Acked-by Angelo Dureghello <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151112/cc5c3b6a/attachment.sig>