Fix sandbox build on Ubuntu 10.04
PATCH 1/1 Fix sandbox build on Ubuntu 10.04
gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04) doesn't seem to like initializers for sub-fields of anonymous unions. Solve this by replacing the initialization with an assignment. This fixes:
lib/lz4_wrapper.c: In function ?ulz4fn?:lib/lz4_wrapper.c:97: error: unknown field ?raw? specified in initializer
--- lib/lz4_wrapper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
lib/lz4_wrapper.c +3 -1
@@ -94,7 +94,9 @@ int ulz4fn(const void *src, size_t srcn, void *dst, size_t *dstn) }while (1 ) { -struct lz4_block_header b = { .raw =le32_to_cpu (*(u32 *)in) }; +struct lz4_block_header b; + + b.raw =le32_to_cpu (*(u32 *)in); in +=sizeof (struct lz4_block_header );if (in - src + b.size > srcn) {
Signature · 1 line
1.9.1
PATCH 1/1 Fix sandbox build on Ubuntu 10.04
Quoted 9 lines · Stephen Warren
gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04) doesn't seem to like initializers for sub-fields of anonymous unions. Solve this by replacing the initialization with an assignment. This fixes:
lib/lz4_wrapper.c: In function ?ulz4fn?:lib/lz4_wrapper.c:97: error: unknown field ?raw? specified in initializerSigned-off-by Stephen Warren <[email protected]>
So Ubuntu 10.04 hit end of life this past April. I can be convinced but as I'm personally staring down upgrading my 12.04 machine I need some reason.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151115/d6e5005d/attachment.sig>
PATCH 1/1 Fix sandbox build on Ubuntu 10.04
Quoted 7 lines · Tom Rini
Quoted 5 lines · Stephen Warren
gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04) doesn't seem to like initializers for sub-fields of anonymous unions. Solve this by replacing the initialization with an assignment. This fixes:
Quoted 8 lines
Quoted 4 lines
lib/lz4_wrapper.c: In function ?ulz4fn?:lib/lz4_wrapper.c:97:
error: unknown field ?raw? specified in initializerSigned-off-by Stephen Warren <[email protected]>So Ubuntu 10.04 hit end of life this past April. I can be convinced but as I'm personally staring down upgrading my 12.04 machine I need some reason.
For some reason I though the support life was 5 years desktop and longer for server, but it looks like 5 years was the server period. Oh well.
I suspect this patch may still be useful though; RHEL5 is still supported until March 31, 2017[1], and apparently has an even older compiler (gcc 4.1.x)[2]
[1] https://access.redhat.com/support/policy/updates/errata
[2] https://access.redhat.com/solutions/19458
PATCH 1/1 Fix sandbox build on Ubuntu 10.04
Quoted 21 lines · Stephen Warren
Quoted 7 lines · Tom Rini
Quoted 5 lines · Stephen Warren
gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04) doesn't seem to like initializers for sub-fields of anonymous unions. Solve this by replacing the initialization with an assignment. This fixes:
Quoted 8 lines
Quoted 4 lines
lib/lz4_wrapper.c: In function ?ulz4fn?:lib/lz4_wrapper.c:97:
error: unknown field ?raw? specified in initializerSigned-off-by Stephen Warren <[email protected]>So Ubuntu 10.04 hit end of life this past April. I can be convinced but as I'm personally staring down upgrading my 12.04 machine I need some reason.
For some reason I though the support life was 5 years desktop and longer for server, but it looks like 5 years was the server period. Oh well.
Quoted 6 lines
I suspect this patch may still be useful though; RHEL5 is still supported until March 31, 2017[1], and apparently has an even older compiler (gcc 4.1.x)[2]
[1] https://access.redhat.com/support/policy/updates/errata
[2] https://access.redhat.com/solutions/19458
OK, that works for me, thanks.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151116/1cd00da6/attachment.sig>
PATCH 1/1 Fix sandbox build on Ubuntu 10.04
Quoted 26 lines · Tom Rini
Quoted 25 lines · Stephen Warren
Quoted 7 lines · Tom Rini
Quoted 5 lines · Stephen Warren
gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04) doesn't seem to like initializers for sub-fields of anonymous unions. Solve this by replacing the initialization with an assignment. This fixes:
Quoted 8 lines
Quoted 4 lines
lib/lz4_wrapper.c: In function ?ulz4fn?:lib/lz4_wrapper.c:97:
error: unknown field ?raw? specified in initializerSigned-off-by Stephen Warren <[email protected]>So Ubuntu 10.04 hit end of life this past April. I can be convinced but as I'm personally staring down upgrading my 12.04 machine I need some reason.
For some reason I though the support life was 5 years desktop and longer for server, but it looks like 5 years was the server period. Oh well.
I suspect this patch may still be useful though; RHEL5 is still supported until March 31, 2017[1], and apparently has an even older compiler (gcc 4.1.x)[2]
Quoted 6 lines
Quoted 2 lines
[1] https://access.redhat.com/support/policy/updates/errata
[2] https://access.redhat.com/solutions/19458OK, that works for me, thanks.
Reviewed-by Tom Rini <[email protected]>
Quoted 11 lines · Stephen Warren
gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04) doesn't seem to like initializers for sub-fields of anonymous unions. Solve this by replacing the initialization with an assignment. This fixes:
lib/lz4_wrapper.c: In function ?ulz4fn?:lib/lz4_wrapper.c:97: error: unknown field ?raw? specified in initializerSigned-off-by Stephen Warren <[email protected]>Reviewed-by Tom Rini <[email protected]>Acked-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151118/03f96ea8/attachment.sig>