Skip to contentSkip to conversation

net: dns_resolver: convert time_t to time64_t

PATCH In review Aya Mahfouz 4 participants 5 messages Nov 18, 2015

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Aya Mahfouz

author
#0 lore raw

PATCH 1/1 net: dns_resolver: convert time_t to time64_t

Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.

Signed-off-by Arnd Bergmann <[email protected]>
Signed-off-by Aya Mahfouz <[email protected]>

---
Changelog:
v1: The changes were originally made by Arnd Bergmann in relation to time_t. I've broken down a patch sent to me into two independent patches.

 include/linux/dns_resolver.h | 2 +-
 net/dns_resolver/dns_query.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/dns_resolver.h +1 -1
index cc92268..6ac3cad 100644
@@ -27,7 +27,7 @@
 #ifdef __KERNEL__
 
 extern int dns_query(const char *type, const char *name, size_t namelen,
-		     const char *options, char **_result, time_t *_expiry);
+		     const char *options, char **_result, time64_t *_expiry);
 
 #endif /* KERNEL */
net/dns_resolver/dns_query.c +1 -1
index 4677b6f..ecc28cf 100644
@@ -67,7 +67,7 @@
  * Returns the size of the result on success, -ve error code otherwise.
  */
 int dns_query(const char *type, const char *name, size_t namelen,
-	      const char *options, char **_result, time_t *_expiry)
+	      const char *options, char **_result, time64_t *_expiry)
 {
 	struct key *rkey;
 	const struct user_key_payload *upayload;
Signature · 6 lines
2.4.3


-- 
Kind Regards,
Aya Saif El-yazal Mahfouz
maintainer
#1 lore raw

From: Aya Mahfouz <[email protected]>
Date: Wed, 18 Nov 2015 08:36:44 +0200

Quoted 5 lines

Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.

Quoted 7 lines
Signed-off-by Arnd Bergmann <[email protected]>
Signed-off-by Aya Mahfouz <[email protected]>

---
Changelog:
v1: The changes were originally made by Arnd Bergmann in relation to time_t. I've broken down a patch sent to me into two independent patches.

Want me to apply this to 'net'?

#2 lore raw
Quoted 16 lines · On Wednesday 18 November 2015 15:20:25 David Miller wrote:

From: Aya Mahfouz <[email protected]>
Date: Wed, 18 Nov 2015 08:36:44 +0200

Quoted 5 lines

Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.

Quoted 7 lines
Signed-off-by Arnd Bergmann <[email protected]>
Signed-off-by Aya Mahfouz <[email protected]>

---
Changelog:
v1: The changes were originally made by Arnd Bergmann in relation to time_t. I've broken down a patch sent to me into two independent patches.

Quoted 1 line

Want me to apply this to 'net'?

Yes, I think that would be good. The original patch was touching both the key and net subsystems, but this patch makes sense by itself now, and it helps keep the other half isolated to the key code.

Arnd

maintainer
#3 lore raw

From: Arnd Bergmann <[email protected]>
Date: Wed, 18 Nov 2015 22:08:54 +0100

Quoted 17 lines · On Wednesday 18 November 2015 15:20:25 David Miller wrote:
Quoted 16 lines

From: Aya Mahfouz <[email protected]>
Date: Wed, 18 Nov 2015 08:36:44 +0200

Quoted 12 lines

Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.

Signed-off-by Arnd Bergmann <[email protected]>
Signed-off-by Aya Mahfouz <[email protected]>

---
Changelog:
v1: The changes were originally made by Arnd Bergmann in relation to time_t. I've broken down a patch sent to me into two independent patches.

Quoted 5 lines
Quoted 1 line

Want me to apply this to 'net'?

Yes, I think that would be good. The original patch was touching both the key and net subsystems, but this patch makes sense by itself now, and it helps keep the other half isolated to the key code.

OK, it sounds like we can simply delete the argument if nobody in-tree uses it.

But whatever... applied thanks.

Acked-by
#4 lore raw
In reply to David Miller
Quoted 16 lines · David Miller

From: Aya Mahfouz <[email protected]>
Date: Wed, 18 Nov 2015 08:36:44 +0200

Quoted 5 lines

Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL.

Quoted 7 lines
Signed-off-by Arnd Bergmann <[email protected]>
Signed-off-by Aya Mahfouz <[email protected]>

---
Changelog:
v1: The changes were originally made by Arnd Bergmann in relation to time_t. I've broken down a patch sent to me into two independent patches.

Quoted 1 line

Want me to apply this to 'net'?

Fine by me.

Acked-by David Howells <[email protected]>