Skip to contentSkip to conversation

cpufreq: scpi: Depend on SCPI clk driver

PATCH New Punit Agrawal 3 participants 3 messages Nov 18, 2015 – Nov 23, 2015 CPU frequency scaling framework

lore
Share & tools
lore

Punit Agrawal

author
#0 lore raw

PATCH v2 1/1 cpufreq: scpi: Depend on SCPI clk driver

The SCPI clk driver registers the virtual cpufreq device that kicks off initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for the cpufreq driver if the scpi clk driver is missing.

Fix this by making the scpi cpufreq driver explicitly depend on the scpi clk driver.

Fixes 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
Signed-off-by Punit Agrawal <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc Viresh Kumar <[email protected]>
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +1 -1
index 1582c1c..dadfdd4 100644
@@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
 
 config ARM_SCPI_CPUFREQ
         tristate "SCPI based CPUfreq driver"
-	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
+	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
         help
 	  This adds the CPUfreq driver support for ARM big.LITTLE platforms
 	  using SCPI protocol for CPU power management.
Signature · 1 line
2.6.2
maintainer
#1 lore raw

PATCH v2 1/1 cpufreq: scpi: Depend on SCPI clk driver

Quoted 21 lines · Punit Agrawal

The SCPI clk driver registers the virtual cpufreq device that kicks off initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for the cpufreq driver if the scpi clk driver is missing.

Fix this by making the scpi cpufreq driver explicitly depend on the scpi clk driver.

Fixes 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
Signed-off-by Punit Agrawal <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc Viresh Kumar <[email protected]>
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +0 -0
index 1582c1c..dadfdd4 100644

drivers/cpufreq/Kconfig.arm config ARM_SA1110_CPUFREQ · line 207

Quoted 8 lines
drivers/cpufreq/Kconfig.arm +1 -1
@@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
 
 config ARM_SCPI_CPUFREQ
         tristate "SCPI based CPUfreq driver"
-	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
+	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
         help
 	  This adds the CPUfreq driver support for ARM big.LITTLE platforms
 	  using SCPI protocol for CPU power management.
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh
Applied
#2 lore raw

PATCH v2 1/1 cpufreq: scpi: Depend on SCPI clk driver

Quoted 23 lines · Viresh Kumar
Quoted 22 lines · Punit Agrawal

The SCPI clk driver registers the virtual cpufreq device that kicks off initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for the cpufreq driver if the scpi clk driver is missing.

Fix this by making the scpi cpufreq driver explicitly depend on the scpi clk driver.

Fixes 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
Signed-off-by Punit Agrawal <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc Viresh Kumar <[email protected]>
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +0 -0
index 1582c1c..dadfdd4 100644
@@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
Quoted 9 lines

drivers/cpufreq/Kconfig.arm config ARM_SA1110_CPUFREQ · line 207

Quoted 7 lines
drivers/cpufreq/Kconfig.arm +1 -1
 config ARM_SCPI_CPUFREQ
         tristate "SCPI based CPUfreq driver"
-	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
+	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
         help
 	  This adds the CPUfreq driver support for ARM big.LITTLE platforms
 	  using SCPI protocol for CPU power management.
Acked-by Viresh Kumar <[email protected]>

Applied, thanks!

Rafael