Skip to contentSkip to conversation

Adjust server-ipv6 documentation

PATCH In review Christos Trochalakis 2 participants 6 messages Nov 18, 2015 – Nov 21, 2015

lore
Share & tools
lore

Christos Trochalakis

author
#0 lore raw

PATCH 1/1 Adjust server-ipv6 documentation

o --server-ipv6 is incompatible with the 'nopool' option
o ifconfig-ipv6-pool starts at 0x1000 and not 0x10000 since v2.3
c55e9562: Implement IPv6 interface config with non-/64 prefix lengths

Signed-off-by Christos Trochalakis <[email protected]...>

---
src/openvpn/helper.c | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
src/openvpn/helper.c +1 -1
index 339e2ae..1af73b1 100644
@@ -166,8 +166,7 @@ helper_client_server (struct options *o)
   * tun-ipv6
   * push "tun-ipv6"
   * ifconfig-ipv6 2001:db8::1 2001:db8::2
-   * if !nopool: -   *   ifconfig-ipv6-pool 2001:db8::1:0/64
+   * ifconfig-ipv6-pool 2001:db8::1000/64
   * 
   */
   if ( o->server_ipv6_defined )
Signature · 1 line
2.6.2
#1 lore raw

Hi,

Quoted 5 lines · Christos Trochalakis

o --server-ipv6 is incompatible with the 'nopool' option
o ifconfig-ipv6-pool starts at 0x1000 and not 0x10000 since v2.3
c55e9562: Implement IPv6 interface config with non-/64 prefix lengths

Signed-off-by Christos Trochalakis <[email protected]...>

Uh, yes, in principle, but...

Review

Quoted 5 lines

* push "tun-ipv6"
* ifconfig-ipv6 2001:db8::1 2001:db8::2

(quoted diff) +1 -2
-   * if !nopool: 
-   *   ifconfig-ipv6-pool 2001:db8::1:0/64
+   * ifconfig-ipv6-pool 2001:db8::1000/64

... the "if !nopool" should still be there, no?

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
author
#2 lore raw

Hello Gert,

Quoted 11 lines · Gert Doering

Hi,

Quoted 5 lines · Christos Trochalakis

o --server-ipv6 is incompatible with the 'nopool' option
o ifconfig-ipv6-pool starts at 0x1000 and not 0x10000 since v2.3
c55e9562: Implement IPv6 interface config with non-/64 prefix lengths

Signed-off-by Christos Trochalakis <[email protected]...>

Uh, yes, in principle, but...

Quoted 8 lines

Review

Quoted 5 lines

* push "tun-ipv6"
* ifconfig-ipv6 2001:db8::1 2001:db8::2

(quoted diff) +1 -2
-   * if !nopool:
-   *   ifconfig-ipv6-pool 2001:db8::1:0/64
+   * ifconfig-ipv6-pool 2001:db8::1000/64

... the "if !nopool" should still be there, no?

If I understand correctly 'nopool' option is only valid for --server and not --server-ipv6.

#3 lore raw

Hi,

Quoted 16 lines · Christos Trochalakis
Quoted 15 lines · Gert Doering
Quoted 5 lines · Christos Trochalakis

o --server-ipv6 is incompatible with the 'nopool' option
o ifconfig-ipv6-pool starts at 0x1000 and not 0x10000 since v2.3
c55e9562: Implement IPv6 interface config with non-/64 prefix lengths

Signed-off-by Christos Trochalakis <[email protected]...>

Uh, yes, in principle, but...

Quoted 5 lines

* push "tun-ipv6"
* ifconfig-ipv6 2001:db8::1 2001:db8::2

(quoted diff) +1 -2
-   * if !nopool:
-   *   ifconfig-ipv6-pool 2001:db8::1:0/64
+   * ifconfig-ipv6-pool 2001:db8::1000/64
Quoted 5 lines
Quoted 2 lines

... the "if !nopool" should still be there, no?

If I understand correctly 'nopool' option is only valid for --server and not --server-ipv6.

What brings you to that assumption? (Background: if there is no IPv4 pool, the IPv6 pool will not work, given the way the IPv6 pool is implemented)

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
author
#4 lore raw

PATCH 1/1 Adjust server-ipv6 documentation

ifconfig-ipv6-pool starts at 0x1000 and not 0x10000 since v2.3
c55e9562: Implement IPv6 interface config with non-/64 prefix lengths

Signed-off-by Christos Trochalakis <[email protected]...>

---

You were right about nopool, I assumed that it was about a server-ipv6 nopool option.

src/openvpn/helper.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/helper.c +1 -1
index 339e2ae..62f88ec 100644
@@ -167,7 +167,7 @@ helper_client_server (struct options *o)
   * push "tun-ipv6"
   * ifconfig-ipv6 2001:db8::1 2001:db8::2
   * if !nopool: 
-   *   ifconfig-ipv6-pool 2001:db8::1:0/64
+   *   ifconfig-ipv6-pool 2001:db8::1000/64
   * 
   */
   if ( o->server_ipv6_defined )
Signature · 1 line
2.6.2
#5 lore raw

ACK, thanks.

Your patch has been applied to the master and release/2.3 branch.

commit e60849a708c7b70f0d7d2363489863e4c5c9c893 (master) commit 68cc5e7f34d824057819662954336bc6328dcaca (release/2.3)

Author: Christos Trochalakis
Date:   Thu Nov 19 14:47:23 2015 +0200
     Adjust server-ipv6 documentation

     Signed-off-by: Christos Trochalakis <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/10537
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering