Skip to contentSkip to conversation

configs/qemu: cleanup and capitalization

PATCH New Gustavo Zacarias 3 participants 5 messages Nov 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 configs/qemu: cleanup and capitalization

Capitalize comments in a consistent way.
Cleanup redundant entries.
Drop global patch dir for sparc ss10 since it's not required any more.

---
 configs/qemu_arm_nuri_defconfig      | 2 --
 configs/qemu_arm_versatile_defconfig | 5 ++---
 configs/qemu_arm_vexpress_defconfig  | 2 --
 configs/qemu_mips_malta_defconfig    | 2 +-
 configs/qemu_mipsel_malta_defconfig  | 2 +-
 configs/qemu_ppc64_pseries_defconfig | 1 -
 configs/qemu_ppc_g3beige_defconfig   | 2 +-
 configs/qemu_ppc_mpc8544ds_defconfig | 2 +-
 configs/qemu_sh4_r2d_defconfig       | 5 ++---
 configs/qemu_sh4eb_r2d_defconfig     | 5 ++---
 configs/qemu_sparc64_sun4u_defconfig | 2 +-
 configs/qemu_sparc_ss10_defconfig    | 4 +---
 configs/qemu_x86_64_defconfig        | 5 ++---
 configs/qemu_x86_defconfig           | 5 ++---
 configs/qemu_xtensa_lx60_defconfig   | 1 +
 15 files changed, 17 insertions(+), 28 deletions(-)
configs/qemu_arm_nuri_defconfig +0 -2
index d2e522f..0854ae0 100644
@@ -5,8 +5,6 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_FPU_VFPV3D16=y
 
 # System
-BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
-BR2_TARGET_GENERIC_GETTY=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttySAC1"
 
 # Filesystem
configs/qemu_arm_versatile_defconfig +2 -3
index 1ce55d0..7d5888a 100644
@@ -2,11 +2,10 @@
 BR2_arm=y
 BR2_arm926t=y
 
-# system
-BR2_TARGET_GENERIC_GETTY=y
+# System
 BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_arm_vexpress_defconfig +0 -2
index b036c6b..ec9e2fb 100644
@@ -5,8 +5,6 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_FPU_VFPV3D16=y
 
 # System
-BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
-BR2_TARGET_GENERIC_GETTY=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
configs/qemu_mips_malta_defconfig +1 -1
index e6f6a95..3100d52 100644
@@ -2,7 +2,7 @@
 BR2_mips=y
 BR2_mips_32r2=y
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_mipsel_malta_defconfig +1 -1
index b14e70c..dad1db0 100644
@@ -2,7 +2,7 @@
 BR2_mipsel=y
 BR2_mips_32r2=y
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_ppc64_pseries_defconfig +0 -1
index 97e53b4..5f7a013 100644
@@ -3,7 +3,6 @@ BR2_powerpc64=y
 BR2_powerpc_power7=y
 
 # System
-BR2_TARGET_GENERIC_GETTY=y
 BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
 
 # Filesystem
configs/qemu_ppc_g3beige_defconfig +1 -1
index ae2ddcc..fb6c52a 100644
@@ -2,7 +2,7 @@
 BR2_powerpc=y
 BR2_powerpc_750=y
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_ppc_mpc8544ds_defconfig +1 -1
index 198f5cd..b022139 100644
@@ -2,7 +2,7 @@
 BR2_powerpc=y
 BR2_powerpc_8548=y
 
-# filesystem
+# Filesystem
 # BR2_TARGET_ROOTFS_TAR is not set
 BR2_TARGET_ROOTFS_INITRAMFS=y
 
configs/qemu_sh4_r2d_defconfig +2 -3
index 0666ed4..4366ab1 100644
@@ -2,11 +2,10 @@
 BR2_sh=y
 BR2_sh4=y
 
-# system
-BR2_TARGET_GENERIC_GETTY=y
+# System
 BR2_TARGET_GENERIC_GETTY_PORT="ttySC1"
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_sh4eb_r2d_defconfig +2 -3
index 6680ee3..1417699 100644
@@ -2,11 +2,10 @@
 BR2_sh=y
 BR2_sh4eb=y
 
-# system
-BR2_TARGET_GENERIC_GETTY=y
+# System
 BR2_TARGET_GENERIC_GETTY_PORT="ttySC1"
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_sparc64_sun4u_defconfig +1 -1
index 828b437..8b47526 100644
@@ -2,7 +2,7 @@
 BR2_sparc64=y
 BR2_sparc_v9=y
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_sparc_ss10_defconfig +1 -3
index 3e6d7b1..cb0eb8f 100644
@@ -2,9 +2,7 @@
 BR2_sparc=y
 BR2_sparc_v8=y
 
-BR2_GLOBAL_PATCH_DIR="board/qemu/sparc-ss10"
-
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_x86_64_defconfig +2 -3
index daf32cd..d350926 100644
@@ -1,11 +1,10 @@
 # Architecture
 BR2_x86_64=y
 
-# system
-BR2_TARGET_GENERIC_GETTY=y
+# System
 BR2_TARGET_GENERIC_GETTY_PORT="tty1"
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_x86_defconfig +2 -3
index 9fd1fe9..3517b66 100644
@@ -2,11 +2,10 @@
 BR2_i386=y
 BR2_x86_pentiumpro=y
 
-# system
-BR2_TARGET_GENERIC_GETTY=y
+# System
 BR2_TARGET_GENERIC_GETTY_PORT="tty1"
 
-# filesystem
+# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
 
configs/qemu_xtensa_lx60_defconfig +1 -0
index 526a111..8a42106 100644
@@ -5,6 +5,7 @@ BR2_XTENSA_CUSTOM_NAME="dc232b"
 BR2_XTENSA_CORE_NAME="lx60"
 BR2_XTENSA_OVERLAY_DIR="board/qemu/xtensa-lx60"
 
+# Patches
 BR2_GLOBAL_PATCH_DIR="board/qemu/xtensa-lx60"
 
 # System
Signature · 1 line
2.4.10
#1 lore raw

PATCH 2/2 configs/qemu: enable dhcp on network interfaces

Enable dhcp networking for qemu configs considered good enough for testing purposes.

This excludes:
arm_nuri - emulation doesn't seem 100% correct for networking. ppc_virtex_ml507 - doesn't emulate networking.
sh4eb - emulation doesn't seem 100% correct for the NIC.

---
 configs/qemu_aarch64_virt_defconfig     | 1 +
 configs/qemu_arm_versatile_defconfig    | 1 +
 configs/qemu_arm_vexpress_defconfig     | 1 +
 configs/qemu_microblazebe_mmu_defconfig | 1 +
 configs/qemu_microblazeel_mmu_defconfig | 1 +
 configs/qemu_mips64_malta_defconfig     | 3 +++
 configs/qemu_mips64el_malta_defconfig   | 3 +++
 configs/qemu_mips_malta_defconfig       | 3 +++
 configs/qemu_mipsel_malta_defconfig     | 3 +++
 configs/qemu_ppc64_pseries_defconfig    | 1 +
 configs/qemu_ppc_g3beige_defconfig      | 3 +++
 configs/qemu_ppc_mpc8544ds_defconfig    | 3 +++
 configs/qemu_sh4_r2d_defconfig          | 1 +
 configs/qemu_sparc64_sun4u_defconfig    | 3 +++
 configs/qemu_sparc_ss10_defconfig       | 3 +++
 configs/qemu_x86_64_defconfig           | 1 +
 configs/qemu_x86_defconfig              | 1 +
 configs/qemu_xtensa_lx60_defconfig      | 1 +
 18 files changed, 34 insertions(+)
configs/qemu_aarch64_virt_defconfig +1 -0
index c39fd81..a695afb 100644
@@ -2,6 +2,7 @@
 BR2_aarch64=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
configs/qemu_arm_versatile_defconfig +1 -0
index 7d5888a..1ac59fd 100644
@@ -3,6 +3,7 @@ BR2_arm=y
 BR2_arm926t=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
configs/qemu_arm_vexpress_defconfig +1 -0
index ec9e2fb..5f1a997 100644
@@ -5,6 +5,7 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_FPU_VFPV3D16=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
configs/qemu_microblazebe_mmu_defconfig +1 -0
index 5730e4c..e8fcaec 100644
@@ -3,6 +3,7 @@ BR2_microblaze=y
 BR2_microblazebe=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttyUL0"
 
 # Filesystem
configs/qemu_microblazeel_mmu_defconfig +1 -0
index 8f95c82..01a423b 100644
@@ -3,6 +3,7 @@ BR2_microblaze=y
 BR2_microblazeel=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttyUL0"
 
 # Filesystem
configs/qemu_mips64_malta_defconfig +3 -0
index 94dfb54..736ca70 100644
@@ -2,6 +2,9 @@
 BR2_mips64=y
 BR2_MIPS_NABI64=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_mips64el_malta_defconfig +3 -0
index 88828fe..4c29ed5 100644
@@ -2,6 +2,9 @@
 BR2_mips64el=y
 BR2_MIPS_NABI64=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_mips_malta_defconfig +3 -0
index 3100d52..4913490 100644
@@ -2,6 +2,9 @@
 BR2_mips=y
 BR2_mips_32r2=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_mipsel_malta_defconfig +3 -0
index dad1db0..f3f513b 100644
@@ -2,6 +2,9 @@
 BR2_mipsel=y
 BR2_mips_32r2=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_ppc64_pseries_defconfig +1 -0
index 5f7a013..08d6cbb 100644
@@ -3,6 +3,7 @@ BR2_powerpc64=y
 BR2_powerpc_power7=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
 
 # Filesystem
configs/qemu_ppc_g3beige_defconfig +3 -0
index fb6c52a..a344f53 100644
@@ -2,6 +2,9 @@
 BR2_powerpc=y
 BR2_powerpc_750=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_ppc_mpc8544ds_defconfig +3 -0
index b022139..f89fcca 100644
@@ -2,6 +2,9 @@
 BR2_powerpc=y
 BR2_powerpc_8548=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 # BR2_TARGET_ROOTFS_TAR is not set
 BR2_TARGET_ROOTFS_INITRAMFS=y
configs/qemu_sh4_r2d_defconfig +1 -0
index 4366ab1..8197738 100644
@@ -3,6 +3,7 @@ BR2_sh=y
 BR2_sh4=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttySC1"
 
 # Filesystem
configs/qemu_sparc64_sun4u_defconfig +3 -0
index 8b47526..00ceb89 100644
@@ -2,6 +2,9 @@
 BR2_sparc64=y
 BR2_sparc_v9=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_sparc_ss10_defconfig +3 -0
index cb0eb8f..6bb1c81 100644
@@ -2,6 +2,9 @@
 BR2_sparc=y
 BR2_sparc_v8=y
 
+# System
+BR2_SYSTEM_DHCP="eth0"
+
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
configs/qemu_x86_64_defconfig +1 -0
index d350926..22983bf 100644
@@ -2,6 +2,7 @@
 BR2_x86_64=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="tty1"
 
 # Filesystem
configs/qemu_x86_defconfig +1 -0
index 3517b66..0e1316d 100644
@@ -3,6 +3,7 @@ BR2_i386=y
 BR2_x86_pentiumpro=y
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="tty1"
 
 # Filesystem
configs/qemu_xtensa_lx60_defconfig +1 -0
index 8a42106..42b844c 100644
@@ -9,6 +9,7 @@ BR2_XTENSA_OVERLAY_DIR="board/qemu/xtensa-lx60"
 BR2_GLOBAL_PATCH_DIR="board/qemu/xtensa-lx60"
 
 # System
+BR2_SYSTEM_DHCP="eth0"
 BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
 
 # Filesystem
Signature · 1 line
2.4.10
#2 lore raw

PATCH 2/2 configs/qemu: enable dhcp on network interfaces

Dear Gustavo Zacarias,

Quoted 21 lines · Gustavo Zacarias

Enable dhcp networking for qemu configs considered good enough for testing purposes.

This excludes:
arm_nuri - emulation doesn't seem 100% correct for networking. ppc_virtex_ml507 - doesn't emulate networking.
sh4eb - emulation doesn't seem 100% correct for the NIC.

---
 configs/qemu_aarch64_virt_defconfig     | 1 +
 configs/qemu_arm_versatile_defconfig    | 1 +
 configs/qemu_arm_vexpress_defconfig     | 1 +
 configs/qemu_microblazebe_mmu_defconfig | 1 +
 configs/qemu_microblazeel_mmu_defconfig | 1 +
 configs/qemu_mips64_malta_defconfig     | 3 +++
 configs/qemu_mips64el_malta_defconfig   | 3 +++
 configs/qemu_mips_malta_defconfig       | 3 +++
 configs/qemu_mipsel_malta_defconfig     | 3 +++
 configs/qemu_ppc64_pseries_defconfig    | 1 +
 configs/qemu_ppc_g3beige_defconfig      | 3 +++
Quoted 8 lines
 configs/qemu_ppc_mpc8544ds_defconfig    | 3 +++
 configs/qemu_sh4_r2d_defconfig          | 1 +
 configs/qemu_sparc64_sun4u_defconfig    | 3 +++
 configs/qemu_sparc_ss10_defconfig       | 3 +++
 configs/qemu_x86_64_defconfig           | 1 +
 configs/qemu_x86_defconfig              | 1 +
 configs/qemu_xtensa_lx60_defconfig      | 1 +
 18 files changed, 34 insertions(+)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/2 configs/qemu: cleanup and capitalization

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 14 lines · Gustavo Zacarias

Capitalize comments in a consistent way.
Cleanup redundant entries.
Drop global patch dir for sparc ss10 since it's not required any more.

---
 configs/qemu_arm_nuri_defconfig      | 2 --
 configs/qemu_arm_versatile_defconfig | 5 ++---
 configs/qemu_arm_vexpress_defconfig  | 2 --
 configs/qemu_mips_malta_defconfig    | 2 +-
 configs/qemu_mipsel_malta_defconfig  | 2 +-
 configs/qemu_ppc64_pseries_defconfig | 1 -
 configs/qemu_ppc_g3beige_defconfig   | 2 +-
 configs/qemu_ppc_mpc8544ds_defconfig | 2 +-
Quoted 8 lines
 configs/qemu_sh4_r2d_defconfig       | 5 ++---
 configs/qemu_sh4eb_r2d_defconfig     | 5 ++---
 configs/qemu_sparc64_sun4u_defconfig | 2 +-
 configs/qemu_sparc_ss10_defconfig    | 4 +---
 configs/qemu_x86_64_defconfig        | 5 ++---
 configs/qemu_x86_defconfig           | 5 ++---
 configs/qemu_xtensa_lx60_defconfig   | 1 +
 15 files changed, 17 insertions(+), 28 deletions(-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/2 configs/qemu: cleanup and capitalization

In reply to Gustavo Zacarias
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Capitalize comments in a consistent way.
Cleanup redundant entries.
Drop global patch dir for sparc ss10 since it's not required any more.

These are not strictly bugfixes, but they seem quite safe and having them on master will make it easier to merge next - So committed both, thanks!

Signature · 1 line
Bye, Peter Korsgaard