scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
PATCH 1/1 scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
The hpsa driver recently started using the sas transport class, but it does not ensure that the corresponding code is actually built, which may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference to sas_port_delete_phy' (.text+0x1ce87c): undefined reference to sas_phy_free' drivers/built-in.o: In function `hpsa_alloc_sas_port':
(.text+0x1ceb9c): undefined reference to sas_port_alloc_num' (.text+0x1ceba8): undefined reference to sas_port_add' drivers/built-in.o: In function `hpsa_init':
(.init.text+0x8838): undefined reference to sas_attach_transport' (.init.text+0x8868): undefined reference to sas_release_transport
This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do for all other drivers using those functions.
---
This showed up on the ARM randconfig builds today for the first time.
drivers/scsi/Kconfig +1 -0
@@ -364,6 +364,7 @@ config SCSI_HPSA tristate "HP Smart Array SCSI driver" depends on PCI && SCSI select CHECK_SIGNATURE + select SCSI_SAS_ATTRS help This driver supports HP Smart Array Controllers (circa 2009). It is a SCSI alternative to the cciss driver, which is a block
Looks good,
And...Thanks!
Quoted 39 lines · Arnd Bergmann
The hpsa driver recently started using the sas transport class, but it does not ensure that the corresponding code is actually built, which may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference tosas_port_delete_phy' (.text+0x1ce87c): undefined reference tosas_phy_free'drivers/built-in.o: In function `hpsa_alloc_sas_port':
(.text+0x1ceb9c): undefined reference tosas_port_alloc_num' (.text+0x1ceba8): undefined reference tosas_port_add'drivers/built-in.o: In function `hpsa_init':
(.init.text+0x8838): undefined reference tosas_attach_transport' (.init.text+0x8868): undefined reference tosas_release_transportThis adds 'select
SCSI_SAS_ATTR' in theKconfigentry, just like we do for all other drivers using those functions.Signed-off-by Arnd Bergmann <[email protected]>Fixes d04e62b9d63a ("hpsa: add in sas transport class")---
This showed up on the ARM randconfig builds today for the first time.drivers/scsi/Kconfig +1
-1@@ -364,6 +364,7 @@ config SCSI_HPSA tristate "HP Smart Array SCSI driver" depends on PCI && SCSI select CHECK_SIGNATURE + select SCSI_SAS_ATTRS help This driver supports HP Smart Array Controllers (circa 2009). It is a SCSI alternative to the cciss driver, which is a block --To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
James Bottomley
maintainerQuoted 1 line · Don Brace
Signed-off-by Don Brace <[email protected]>
You mean acked-by ... it can only be signed-off-by if *you* resend the patch because signoffs track the patch transmission path.
James
Quoted 49 lines
And...Thanks!
Quoted 36 lines · Arnd Bergmann
The hpsa driver recently started using the sas transport class, but it does not ensure that the corresponding code is actually built, which may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference tosas_port_delete_phy' (.text+0x1ce87c): undefined reference tosas_phy_free'drivers/built-in.o: In function `hpsa_alloc_sas_port':
(.text+0x1ceb9c): undefined reference tosas_port_alloc_num' (.text+0x1ceba8): undefined reference tosas_port_add'drivers/built-in.o: In function `hpsa_init':
(.init.text+0x8838): undefined reference tosas_attach_transport' (.init.text+0x8868): undefined reference tosas_release_transportThis adds 'select
SCSI_SAS_ATTR' in theKconfigentry, just like we do for all other drivers using those functions.Signed-off-by Arnd Bergmann <[email protected]>Fixes d04e62b9d63a ("hpsa: add in sas transport class")---
This showed up on the ARM randconfig builds today for the first time.drivers/scsi/Kconfig +1
-1@@ -364,6 +364,7 @@ config SCSI_HPSA tristate "HP Smart Array SCSI driver" depends on PCI && SCSI select CHECK_SIGNATURE + select SCSI_SAS_ATTRS help This driver supports HP Smart Array Controllers (circa 2009). It is a SCSI alternative to the cciss driver, which is a block --Quoted 3 lines
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Martin K. Petersen
AppliedQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnd" == Arnd Bergmann <[email protected]> writes:
Arnd> The hpsa driver recently started using the sas transport class, Arnd> but it does not ensure that the corresponding code is actually Arnd> built, which may lead to a link error:
Applied.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering