ARM: shmobile: alt: Add pfc pins to DT

PATCH New Simon Horman 4 participants 7 messages Nov 17, 2015 – Nov 21, 2015

Subsystems (2)

Device tree bindings SuperH

lore

Share & tools

lore

Simon Horman

author

2015-11-17 19:10 UTC #0 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.

Based on work by Mitsuhiro Kimura and Hisashi Nakamura.

Cc Mitsuhiro Kimura <[email protected]>

Cc Hisashi Nakamura <[email protected]>

Signed-off-by Simon Horman <[email protected]>

---
Tested

---
 arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

arch/arm/boot/dts/r8a7794-alt.dts +17 -0

index 928cfa641475..2e889991ce8f 100644
@@ -39,6 +39,23 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif2_pins: serial2 {
+		renesas,groups = "scif2_data";
+		renesas,function = "scif2";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	ether_b_pins: ether {
+		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
+		renesas,function = "eth";
+	};
+};
+
 &cmt0 {
 	status = "okay";
 };

Signature · 1 line

2.1.4

Ulrich Hecht

2015-11-18 13:04 UTC #1 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

Quoted 9 lines · Simon Horman

PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
Cc Mitsuhiro Kimura <[email protected]>
Cc Hisashi Nakamura <[email protected]>
Signed-off-by Simon Horman <[email protected]>

Looks good.

Acked-by Ulrich Hecht <[email protected]>

CU
Uli

Simon Horman

2015-11-18 20:52 UTC #2 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

Quoted 8 lines · Ulrich Hecht

Quoted 6 lines · Simon Horman
PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.

Quoted 7 lines

Quoted 3 lines
Cc Mitsuhiro Kimura <[email protected]>
Cc Hisashi Nakamura <[email protected]>
Signed-off-by Simon Horman <[email protected]>
Looks good.
Acked-by Ulrich Hecht <[email protected]>

Thanks for reviewing this.
I have queued it up.

Sergei Shtylyov

2015-11-20 12:11 UTC #3 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

In reply to Simon Horman

Hello.

Quoted 34 lines · Simon Horman

PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
Cc Mitsuhiro Kimura <[email protected]>
Cc Hisashi Nakamura <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
Tested
---
  arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +10 -0
index 928cfa641475..2e889991ce8f 100644
@@ -39,6 +39,23 @@
  	clock-frequency = <20000000>;
  };
 
+&pfc {
+	scif2_pins: serial2 {
+		renesas,groups = "scif2_data";
+		renesas,function = "scif2";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};

arch/arm/boot/dts/r8a7794-alt.dts line 61

Quoted 10 lines

arch/arm/boot/dts/r8a7794-alt.dts +7 -0

+
+	ether_b_pins: ether {
+		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
+		renesas,function = "eth";
+	};
+};
+
  &cmt0 {
  	status = "okay";
  };

Why add unreferenced pins? How have you tested this?

MBR, Sergei

Simon Horman

2015-11-20 18:34 UTC #4 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

Quoted 42 lines · Sergei Shtylyov

Hello.
Quoted 38 lines · Simon Horman
PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
Cc Mitsuhiro Kimura <[email protected]>
Cc Hisashi Nakamura <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
Tested
---
 arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +14 -0
index 928cfa641475..2e889991ce8f 100644
@@ -39,6 +39,23 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif2_pins: serial2 {
+		renesas,groups = "scif2_data";
+		renesas,function = "scif2";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	ether_b_pins: ether {
+		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
+		renesas,function = "eth";

Quoted 8 lines

arch/arm/boot/dts/r8a7794-alt.dts line 61
Quoted 6 lines
arch/arm/boot/dts/r8a7794-alt.dts +3 -0
+	};
+};
+
 &cmt0 {
 	status = "okay";
 };
Why add unreferenced pins? How have you tested this?

Thanks for pointing out that oversight. I'll see about filling in the gaps.

Sergei Shtylyov

2015-11-20 18:50 UTC #5 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

Quoted 47 lines · Simon Horman

Quoted 38 lines
Quoted 38 lines
PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
Cc Mitsuhiro Kimura <[email protected]>
Cc Hisashi Nakamura <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
Tested
---
  arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +14 -0
index 928cfa641475..2e889991ce8f 100644
@@ -39,6 +39,23 @@
  	clock-frequency = <20000000>;
  };
 
+&pfc {
+	scif2_pins: serial2 {
+		renesas,groups = "scif2_data";
+		renesas,function = "scif2";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	ether_b_pins: ether {
+		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
+		renesas,function = "eth";
Quoted 8 lines
arch/arm/boot/dts/r8a7794-alt.dts line 61
Quoted 6 lines
arch/arm/boot/dts/r8a7794-alt.dts +3 -0
+	};
+};
+
  &cmt0 {
  	status = "okay";
  };
Why add unreferenced pins? How have you tested this?

Quoted 1 line

Thanks for pointing out that oversight. I'll see about filling in the gaps.

Sorry for noticing this too late, only when you were pushing your branches
upstream...

MBR, Sergei

Simon Horman

2015-11-21 00:40 UTC #6 lore raw

PATCH 1/1 ARM: shmobile: alt: Add pfc pins to DT

Quoted 49 lines · Sergei Shtylyov

Quoted 47 lines · Simon Horman
Quoted 46 lines
Quoted 34 lines
PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
Cc Mitsuhiro Kimura <[email protected]>
Cc Hisashi Nakamura <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
Tested
---
 arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +10 -0
index 928cfa641475..2e889991ce8f 100644
@@ -39,6 +39,23 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif2_pins: serial2 {
+		renesas,groups = "scif2_data";
+		renesas,function = "scif2";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
arch/arm/boot/dts/r8a7794-alt.dts line 61
Quoted 10 lines
arch/arm/boot/dts/r8a7794-alt.dts +7 -0
+
+	ether_b_pins: ether {
+		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
+		renesas,function = "eth";
+	};
+};
+
 &cmt0 {
 	status = "okay";
 };
Why add unreferenced pins? How have you tested this?

Quoted 4 lines

Quoted 1 line
Thanks for pointing out that oversight. I'll see about filling in the gaps.
Sorry for noticing this too late, only when you were pushing your
branches upstream...

No problem, thanks for noticing at all.

FYI:

It looks like things work well when using the scif2
but not the ether pins. I suspect the latter is due to the lack of phy pin support both above and by inspection in the pfc driver.

I will investigate further.