Skip to contentSkip to conversation

iwlwifi: mvm: rs: fix a warning message

PATCH In review Dan Carpenter 2 participants 2 messages Nov 21, 2015

Subsystems (2)
Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 iwlwifi: mvm: rs: fix a warning message

WARN_ON_ONCE() doesn't take a message, it only takes a condition. I have changed this to WARN(1, ...).

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/iwlwifi/mvm/rs.c +1 -1
index d1ad103..58d7bee 100644
@@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm *mvm,
 		rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : LQ_HT_MIMO2;
 		rate_mask = lq_sta->active_mimo2_rate;
 	} else {
-		WARN_ON_ONCE("Bad column mode");
+		WARN_ONCE(1, "Bad column mode");
 	}
 
 	if (column->mode != RS_LEGACY) {
#1 lore raw
Quoted 11 lines · Dan Carpenter

WARN_ON_ONCE() doesn't take a message, it only takes a condition. I have changed this to WARN(1, ...).

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/iwlwifi/mvm/rs.c +0 -0
index d1ad103..58d7bee 100644

drivers/net/wireless/iwlwifi/mvm/rs.c static int rs_switch_to_column(struct iwl_mvm *mvm, · line 1833

Quoted 8 lines
drivers/net/wireless/iwlwifi/mvm/rs.c +1 -1
@@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm *mvm,
 		rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : LQ_HT_MIMO2;
 		rate_mask = lq_sta->active_mimo2_rate;
 	} else {
-		WARN_ON_ONCE("Bad column mode");
+		WARN_ONCE(1, "Bad column mode");
 	}
 
 	if (column->mode != RS_LEGACY) {

Ouch - thanks. Clearly, this one doesn't trigger very often :)