Bluetooth: Add instance range check for Add Advertising command
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/3 Bluetooth: Add instance range check for Add Advertising command
The instance range check for Add Advertising command is missing. If the provided instance is out of range an Invalid Parameters error should be returned. At the moment, the generic Failed error is returned. This extra check ensures that clear error messages are returned.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/mgmt.c | 4 ++++ 1 file changed, 4 insertions(+)
net/bluetooth/mgmt.c +4 -0
@@ -6839,6 +6839,10 @@ static int add_advertising(struct sock *sk, struct hci_dev *hdev,return mgmt_cmd_status (sk, hdev->id,MGMT_OP_ADD_ADVERTISING , status); +if (cp->instance <1 || cp->instance >HCI_MAX_ADV_INSTANCES ) +return mgmt_cmd_status (sk, hdev->id,MGMT_OP_ADD_ADVERTISING , +MGMT_STATUS_INVALID_PARAMS ); + flags =__le32_to_cpu (cp->flags); timeout =__le16_to_cpu (cp->timeout); duration =__le16_to_cpu (cp->duration);
Signature · 1 line
2.5.0
Hi Marcel,
Quoted 9 lines · Marcel Holtmann
The instance range check for Add Advertising command is missing. If the provided instance is out of range an Invalid Parameters error should be returned. At the moment, the generic Failed error is returned. This extra check ensures that clear error messages are returned.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/mgmt.c | 4 ++++ 1 file changed, 4 insertions(+)
Patches 1 and 2 have been applied. Thanks.
Johan