Skip to contentSkip to conversation

package/mpd: fix static build issue with alsa

PATCH New Jörg Krause 2 participants 2 messages Nov 21, 2015 – Nov 22, 2015

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 package/mpd: fix static build issue with alsa

mpd forgets to link the archive libmixer_plugins.a against libasound leading to undefined references in a static context.

Add a patch sent upstream to fix:
http://autobuild.buildroot.net/results/f10/f10c6ea2d29bbcef8f33fc9ba1430e99edca895d/
http://autobuild.buildroot.net/results/312/31212c484f452fe4ea6ae084d3edefc4580830d8/

Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/0003-fix-static-build-with-alsa.patch | 32 +++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/mpd/0003-fix-static-build-with-alsa.patch
package/mpd/0003-fix-static-build-with-alsa.patch new file +32 -0
new file mode 100644
index 0000000..4ba0449
@@ -0,0 +1,32 @@
+From bba7b8e5fed79a7fecacf5468ade35a3ae0a0f8e Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=B6rg=20Krause?= <[email protected]>
+Date: Sat, 21 Nov 2015 23:51:43 +0100
+Subject: [PATCH 1/1] Makefile.am: fix static build with alsa
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Add ALSA_LIBS to MIXER_LIBS, otherwise building mpd in a static context fails
+with lot of undefined references to alsa-lib (libasound) required by
+src/mixer/plugins/AlsaMixerPlugin.cxx.
+
+Signed-off-by: J?rg Krause <[email protected]>
+---
+ Makefile.am | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/Makefile.am b/Makefile.am
+index 89819de..307fcba 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1219,6 +1219,7 @@ liboutput_plugins_a_SOURCES = \
+ 
+ MIXER_LIBS = \
+ 	libmixer_plugins.a \
++	$(ALSA_LIBS) \
+ 	$(PULSE_LIBS)
+ 
+ MIXER_API_SRC = \
+-- 
+2.6.2
+
Signature · 1 line
2.6.2
Applied
#1 lore raw

PATCH 1/1 package/mpd: fix static build issue with alsa

Dear J?rg Krause,

Quoted 7 lines · J?rg Krause

mpd forgets to link the archive libmixer_plugins.a against libasound leading to undefined references in a static context.

Add a patch sent upstream to fix:
http://autobuild.buildroot.net/results/f10/f10c6ea2d29bbcef8f33fc9ba1430e99edca895d/
http://autobuild.buildroot.net/results/312/31212c484f452fe4ea6ae084d3edefc4580830d8/

Quoted 5 lines
Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/0003-fix-static-build-with-alsa.patch | 32 +++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/mpd/0003-fix-static-build-with-alsa.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com