Skip to contentSkip to conversation

scsi: lpfc: Use kzalloc instead of kmalloc

PATCH In review Punit Vara 4 participants 4 messages Oct 24, 2015 – Dec 16, 2015

Subsystems (2)
SCSI Emulex/Broadcom lpfc FC/FCoE SCSI driver
lore
Share & tools
lore

Punit Vara

author
#0 lore raw

PATCH v2 1/2 scsi: lpfc: Use kzalloc instead of kmalloc

This patch is to the lpfc_els.c which resolves following warning reported by coccicheck:

WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset

Signed-off-by Punit Vara <[email protected]>
---
 drivers/scsi/lpfc/lpfc_els.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +1 -2
index 36bf58b..9729ab1 100644
@@ -4990,13 +4990,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
 	if (RDP_NPORT_ID_SIZE !=
 			be32_to_cpu(rdp_req->nport_id_desc.length))
 		goto rjt_logerr;
-	rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+	rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
 	if (!rdp_context) {
 		rjt_err = LSRJT_UNABLE_TPC;
 		goto error;
 	}
 
-	memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
 	cmd = &cmdiocb->iocb;
 	rdp_context->ndlp = lpfc_nlp_get(ndlp);
 	rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
Signature · 1 line
2.5.3
#2 lore raw

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17

-- james s

Quoted 15 lines · Matthew R. Ochs
Quoted 9 lines · Punit Vara

This patch is to the lpfc_els.c which resolves following warning reported by coccicheck:

WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset

Signed-off-by Punit Vara <[email protected]>
Reviewed-by Matthew R. Ochs <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviewed-by on v2 1/2
#3 lore raw
In reply to Punit Vara
Quoted 20 lines · Punit Vara

This patch is to the lpfc_els.c which resolves following warning reported by coccicheck:

WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset

Signed-off-by Punit Vara <[email protected]>
---
 drivers/scsi/lpfc/lpfc_els.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +0 -1
index 36bf58b..9729ab1 100644
@@ -4990,13 +4990,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
 	if (RDP_NPORT_ID_SIZE !=
 			be32_to_cpu(rdp_req->nport_id_desc.length))
 		goto rjt_logerr;
-	rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);

drivers/scsi/lpfc/lpfc_els.c lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, · line 5001

Quoted 10 lines
drivers/scsi/lpfc/lpfc_els.c +1 -1
+	rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
 	if (!rdp_context) {
 		rjt_err = LSRJT_UNABLE_TPC;
 		goto error;
 	}
 
-	memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
 	cmd = &cmdiocb->iocb;
 	rdp_context->ndlp = lpfc_nlp_get(ndlp);
 	rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
Reviewed-by Sebastian Herbszt <[email protected]>