Skip to contentSkip to conversation

OMAPDSS: DSI: cleanup DSI_IRQ_ERROR_MASK define

PATCH In review Dan Carpenter 2 participants 2 messages Nov 23, 2015 – Nov 24, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAPDSS: DSI: cleanup DSI_IRQ_ERROR_MASK define

DSI_IRQ_SYNC_LOST was ORed twice so we can remove one.

drivers/video/fbdev/omap2/dss/dsi.c +1 -1
index b3606de..e86df6d 100644
@@ -144,7 +144,7 @@ struct dsi_reg { u16 module; u16 idx; };
 #define DSI_IRQ_TA_TIMEOUT	(1 << 20)
 #define DSI_IRQ_ERROR_MASK \
 	(DSI_IRQ_HS_TX_TIMEOUT | DSI_IRQ_LP_RX_TIMEOUT | DSI_IRQ_SYNC_LOST | \
-	DSI_IRQ_TA_TIMEOUT | DSI_IRQ_SYNC_LOST)
+	DSI_IRQ_TA_TIMEOUT)
 #define DSI_IRQ_CHANNEL_MASK	0xf
 
 /* Virtual channel interrupts */
#1 lore raw
Quoted 10 lines · Dan Carpenter

DSI_IRQ_SYNC_LOST was ORed twice so we can remove one.

drivers/video/fbdev/omap2/dss/dsi.c +0 -0
index b3606de..e86df6d 100644

drivers/video/fbdev/omap2/dss/dsi.c struct dsi_reg { u16 module; u16 idx; }; · line 150

Quoted 8 lines
drivers/video/fbdev/omap2/dss/dsi.c +1 -1
@@ -144,7 +144,7 @@ struct dsi_reg { u16 module; u16 idx; };
 #define DSI_IRQ_TA_TIMEOUT	(1 << 20)
 #define DSI_IRQ_ERROR_MASK \
 	(DSI_IRQ_HS_TX_TIMEOUT | DSI_IRQ_LP_RX_TIMEOUT | DSI_IRQ_SYNC_LOST | \
-	DSI_IRQ_TA_TIMEOUT | DSI_IRQ_SYNC_LOST)
+	DSI_IRQ_TA_TIMEOUT)
 #define DSI_IRQ_CHANNEL_MASK	0xf
 
 /* Virtual channel interrupts */

Thanks, queued for 4.5.

Tomi