nvmem: qfprom: Specify LE device endianness
Subsystems (2)
PATCH 1/1 nvmem: qfprom: Specify LE device endianness
The qfprom is a little endian device, but so far we've been relying on the regmap mmio bus handling this for us without explicitly stating that fact. After commit 4a98da2164cf (regmap-mmio: Use native endianness for read/write, 2015-10-29), the regmap mmio bus will read/write with the __raw_*() IO accessors, instead of using the readl/writel() APIs that do proper byte swapping for little endian devices.
So if we're running on a big endian processor and haven't specified the endianness explicitly in the regmap config or in DT, we're going to switch from doing little endian byte swapping to big endian accesses without byte swapping, leading to some confusing results. Specify the endianness explicitly so that the regmap core properly byte swaps the accesses for us.
--- drivers/nvmem/qfprom.c | 1 + 1 file changed, 1 insertion(+)
drivers/nvmem/qfprom.c +1 -0
@@ -21,6 +21,7 @@ static struct regmap_config qfprom_regmap_config = { .reg_bits = 32, .val_bits = 8, .reg_stride = 1, + .val_format_endian = REGMAP_ENDIAN_LITTLE, };static struct nvmem_config econfig = {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Hi Stephen,
Thanks for the fix.
I will send it to Greg for next rc.
--srini
Quoted 38 lines · Stephen Boyd
The qfprom is a little endian device, but so far we've been relying on the regmap mmio bus handling this for us without explicitly stating that fact. After commit
4a98da2164cf(regmap-mmio: Use native endianness for read/write, 2015-10-29), the regmap mmio bus will read/write with the __raw_*() IO accessors, instead of using the readl/writel() APIs that do proper byte swapping for little endian devices.So if we're running on a big endian processor and haven't specified the endianness explicitly in the regmap config or in DT, we're going to switch from doing little endian byte swapping to big endian accesses without byte swapping, leading to some confusing results. Specify the endianness explicitly so that the regmap core properly byte swaps the accesses for us.
Cc Rajendra Nayak <[email protected]>Cc Kevin Hilman <[email protected]>Cc Tyler Baker <[email protected]>Cc Simon Arlott <[email protected]>Cc Mark Brown <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/nvmem/qfprom.c | 1 + 1 file changed, 1 insertion(+)drivers/nvmem/qfprom.c +1
-0@@ -21,6 +21,7 @@ static struct regmap_config qfprom_regmap_config = { .reg_bits = 32, .val_bits = 8, .reg_stride = 1, + .val_format_endian = REGMAP_ENDIAN_LITTLE, };static struct nvmem_config econfig = {
Quoted 5 lines · Srinivas Kandagatla
Hi Stephen,
Thanks for the fix.
I will send it to Greg for next rc.
Thanks. The change in regmap core that causes the problem is only in -next. I'm not sure if it's going to hit mainline this release cycle, so if it doesn't you could queue this for the next version. No rush.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project