Skip to contentSkip to conversation

ARM: imx_v6_v7_defconfig: Select HDMI audio support

PATCH New Fabio Estevam 3 participants 4 messages Nov 16, 2015 – Nov 24, 2015

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v2 1/1 ARM: imx_v6_v7_defconfig: Select HDMI audio support

Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio supported by default.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Select the driver as module instead of built-in

 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
index 4187f69..f5ca938 100644
@@ -224,6 +224,7 @@ CONFIG_SOC_CAMERA_OV2640=y
 CONFIG_IMX_IPUV3_CORE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_IMX=y
 CONFIG_DRM_IMX_FB_HELPER=y
 CONFIG_DRM_IMX_PARALLEL_DISPLAY=y
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 ARM: imx_v6_v7_defconfig: Select HDMI audio support

Quoted 7 lines · Fabio Estevam

Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio supported by default.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Select the driver as module instead of built-in

I've applied a previous version. Should I replace it with this one?

Shawn

Quoted 25 lines
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
index 4187f69..f5ca938 100644
@@ -224,6 +224,7 @@ CONFIG_SOC_CAMERA_OV2640=y
 CONFIG_IMX_IPUV3_CORE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_IMX=y
 CONFIG_DRM_IMX_FB_HELPER=y
 CONFIG_DRM_IMX_PARALLEL_DISPLAY=y
Signature · 7 lines
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer
#2 lore raw

PATCH v2 1/1 ARM: imx_v6_v7_defconfig: Select HDMI audio support

Quoted 10 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio supported by default.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Select the driver as module instead of built-in

I've applied a previous version. Should I replace it with this one?

Yes, please.

The latest version uses module instead of built-in.

Selecting the driver as module is better as it will not impact current users. For example: currently on a mx6qsabresd when we do 'aplay file.wav' it will play through the wm8962 card.

If the HDMI audio driver is selected as built-in, then 'aplay file.wav' will play through the HDMI audio port, which may confuse the end user.

If we select the HDMI audio driver as module then we keep the original behaviour.

Thanks

#3 lore raw

PATCH v2 1/1 ARM: imx_v6_v7_defconfig: Select HDMI audio support

Quoted 5 lines · Fabio Estevam
Quoted 4 lines · Shawn Guo
Quoted 3 lines · Fabio Estevam

Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio supported by default.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Select the driver as module instead of built-in

I've applied a previous version. Should I replace it with this one?

Yes, please.

Done.