Skip to contentSkip to conversation

ARM: MM: Simplify using vma_pages function

PATCH New Mutharaju, Prasanna (P.) 2 participants 2 messages Nov 24, 2015 – Nov 25, 2015 Arm (32-bit)

lore
Share & tools
lore

Mutharaju, Prasanna (P.)

author
#0 lore raw

PATCH 1/1 ARM: MM: Simplify using vma_pages function

From: Prasanna Karthik <[email protected]>

Use vma_pages function on vma object instead of explicit computation.

Signed-off-by Prasanna Karthik <[email protected]>
---
 arch/arm/mm/dma-mapping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/dma-mapping.c +1 -1
index ad4eb2d..513e213 100644
@@ -694,7 +694,7 @@ static int __arm_dma_mmap(struct device *dev, struct vm_area_struct *vma,
 {
 	int ret = -ENXIO;
 #ifdef CONFIG_MMU
-	unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+	unsigned long nr_vma_pages = vma_pages(vma);
 	unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT;
 	unsigned long pfn = dma_to_pfn(dev, dma_addr);
 	unsigned long off = vma->vm_pgoff;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: MM: Simplify using vma_pages function

Hello,

Quoted 5 lines · Prasanna (P.)

From: Prasanna Karthik <[email protected]>

Use vma_pages function on vma object instead of explicit computation.

Signed-off-by Prasanna Karthik <[email protected]>
Acked-by Marek Szyprowski <[email protected]>
Quoted 9 lines
---
  arch/arm/mm/dma-mapping.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/dma-mapping.c +0 -0
index ad4eb2d..513e213 100644

arch/arm/mm/dma-mapping.c static int __arm_dma_mmap(struct device *dev, struct vm_area_struct *vma, · line 700

Quoted 8 lines
arch/arm/mm/dma-mapping.c +1 -1
@@ -694,7 +694,7 @@ static int __arm_dma_mmap(struct device *dev, struct vm_area_struct *vma,
  {
  	int ret = -ENXIO;
  #ifdef CONFIG_MMU
-	unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+	unsigned long nr_vma_pages = vma_pages(vma);
  	unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT;
  	unsigned long pfn = dma_to_pfn(dev, dma_addr);
  	unsigned long off = vma->vm_pgoff;

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland