drm/vmwgfx: fix a warning message

PATCH Superseded Dan Carpenter 2 participants 2 messages Nov 21, 2015 – Nov 24, 2015

Subsystems (4)

DRM drivers DRM misc Kernel janitors DRM driver for VMware virtual GPU

lore

Share & tools

lore

Dan Carpenter

author

2015-11-21 10:29 UTC #0 lore raw

PATCH 1/1 drm/vmwgfx: fix a warning message

The WARN_ON() macro only takes a condition argument, it doesn't take a message. I have converted this to WARN() instead.

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +1 -1

index a8baf5f..b6a0806 100644
@@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
 	else if (ctx_id = SVGA3D_INVALID_ID)
 		ret = vmw_local_fifo_reserve(dev_priv, bytes);
 	else {
-		WARN_ON("Command buffer has not been allocated.\n");
+		WARN(1, "Command buffer has not been allocated.\n");
 		ret = NULL;
 	}
 	if (IS_ERR_OR_NULL(ret)) {

Sinclair Yeh

Reviewed-by on v1 1/1

2015-11-24 19:55 UTC #1 lore raw

Thanks!

Reviewed-by Sinclair Yeh <[email protected]>

Quoted 18 lines · Dan Carpenter

The WARN_ON() macro only takes a condition argument, it doesn't take a message. I have converted this to WARN() instead.
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +1 -1
index a8baf5f..b6a0806 100644
@@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
 	else if (ctx_id == SVGA3D_INVALID_ID)
 		ret = vmw_local_fifo_reserve(dev_priv, bytes);
 	else {
-		WARN_ON("Command buffer has not been allocated.\n");
+		WARN(1, "Command buffer has not been allocated.\n");
 		ret = NULL;
 	}
 	if (IS_ERR_OR_NULL(ret)) {