Skip to contentSkip to conversation

ARM: shmobile: alt: Correct pfc

PATCH New Simon Horman 2 participants 4 messages Nov 24, 2015 – Nov 25, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: shmobile: alt: Correct pfc

22b160713cb6 ("ARM: shmobile: alt: Add pfc pins to DT") introduced pfc pins to the alt device tree but did not reference them. This patch set addresses that and other deficiencies in that patch.

Written and tested against renesas-next-20151118-v4.4-rc1

Changes in v2:
* Corrected commit referenced in changelogs

Simon Horman (2):
ARM: shmobile: alt: Correct scif2 pfc
ARM: shmobile: alt: Correct ether pfc

 arch/arm/boot/dts/r8a7794-alt.dts | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/2 ARM: shmobile: alt: Correct scif2 pfc

22b160713cb6 ("ARM: shmobile: alt: Add pfc pins to DT") introduced pfc pins to the alt device tree but did not reference them. This patch fixes scif2 pfc by adding references to the scif2 pins.

---
v2
* Corrected commit referenced in changelog

---
 arch/arm/boot/dts/r8a7794-alt.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +3 -0
index fd1cfcdd65ef..412eb7ad86db 100644
@@ -182,5 +182,8 @@
 };
 
 &scif2 {
+	pinctrl-0 = <&scif2_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
Signature · 1 line
2.1.4
#2 lore raw

PATCH v2 2/2 ARM: shmobile: alt: Correct ether pfc

In reply to Simon Horman

22b160713cb6 ("ARM: shmobile: alt: Add pfc pins to DT") introduced pfc pins to the alt device tree but did not reference them. This patch fixes ether pfc by:

* Referencing ether pins
* Adding and referencing phy1 pins
* Removing ether b pins. These are not used in the configuration of the alt board used for testing and empirically their presence prevents ethernet from functioning correctly in that environment.

---
v2
* Corrected commit referenced in changelog

---
 arch/arm/boot/dts/r8a7794-alt.dts | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
arch/arm/boot/dts/r8a7794-alt.dts +6 -3
index 412eb7ad86db..7c72494f51b0 100644
@@ -111,9 +111,9 @@
 		renesas,function = "eth";
 	};
 
-	ether_b_pins: ether {
-		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
-		renesas,function = "eth";
+	phy1_pins: phy1 {
+		renesas,groups = "intc_irq8";
+		renesas,function = "intc";
 	};
 
 	i2c1_pins: i2c1 {
@@ -132,6 +132,9 @@
 };
 
 &ether {
+	pinctrl-0 = <&ether_pins &phy1_pins>;
+	pinctrl-names = "default";
+
 	phy-handle = <&phy1>;
 	renesas,ether-link-active-low;
 	status = "okay";
Signature · 1 line
2.1.4
#3 lore raw

v2 cover ARM: shmobile: alt: Correct pfc

In reply to Simon Horman
Quoted 5 lines · Simon Horman

22b160713cb6 ("ARM: shmobile: alt: Add pfc pins to DT") introduced pfc pins to the alt device tree but did not reference them. This patch set addresses that and other deficiencies in that patch.

Written and tested against renesas-next-20151118-v4.4-rc1

I have queued this up.