xen: block: correct setting for xen_blkif_max_ring_order
Subsystems (3)
RFC 1/1 xen: block: correct setting for xen_blkif_max_ring_order
According to this piece code:
"
pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER);
"
if xen_blkif_max_ring_order is bigger that XENBUS_MAX_RING_GRANT_ORDER, need to set xen_blkif_max_ring_order using XENBUS_MAX_RING_GRANT_ORDER, but not 0.
---
Hi,
I am new to xen and reading related soure code, not sure whether this is correct. Please comments.
Thanks
drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/xen-blkfront.c +1 -1
@@ -2126,7 +2126,7 @@ static int __init xlblk_init(void)if (xen_blkif_max_ring_order >XENBUS_MAX_RING_PAGE_ORDER ) {pr_info ("Invalid max_ring_order (%d), will use default max: %d.\n" , xen_blkif_max_ring_order,XENBUS_MAX_RING_PAGE_ORDER ); - xen_blkif_max_ring_order =0 ; + xen_blkif_max_ring_order =XENBUS_MAX_RING_PAGE_ORDER ; }if (!xen_has_pv_disk_devices ())
Signature · 1 line
2.6.2
Konrad Rzeszutek Wilk
AppliedQuoted 14 lines · Peng Fan
According to this piece code:
"
pr_info("Invalidmax_ring_order(%d), will use default max: %d.\n",
xen_blkif_max_ring_order,XENBUS_MAX_RING_GRANT_ORDER);
"
ifxen_blkif_max_ring_orderis bigger thatXENBUS_MAX_RING_GRANT_ORDER, need to setxen_blkif_max_ring_orderusingXENBUS_MAX_RING_GRANT_ORDER, but not 0.Signed-off-by Peng Fan <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Cc Boris Ostrovsky <[email protected]>Cc David Vrabel <[email protected]>Cc "Roger Pau Monné" <[email protected]>
Quoted 6 lines
---
Hi,
I am new to xen and reading related soure code, not sure whether this is correct. Please comments.
Applied to 'devel/for-jens-4.5'.
Thanks!
Quoted 22 lines
Thanks
drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/block/xen-blkfront.c +1
-1@@ -2126,7 +2126,7 @@ static int __init xlblk_init(void)if (xen_blkif_max_ring_order >XENBUS_MAX_RING_PAGE_ORDER ) {pr_info ("Invalid max_ring_order (%d), will use default max: %d.\n" , xen_blkif_max_ring_order,XENBUS_MAX_RING_PAGE_ORDER ); - xen_blkif_max_ring_order =0 ; + xen_blkif_max_ring_order =XENBUS_MAX_RING_PAGE_ORDER ; }if (!xen_has_pv_disk_devices ())Signature · 1 line
2.6.2
Konrad Rzeszutek Wilk
AppliedQuoted 14 lines · Peng Fan
According to this piece code:
"
pr_info("Invalidmax_ring_order(%d), will use default max: %d.\n",
xen_blkif_max_ring_order,XENBUS_MAX_RING_GRANT_ORDER);
"
ifxen_blkif_max_ring_orderis bigger thatXENBUS_MAX_RING_GRANT_ORDER, need to setxen_blkif_max_ring_orderusingXENBUS_MAX_RING_GRANT_ORDER, but not 0.Signed-off-by Peng Fan <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Cc Boris Ostrovsky <[email protected]>Cc David Vrabel <[email protected]>Cc "Roger Pau Monné" <[email protected]>
Quoted 6 lines
---
Hi,
I am new to xen and reading related soure code, not sure whether this is correct. Please comments.
Applied to 'devel/for-jens-4.5'.
Thanks!
Quoted 22 lines
Thanks
drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/block/xen-blkfront.c +1
-1@@ -2126,7 +2126,7 @@ static int __init xlblk_init(void)if (xen_blkif_max_ring_order >XENBUS_MAX_RING_PAGE_ORDER ) {pr_info ("Invalid max_ring_order (%d), will use default max: %d.\n" , xen_blkif_max_ring_order,XENBUS_MAX_RING_PAGE_ORDER ); - xen_blkif_max_ring_order =0 ; + xen_blkif_max_ring_order =XENBUS_MAX_RING_PAGE_ORDER ; }if (!xen_has_pv_disk_devices ())Signature · 1 line
2.6.2