Skip to contentSkip to conversation

controllers/pids: Add new testcases

PATCH Superseded Cedric Hnyda 2 participants 2 messages Nov 25, 2015

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 controllers/pids: Add new testcases

Created new testcases to test the pids controller which is used to stop any new tasks from being fork()'d after a certain limit is reached.

---
 runtest/controllers                            |  22 +++
 testcases/kernel/controllers/pids/.gitignore   |   2 +
 testcases/kernel/controllers/pids/Makefile     |  28 ++++
 testcases/kernel/controllers/pids/pids.sh      | 202 +++++++++++++++++++++++++
 testcases/kernel/controllers/pids/pids_task1.c |  63 ++++++++
 testcases/kernel/controllers/pids/pids_task2.c |  30 ++++
 6 files changed, 347 insertions(+)
 create mode 100644 testcases/kernel/controllers/pids/.gitignore
 create mode 100644 testcases/kernel/controllers/pids/Makefile
 create mode 100644 testcases/kernel/controllers/pids/pids.sh
 create mode 100644 testcases/kernel/controllers/pids/pids_task1.c
 create mode 100644 testcases/kernel/controllers/pids/pids_task2.c
runtest/controllers +22 -0
index c62bcce..254a0b0 100644
@@ -277,3 +277,25 @@ cpuset_memory_spread	cpuset_memory_spread_testset.sh
 cpuset_regression_test cpuset_regression_test.sh
 
 cgroup_xattr	cgroup_xattr
+
+pids_1_1 pids.sh 1 1
+pids_1_2 pids.sh 1 2
+pids_1_10 pids.sh 1 10
+pids_1_50 pids.sh 1 50
+pids_1_100 pids.sh 1 100
+pids_2_1 pids.sh 2 1
+pids_2_2 pids.sh 2 2
+pids_2_10 pids.sh 2 10
+pids_2_50 pids.sh 2 50
+pids_2_100 pids.sh 2 100
+pids_3_1 pids.sh 3 1
+pids_3_2 pids.sh 3 2
+pids_3_10 pids.sh 3 10
+pids_3_50 pids.sh 3 50
+pids_3_100 pids.sh 3 100
+pids_4_1 pids.sh 4 1
+pids_4_2 pids.sh 4 2
+pids_4_10 pids.sh 4 10
+pids_4_50 pids.sh 4 50
+pids_4_100 pids.sh 4 100
+pids_5_1 pids.sh 5 1
testcases/kernel/controllers/pids/.gitignore new file +2 -0
new file mode 100644
index 0000000..a87cce8
@@ -0,0 +1,2 @@
+/pids_task1
+/pids_task2
testcases/kernel/controllers/pids/Makefile new file +28 -0
new file mode 100644
index 0000000..6500363
@@ -0,0 +1,28 @@
+#
+#    Copyright (C) 2015, SUSE
+#
+#    This program is free software; you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation; either version 2 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License along
+#    with this program; if not, write to the Free Software Foundation, Inc.,
+#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# Author: Cedric Hnyda <[email protected]>
+#
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(abs_srcdir)/../Makefile.inc
+
+INSTALL_TARGETS		:= *.sh
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/controllers/pids/pids.sh new file +202 -0

202 lines not on this page · raw message

testcases/kernel/controllers/pids/pids_task1.c new file +63 -0

63 lines not on this page · raw message

testcases/kernel/controllers/pids/pids_task2.c new file +30 -0
new file mode 100644
index 0000000..130d619
@@ -0,0 +1,30 @@
+/*
+ * Copyright (c) 2015 Cedric Hnyda <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include <stdio.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <errno.h>
+#include <stdlib.h>
+
+int main(void)
+{
+	pause();
+	return 0;
+}
Signature · 1 line
2.1.4
#1 lore raw

PATCH v4 1/1 controllers/pids: Add new testcases

Hi!

Quoted 41 lines
testcases/kernel/controllers/pids/pids.sh new file +41 -0
+cleanup()
+{
+	killall -9 pids_task2 > /dev/null
+
+	tst_resm TINFO "removing created directories"
+	rmdir $testpath
+	if [ "$mounted" -ne "1" ]; then
+		tst_resm TINFO "Umounting pids"
+		umount $mount_point
+		rmdir $mount_point
+	fi
+}
+
+setup()
+{
+	tst_require_root
+
+	exist=`grep -w pids /proc/cgroups | cut -f1`;
+	if [ "$exist" = "" ]; then
+		tst_brkm TCONF NULL "pids not supported"
+	fi
+
+	mount_point=`grep -w pids /proc/mounts | cut -f 2 | cut -d " " -f2`
+
+	if [ "$mount_point" = "" ]; then
+		mounted=0
+		mount_point=/dev/cgroup
+	fi
+
+	TST_CLEANUP=cleanup
+
+	testpath=$mount_point/ltp_$TCID
+
+	if [ "$mounted" -eq "0" ]; then
+		ROD mkdir -p $mount_point
+		ROD mount -t cgroup -o pids none $mount_point
+	fi
+	ROD mkdir -p $testpath
+}
+
+start_pids_tasks2()

testcases/kernel/controllers/pids/pids.sh line 94

Quoted 10 lines
testcases/kernel/controllers/pids/pids.sh new file +10 -0
+{
+	nb=$1
+	for i in `seq 1 $nb`; do
+		pids_task2 &
+		echo $! > $testpath/tasks
+	done
+
+	while [ $(cat "$testpath/tasks" | wc -l) -lt $nb ]; do
+		sleep 1
+	done

We do not have to check that the task are attached now that we attach the program to the cgroup tasks in the for loop here, right?

What we should do here now instead is to check that the tasks were attached. I.e.

if [ $(cat "$testpath/tasks" | wc -l) -ne $nb ]; then

	tst_resm TBROK "..."

fi

Or we should handle the return value from the echo, since now the program would run on a backgound even when it couldn't be attached.

Either way the case4() could then be simplified to only run this function and print TPASS if we do not TBROK here.

Quoted 163 lines
testcases/kernel/controllers/pids/pids.sh new file +108 -0
+}
+
+case1()
+{
+	start_pids_tasks2 $max
+
+	# should return 0 because there is no limit
+	pids_task1 "$testpath/tasks"
+	ret=$?
+
+	killall -9 pids_task2
+
+	if [ "$ret" -eq "2" ]; then
+		tst_resm TFAIL "fork failed unexpectedly"
+	elif [ "$ret" -eq "0" ]; then
+		tst_resm TPASS "fork didn't fail"
+	else
+		tst_resm TBROK "pids_task1 failed"
+	fi
+}
+
+case2()
+{
+	tmp=$((max - 1))
+	tst_resm TINFO "limit the number of pid to $max"
+	ROD echo $max > $testpath/pids.max
+
+	start_pids_tasks2 $tmp
+
+	# should return 2 because the limit of pids is reached
+	pids_task1 "$testpath/tasks"
+	ret=$?
+
+	killall -9 pids_task2
+
+	if [ "$ret" -eq "2" ]; then
+		tst_resm TPASS "fork failed as expected"
+	elif [ "$ret" -eq "0" ]; then
+		tst_resm TFAIL "fork didn't fail despite the limit"
+	else
+		tst_resm TBROK "pids_task1 failed"
+	fi
+}
+
+case3()
+{
+	tmp=$((max + 1))
+	tst_resm TINFO "limit the number of avalaible pid to $tmp"
+	ROD echo $tmp > $testpath/pids.max
+
+	tmp=$((max - 2))
+	start_pids_tasks2 $tmp
+
+	pids_task1 "$testpath/tasks"
+	ret=$?
+
+	killall -9 pids_task2
+
+	if [ "$ret" -eq "2" ]; then
+		tst_resm TFAIL "fork failed unexpectedly"
+	elif [ "$ret" -eq "0" ]; then
+		tst_resm TPASS "fork worked as expected"
+	else
+		tst_resm TBROK "pids_task1 failed"
+	fi
+}
+
+case4()
+{
+	tst_resm TINFO "limit the number of avalaible pid to 0"
+	ROD echo 0 > $testpath/pids.max
+
+	start_pids_tasks2 $max
+
+	# count the number of attached process
+	cnt=`jobs -p | wc -l`
+
+	killall -9 pids_task2
+
+	if [ "$cnt" -ne "$max" ]; then
+		cnt=$((max - cnt))
+		tst_resm TFAIL "$cnt process were not attached successfully"
+	else
+		tst_resm TPASS "all process were attached"
+	fi
+}
+
+case5()
+{
+	tst_resm TINFO "try to limit the number of avalaible pid to -1"
+	echo -1 > $testpath/pids.max
+
+	if [ "$?" -eq "0" ]; then
+		tst_resm TFAIL "managed to set the limit to -1"
+	else
+		tst_resm TPASS "didn't manage to set the limit to -1"
+	fi
+}
+
+setup
+
+if [ "$#" -ne "2" ]; then
+	usage
+else
+	case$caseno
+fi
+
+tst_exit
testcases/kernel/controllers/pids/pids_task1.c new file +49 -0
new file mode 100644
index 0000000..a470ccf
@@ -0,0 +1,63 @@
+/*
+ * Copyright (c) 2015 Cedric Hnyda <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+/*
+* Description:
+* Write the current process in argv[1]
+* and returns:
+*	-> 2 if fork fails with EAGAIN,
+*	-> 1 if there is another problem
+*	-> 0 if everything worked
+*/
+
+#include <stdio.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <errno.h>
+#include <stdlib.h>
+#include <string.h>
+
+int main(int argc, char **argv)
+{
+	FILE *f;
+	int newpid;
+
+	if (argc != 2) {
+		fprintf(stderr, "Usage: %s /cgroup/.../tasks\n", argv[0]);
+		return 1;
+	}
+
+	f = fopen(argv[1], "a");
+	if (!f) {
+		perror("fopen failed");
+		return 1;

testcases/kernel/controllers/pids/pids_task1.c line 59

Quoted 10 lines
testcases/kernel/controllers/pids/pids_task1.c new file +10 -0
+	}
+
+	fprintf(f, "%i\n", getpid());
+	fclose(f);
+
+	newpid = fork();
+	if (newpid == -1 && errno == EAGAIN)
+		return 2;
+	if (newpid == -1) {
+		strerror(errno);

^
Did you mean perror("fork()") ?

Quoted 24 lines
testcases/kernel/controllers/pids/pids_task1.c new file +4 -0
+		return 1;
+	}
+	return 0;
+}
testcases/kernel/controllers/pids/pids_task2.c new file +14 -0
new file mode 100644
index 0000000..130d619
@@ -0,0 +1,30 @@
+/*
+ * Copyright (c) 2015 Cedric Hnyda <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License

testcases/kernel/controllers/pids/pids_task2.c line 24

Quoted 10 lines
testcases/kernel/controllers/pids/pids_task2.c new file +10 -0
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include <stdio.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <errno.h>
+#include <stdlib.h>

technically we only need to include the unistd.h here

Quoted 11 lines
testcases/kernel/controllers/pids/pids_task2.c new file +5 -0
+int main(void)
+{
+	pause();
+	return 0;
+}
Signature · 5 lines
2.1.4


-- 
Mailing list info: http://lists.linux.it/listinfo/ltp
Signature · 2 lines
Cyril Hrubis
[email protected]