PCI: imx6: Use gpio_set_value_cansleep()
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 PCI: imx6: Use gpio_set_value_cansleep()
From: Fabio Estevam <[email protected]>
We are in a context where we can sleep, and the PCIe reset gpio may be on an I2C expander. Use the cansleep() variant when setting the GPIO value.
Based on a patch from Russell King for pci-mvebu.c.
--- drivers/pci/host/pci-imx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/host/pci-imx6.c +2 -2
@@ -289,9 +289,9 @@ static int imx6_pcie_deassert_core_reset(struct pcie_port *pp)/* Some boards don't have PCIe reset GPIO. */ if (gpio_is_valid (imx6_pcie->reset_gpio)) { -gpio_set_value (imx6_pcie->reset_gpio,0 ); +gpio_set_value_cansleep (imx6_pcie->reset_gpio,0 );msleep (100 ); -gpio_set_value (imx6_pcie->reset_gpio,1 ); +gpio_set_value_cansleep (imx6_pcie->reset_gpio,1 ); }return 0 ;
Signature · 1 line
1.9.1
Am Dienstag, den 27.10.2015, 21:41 -0200 schrieb Fabio Estevam:
Quoted 9 lines
From: Fabio Estevam <[email protected]>
We are in a context where we can sleep, and the PCIe reset gpio may be on an I2C expander. Use the
cansleep()variant when setting the GPIO value.Based on a patch from Russell King for
pci-mvebu.c.Signed-off-by Fabio Estevam <[email protected]>
Simple enough,
Quoted 20 lines
--- drivers/pci/host/pci-imx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pci/host/pci-imx6.c +2
-2@@ -289,9 +289,9 @@ static int imx6_pcie_deassert_core_reset(struct pcie_port *pp)/* Some boards don't have PCIe reset GPIO. */ if (gpio_is_valid (imx6_pcie->reset_gpio)) { -gpio_set_value (imx6_pcie->reset_gpio,0 ); +gpio_set_value_cansleep (imx6_pcie->reset_gpio,0 );msleep (100 ); -gpio_set_value (imx6_pcie->reset_gpio,1 ); +gpio_set_value_cansleep (imx6_pcie->reset_gpio,1 ); }return 0 ;
Signature · 2 lines
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
We are in a context where we can sleep, and the PCIe reset gpio may be on an I2C expander. Use the
cansleep()variant when setting the GPIO value.Based on a patch from Russell King for
pci-mvebu.c.Signed-off-by Fabio Estevam <[email protected]>
Applied with Lucas' Reviewed-by to pci/host-imx6 for v4.5, thanks!
Quoted 27 lines
--- drivers/pci/host/pci-imx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pci/host/pci-imx6.c +2
-2@@ -289,9 +289,9 @@ static int imx6_pcie_deassert_core_reset(struct pcie_port *pp)/* Some boards don't have PCIe reset GPIO. */ if (gpio_is_valid (imx6_pcie->reset_gpio)) { -gpio_set_value (imx6_pcie->reset_gpio,0 ); +gpio_set_value_cansleep (imx6_pcie->reset_gpio,0 );msleep (100 ); -gpio_set_value (imx6_pcie->reset_gpio,1 ); +gpio_set_value_cansleep (imx6_pcie->reset_gpio,1 ); }return 0 ;Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html