drivers:pci:hotplug Fix all "space prohibited before that ..."
PATCH 1/1 drivers:pci:hotplug Fix all "space prohibited before that ..."
This fixes all errors "space prohibited before that..." from checkpatch.pl
--- drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pci/hotplug/pci_hotplug_core.c +4 -4
@@ -45,10 +45,10 @@#define MY_NAME "pci_hotplug" -#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0) -#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg) -#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg) -#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg) +#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0) +#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg) +#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg) +#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)/* local variables */
Signature · 1 line
2.1.4
Hi Bogicevic,
Quoted 2 lines · Bogicevic Sasa
This fixes all errors "space prohibited before that..." from checkpatch.pl
I'd take this, but I'd prefer to fix everything under drivers/pci in a single patch, and I see several other instances of this. I just did this to find them:
$ grep -r " ," drivers/pci/
Can you expand this patch to fix them all?
Thanks,
Bjorn
Quoted 31 lines
Signed-off-by Bogicevic Sasa <[email protected]>--- drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pci/hotplug/pci_hotplug_core.c +4
-4@@ -45,10 +45,10 @@#define MY_NAME "pci_hotplug" -#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0) -#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg) -#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg) -#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg) +#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0) +#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg) +#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg) +#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)/* local variables */ Signature · 6 lines
2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Sure thing, I am sending the new patch with all corrected
Thanks, Sasa
Quoted 48 lines · Bjorn Helgaas
Hi Bogicevic,
Quoted 2 lines · Bogicevic Sasa
This fixes all errors "space prohibited before that..." from checkpatch.pl
I'd take this, but I'd prefer to fix everything under
drivers/pciin a single patch, and I see several other instances of this. I just did this to find them:$ grep -r " ," drivers/pci/Can you expand this patch to fix them all?
Thanks,
BjornQuoted 31 lines
Signed-off-by Bogicevic Sasa <[email protected]>--- drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pci/hotplug/pci_hotplug_core.c +4
-5@@ -45,10 +45,10 @@#define MY_NAME "pci_hotplug" -#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0) -#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg) -#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg) -#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg) +#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0) +#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg) +#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg) +#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)/* local variables */ --2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html