Skip to contentSkip to conversation

cxxtest: new package

PATCH Superseded Abhishek Singh 2 participants 3 messages Nov 26, 2015

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxxtest: new package

---
 package/Config.in            |  1 +
 package/cxxtest/Config.in    | 10 ++++++++++
 package/cxxtest/cxxtest.hash |  2 ++
 package/cxxtest/cxxtest.mk   | 25 +++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/cxxtest/Config.in
 create mode 100644 package/cxxtest/cxxtest.hash
 create mode 100644 package/cxxtest/cxxtest.mk
package/Config.in +1 -0
index bdc3063..6e71d25 100644
@@ -116,6 +116,7 @@ menu "Development tools"
 	source "package/cmake/Config.in"
 	source "package/cppunit/Config.in"
 	source "package/cvs/Config.in"
+	source "package/cxxtest/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/diffutils/Config.in"
 	source "package/dos2unix/Config.in"
package/cxxtest/Config.in new file +10 -0
new file mode 100644
index 0000000..7512e4b
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_CXXTEST
+	bool "cxxtest"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  CxxTest is a unit testing framework for C++
+
+	  http://cxxtest.com/
+
+comment "cxxtest needs toolchain with C++ support"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/cxxtest/cxxtest.hash new file +2 -0
new file mode 100644
index 0000000..f552e80
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256	1c154fef91c65dbf1cd4519af7ade70a61d85a923b6e0c0b007dc7f4895cf7d8	cxxtest-4.4.tar.gz
package/cxxtest/cxxtest.mk new file +25 -0
new file mode 100644
index 0000000..5089f92
@@ -0,0 +1,25 @@
+################################################################################
+#
+# cxxtest
+#
+################################################################################
+
+CXXTEST_VERSION = 4.4
+CXXTEST_SOURCE = cxxtest-$(CXXTEST_VERSION).tar.gz
+CXXTEST_SITE = http://sourceforge.net/projects/cxxtest/files/cxxtest/$(CXXTEST_VERSION)
+CXXTEST_LICENSE = LGPLv3
+CXXTEST_LICENSE_FILES = COPYING
+CXXTEST_INSTALL_STAGING = YES
+CXXTEST_INSTALL_TARGET = NO
+CXXTEST_DEPENDENCIES = host-cxxtest
+HOST_CXXTEST_DEPENDENCIES = host-python
+HOST_CXXTEST_SETUP_TYPE = setuptools
+HOST_CXXTEST_SUBDIR = python
+
+define CXXTEST_INSTALL_STAGING_CMDS
+	mkdir -p $(STAGING_DIR)/usr/include/cxxtest
+	cp $(@D)/cxxtest/* $(STAGING_DIR)/usr/include/cxxtest
+endef
+
+$(eval $(generic-package))
+$(eval $(host-python-package))
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 cxxtest: new package

Dear Abhishek Singh,

Quoted 33 lines · Abhishek Singh
package/cxxtest/Config.in new file +10 -0
new file mode 100644
index 0000000..7512e4b
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_CXXTEST
+	bool "cxxtest"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  CxxTest is a unit testing framework for C++
+
+	  http://cxxtest.com/
+
+comment "cxxtest needs toolchain with C++ support"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/cxxtest/cxxtest.hash new file +2 -0
new file mode 100644
index 0000000..f552e80
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256	1c154fef91c65dbf1cd4519af7ade70a61d85a923b6e0c0b007dc7f4895cf7d8	cxxtest-4.4.tar.gz
package/cxxtest/cxxtest.mk new file +3 -0
new file mode 100644
index 0000000..5089f92
@@ -0,0 +1,25 @@
+################################################################################
+#
+# cxxtest

package/cxxtest/cxxtest.mk line 13

Quoted 10 lines
package/cxxtest/cxxtest.mk new file +10 -0
+#
+################################################################################
+
+CXXTEST_VERSION = 4.4
+CXXTEST_SOURCE = cxxtest-$(CXXTEST_VERSION).tar.gz
+CXXTEST_SITE = http://sourceforge.net/projects/cxxtest/files/cxxtest/$(CXXTEST_VERSION)
+CXXTEST_LICENSE = LGPLv3
+CXXTEST_LICENSE_FILES = COPYING
+CXXTEST_INSTALL_STAGING = YES
+CXXTEST_INSTALL_TARGET = NO

Is CxxTest just a set of C++ headers with no library ?

package/cxxtest/cxxtest.mk line 15

Quoted 2 lines
package/cxxtest/cxxtest.mk new file +2 -0
+CXXTEST_DEPENDENCIES = host-cxxtest
+HOST_CXXTEST_DEPENDENCIES = host-python

This is not needed. host-cxxtest is using host-python-package, so the dependency on host-python is automatically added by the host-python-package infrastructure.

package/cxxtest/cxxtest.mk line 25

Quoted 10 lines
package/cxxtest/cxxtest.mk new file +10 -0
+HOST_CXXTEST_SETUP_TYPE = setuptools
+HOST_CXXTEST_SUBDIR = python
+
+define CXXTEST_INSTALL_STAGING_CMDS
+	mkdir -p $(STAGING_DIR)/usr/include/cxxtest
+	cp $(@D)/cxxtest/* $(STAGING_DIR)/usr/include/cxxtest
+endef
+
+$(eval $(generic-package))
+$(eval $(host-python-package))

I have to say it is quite strange to have the host variant of the package using the python package infrastructure, and the target variant use the generic package infra. I think it would deserve an additional comment in the .mk file to give a bit of context about why you're doing this.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 cxxtest: new package

Quoted 40 lines · Thomas Petazzoni

Dear Abhishek Singh,

Quoted 36 lines · Abhishek Singh
package/cxxtest/Config.in new file +10 -0
new file mode 100644
index 0000000..7512e4b
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_CXXTEST
+	bool "cxxtest"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  CxxTest is a unit testing framework for C++
+
+	  http://cxxtest.com/
+
+comment "cxxtest needs toolchain with C++ support"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/cxxtest/cxxtest.hash new file +2 -0
new file mode 100644
index 0000000..f552e80
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256	1c154fef91c65dbf1cd4519af7ade70a61d85a923b6e0c0b007dc7f4895cf7d8	cxxtest-4.4.tar.gz
package/cxxtest/cxxtest.mk new file +6 -0
new file mode 100644
index 0000000..5089f92
@@ -0,0 +1,25 @@
+################################################################################
+#
+# cxxtest
+#
+################################################################################
+
Quoted 8 lines

package/cxxtest/cxxtest.mk line 13

Quoted 7 lines
package/cxxtest/cxxtest.mk new file +7 -0
+CXXTEST_VERSION = 4.4
+CXXTEST_SOURCE = cxxtest-$(CXXTEST_VERSION).tar.gz
+CXXTEST_SITE = http://sourceforge.net/projects/cxxtest/files/cxxtest/$(CXXTEST_VERSION)
+CXXTEST_LICENSE = LGPLv3
+CXXTEST_LICENSE_FILES = COPYING
+CXXTEST_INSTALL_STAGING = YES
+CXXTEST_INSTALL_TARGET = NO

Is CxxTest just a set of C++ headers with no library ?

CxxTest is just set of C++ headers and source files (acting as header). It uses python infrastructure to generate cxxtestgen command.

Quoted 26 lines

package/cxxtest/cxxtest.mk line 15

Quoted 3 lines
package/cxxtest/cxxtest.mk new file +2 -0
+CXXTEST_DEPENDENCIES = host-cxxtest
+HOST_CXXTEST_DEPENDENCIES = host-python

This is not needed. host-cxxtest is using host-python-package, so the dependency on host-python is automatically added by the host-python-package infrastructure.

package/cxxtest/cxxtest.mk line 25

Quoted 10 lines
package/cxxtest/cxxtest.mk new file +10 -0
+HOST_CXXTEST_SETUP_TYPE = setuptools
+HOST_CXXTEST_SUBDIR = python
+
+define CXXTEST_INSTALL_STAGING_CMDS
+	mkdir -p $(STAGING_DIR)/usr/include/cxxtest
+	cp $(@D)/cxxtest/* $(STAGING_DIR)/usr/include/cxxtest
+endef
+
+$(eval $(generic-package))
+$(eval $(host-python-package))

I have to say it is quite strange to have the host variant of the package using the python package infrastructure, and the target variant use the generic package infra. I think it would deserve an additional comment in the .mk file to give a bit of context about why you're doing this.

Thanks!

Thomas