Skip to contentSkip to conversation

containers/netns/netns_sysfs.sh: removed invalid excess line

PATCH New Matus Marhefka 3 participants 3 messages Nov 26, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 containers/netns/netns_sysfs.sh: removed invalid excess line

---
 testcases/kernel/containers/netns/netns_sysfs.sh | 2 --
 1 file changed, 2 deletions(-)
testcases/kernel/containers/netns/netns_sysfs.sh +0 -2
index b951f32..4c6e7e4 100755
@@ -52,8 +52,6 @@ TST_CLEANUP=cleanup
 # by the dummy device driver upon insmod/modprobe (during ip link add)
 ls /sys/class/net | grep -v 'dummy[0-9]\+' >sysfs_before
 
-ls /sys/class/net >sysfs_before
-
 ns_exec $NS_HANDLE $NS_TYPE mount --make-rprivate /sys
 ns_exec $NS_HANDLE $NS_TYPE ip link add $DUMMYDEV type dummy || \
 	tst_brkm TBROK "failed to add a new dummy device"
Signature · 1 line
2.4.3
#1 lore raw

PATCH 1/1 containers/netns/netns_sysfs.sh: removed invalid excess line

Quoted 1 line · Matus Marhefka

For what it's worth,

I admit that this was a brain fart on my part, I submitted a patch against a testing/debug version of that file. Sorry about that.

Quoted 18 lines
---
 testcases/kernel/containers/netns/netns_sysfs.sh | 2 --
 1 file changed, 2 deletions(-)
testcases/kernel/containers/netns/netns_sysfs.sh +0 -2
index b951f32..4c6e7e4 100755
@@ -52,8 +52,6 @@ TST_CLEANUP=cleanup
 # by the dummy device driver upon insmod/modprobe (during ip link add)
 ls /sys/class/net | grep -v 'dummy[0-9]\+' >sysfs_before
 
-ls /sys/class/net >sysfs_before
-
 ns_exec $NS_HANDLE $NS_TYPE mount --make-rprivate /sys
 ns_exec $NS_HANDLE $NS_TYPE ip link add $DUMMYDEV type dummy || \
 	tst_brkm TBROK "failed to add a new dummy device"
#2 lore raw

PATCH 1/1 containers/netns/netns_sysfs.sh: removed invalid excess line

Hi!

Quoted 4 lines

I admit that this was a brain fart on my part, I submitted a patch against a testing/debug version of that file. Sorry about that.

And my bad that I pushed it without doble checking...

Thanks for the fix, pushed.

Signature · 2 lines
Cyril Hrubis
[email protected]