Skip to contentSkip to conversation

mei_fasync() bogosity

bug Al Viro 1 participant 1 message Nov 27, 2015

lore
Share & tools
lore

Al Viro

author
#0 lore raw

in "mei: implement fasync for event notification" a ->fasync() instance is added as

static int mei_fasync(int fd, struct file *file, int band) {

	struct mei_cl *cl = file->private_data;

	if (!mei_cl_is_connected(cl))
		return POLLERR;

	return fasync_helper(fd, file, band, &cl->ev_async);
}

Valid return values for ->fasync() are 0, 1 and -E...; 8 (aka POLLERR) is not. What had been intended there? -ENODEV? Some other error? As it is, the thing is broken.