Skip to contentSkip to conversation

package/autossh: really fix the path to ssh

PATCH New Yann E. MORIN 2 participants 2 messages Nov 27, 2015 – Nov 28, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/autossh: really fix the path to ssh

The ./configure script is not up-to-date with what is in configure.ac, which prevents --with-ssh from working properly.

So, we autoreconfigure autossh, which fixes the issue.

Note however that this is not really an autotools package, since it only uses autoconf and not automake. However, making it a generic pacakge is not trivial, since autossh really wants config.h as generated by ./configure. Using the autotools infra in this case helps us easily autoreconfiguring without to manual depend on all the autotools-relates host packages.

---
Note: the previous fix was not tested in the same conditions that detected the issue initially, so I believed it was fixed. But it was not. Sorry... :-/

---
 package/autossh/autossh.mk | 3 +++
 1 file changed, 3 insertions(+)
package/autossh/autossh.mk +3 -0
index 8a9def3..d52b4e9 100644
@@ -10,6 +10,9 @@ AUTOSSH_SOURCE = autossh-$(AUTOSSH_VERSION).tgz
 AUTOSSH_LICENSE = Modified BSD
 AUTOSSH_LICENSE_FILES = autossh.c
 
+# Bundled ./configure is not up-to-date with what is in configure.ac
+AUTOSSH_AUTORECONF = YES
+
 AUTOSSH_CONF_OPTS = --with-ssh=/usr/bin/ssh
 
 define AUTOSSH_INSTALL_TARGET_CMDS
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/autossh: really fix the path to ssh

Yann,

Quoted 11 lines · Yann E. MORIN

The ./configure script is not up-to-date with what is in configure.ac, which prevents --with-ssh from working properly.

So, we autoreconfigure autossh, which fixes the issue.

Note however that this is not really an autotools package, since it only uses autoconf and not automake. However, making it a generic pacakge is not trivial, since autossh really wants config.h as generated by ./configure. Using the autotools infra in this case helps us easily autoreconfiguring without to manual depend on all the autotools-relates host packages.

FWIW, I am not completely against using the autotools-package infra for packages using just autoconf but not automake. autossh is far from being he only package in this situation.

What I really don't like is to use autotools-package when there is a non-autoconf configure script.

Otherwise: patch applied to master, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com