Skip to contentSkip to conversation

libtirpc: add dependency on atomic operations

PATCH New Sergio Prado 2 participants 3 messages Nov 28, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtirpc: add dependency on atomic operations

Fixes:
http://autobuild.buildroot.net/results/9e6c3c701e09007860bf842f1877142ea20cbb55
http://autobuild.buildroot.net/results/dce2b68429734dbd63bab0bf75593b9dc44a5e42
http://autobuild.buildroot.net/results/9a13d40e7cc54a632b1a4063e7e9fcea5402c368

And many more.

---
 package/libtirpc/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/libtirpc/Config.in +2 -0
index 2e9c939fa815..a7dfaf79db08 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBTIRPC
 	bool "libtirpc"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_ARCH_HAS_ATOMICS
 	help
 	  Libtirpc is a port of Sun's Transport-Independent RPC
 	  library to Linux.
@@ -8,4 +9,5 @@ config BR2_PACKAGE_LIBTIRPC
 	  http://sourceforge.net/projects/libtirpc/
 
 comment "libtirpc needs a toolchain w/ threads"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 libtirpc: add dependency on atomic operations

Sergio,

Thanks for the patch.

Quoted 17 lines · Sergio Prado

Fixes:
http://autobuild.buildroot.net/results/9e6c3c701e09007860bf842f1877142ea20cbb55
http://autobuild.buildroot.net/results/dce2b68429734dbd63bab0bf75593b9dc44a5e42
http://autobuild.buildroot.net/results/9a13d40e7cc54a632b1a4063e7e9fcea5402c368

And many more.

---
 package/libtirpc/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/libtirpc/Config.in +0 -0
index 2e9c939fa815..a7dfaf79db08 100644

package/libtirpc/Config.in line 5

Quoted 5 lines
package/libtirpc/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBTIRPC
 	bool "libtirpc"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_ARCH_HAS_ATOMICS
 	help

This is not correct, because when you add such dependencies, they must be replicated in all packages that do "select BR2_PACKAGE_LIBTIRPC".

Also, we have updated libtirpc to version 1.0.1 in the next branch, and this new version no longer requires atomic operations. So I believe we will leave things as is for 2015.11 (i.e libtirpc broken for sparc), and 2016.02 will have the update of libtirpc to 1.0.1.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 libtirpc: add dependency on atomic operations

2015-11-28 15:07 GMT-02:00 Thomas Petazzoni <
[email protected]>:

Quoted 20 lines

Sergio,

Thanks for the patch.

Quoted 2 lines · Sergio Prado

Fixes:

http://autobuild.buildroot.net/results/9e6c3c701e09007860bf842f1877142ea20cbb55

Quoted 1 line

http://autobuild.buildroot.net/results/dce2b68429734dbd63bab0bf75593b9dc44a5e42

Quoted 1 line

http://autobuild.buildroot.net/results/9a13d40e7cc54a632b1a4063e7e9fcea5402c368

Quoted 8 lines

And many more.

---
 package/libtirpc/Config.in | 2 ++
 1 file changed, 2 insertions(+)
Quoted 14 lines

package/libtirpc/Config.in line 5

Quoted 10 lines
package/libtirpc/Config.in +1 -0
index 2e9c939fa815..a7dfaf79db08 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBTIRPC
      bool "libtirpc"
      depends on BR2_TOOLCHAIN_HAS_THREADS
+     depends on BR2_ARCH_HAS_ATOMICS
      help

This is not correct, because when you add such dependencies, they must be replicated in all packages that do "select BR2_PACKAGE_LIBTIRPC".

Right.

Quoted 6 lines

Also, we have updated libtirpc to version 1.0.1 in the next branch, and this new version no longer requires atomic operations. So I believe we will leave things as is for 2015.11 (i.e libtirpc broken for sparc), and 2016.02 will have the update of libtirpc to 1.0.1.

OK, makes sense.

Quoted 3 lines

Best regards,

Thanks,

Quoted 7 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151128/a61c89d8/attachment.html>