Skip to contentSkip to conversation

when ring test fails, provide users with option to test

radeon r100 NAK Pavel Machek 3 participants 7 messages Nov 28, 2015 – Dec 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Ring test failure is often caused by too high agpmode. Tell the user what to try.

drivers/gpu/drm/radeon/r100.c +1 -1
index 238b13f..32b1917 100644
@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
 	if (i < rdev->usec_timeout) {
 		DRM_INFO("ring test succeeded in %d usecs\n", i);
 	} else {
-		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
+		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
 			  scratch, tmp);
 		r = -EINVAL;
 	}
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer NAK
#1 lore raw
Quoted 4 lines · Pavel Machek

Ring test failure is often caused by too high agpmode. Tell the user what to try.

NAK, the ring test can fail for any number of reasons and the agpmode is actually rather unlikely to be the cause.

Regards,
Christian.

Quoted 7 lines
drivers/gpu/drm/radeon/r100.c +0 -0
index 238b13f..32b1917 100644

drivers/gpu/drm/radeon/r100.c int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring) · line 3671

Quoted 8 lines
drivers/gpu/drm/radeon/r100.c +1 -1
@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
  	if (i < rdev->usec_timeout) {
  		DRM_INFO("ring test succeeded in %d usecs\n", i);
  	} else {
-		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
+		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
  			  scratch, tmp);
  		r = -EINVAL;
  	}

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 8 lines · Christian König
Quoted 4 lines · Pavel Machek

Ring test failure is often caused by too high agpmode. Tell the user what to try.

NAK, the ring test can fail for any number of reasons and the agpmode is actually rather unlikely to be the cause.

Well, when I asked on the list "why this is happened" I got "umm, noone knows" response that was not exactly helpful. And then someone told me about agpmode.

If you know about the reasons it can fail, could you list them near the DRM_ERROR, at least as a comment?

Thanks,
Pavel

Quoted 18 lines

Regards,
Christian.

Quoted 15 lines
drivers/gpu/drm/radeon/r100.c +1 -1
index 238b13f..32b1917 100644
@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
 	if (i < rdev->usec_timeout) {
 		DRM_INFO("ring test succeeded in %d usecs\n", i);
 	} else {
-		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
+		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
 			  scratch, tmp);
 		r = -EINVAL;
 	}
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#3 lore raw
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Christian König
Quoted 4 lines · Pavel Machek

Ring test failure is often caused by too high agpmode. Tell the user what to try.

Quoted 8 lines
Quoted 2 lines

NAK, the ring test can fail for any number of reasons and the agpmode is actually rather unlikely to be the cause.

Well, when I asked on the list "why this is happened" I got "umm, noone knows" response that was not exactly helpful. And then someone told me about agpmode.

If you know about the reasons it can fail, could you list them near the DRM_ERROR, at least as a comment?

Well as I said, that could be any number of reasons. Some of them even completely unrelated to the driver itself.

E.g. BIOS setting, faulty hardware, problems with the writeback etc... There is really not a list you could give here.

Lowering the agpmode usually helps more to prevent random corruptions and problems under load.

Regards,
Christian.

Quoted 7 lines

Thanks,
Pavel

Quoted 3 lines

Regards,
Christian.

Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/radeon/r100.c +0 -0
index 238b13f..32b1917 100644
@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
  	if (i < rdev->usec_timeout) {
Quoted 8 lines

drivers/gpu/drm/radeon/r100.c int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring) · line 3671

Quoted 8 lines
drivers/gpu/drm/radeon/r100.c +1 -1
  		DRM_INFO("ring test succeeded in %d usecs\n", i);
  	} else {
-		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
+		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
  			  scratch, tmp);
  		r = -EINVAL;
  	}

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 16 lines · Christian König
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Christian König
Quoted 4 lines · Pavel Machek

Ring test failure is often caused by too high agpmode. Tell the user what to try.

Quoted 8 lines
Quoted 2 lines

NAK, the ring test can fail for any number of reasons and the agpmode is actually rather unlikely to be the cause.

Well, when I asked on the list "why this is happened" I got "umm, noone knows" response that was not exactly helpful. And then someone told me about agpmode.

If you know about the reasons it can fail, could you list them near the DRM_ERROR, at least as a comment?

Quoted 8 lines

Well as I said, that could be any number of reasons. Some of them even completely unrelated to the driver itself.

E.g. BIOS setting, faulty hardware, problems with the writeback etc... There is really not a list you could give here.

Lowering the agpmode usually helps more to prevent random corruptions and problems under load.

Take a look at

http://www.gossamer-threads.com/lists/linux/kernel/2197183

. I had a problem, you did not know how to debug it, but it already happened to pebolle at tiscali ... and yes, it was agpmode. That problem is clearly more common then you realize... So this should go in.

Pavel

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
drivers/gpu/drm/radeon/r100.c +1 -1
@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
 	if (i < rdev->usec_timeout) {
 		DRM_INFO("ring test succeeded in %d usecs\n", i);
 	} else {
-		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
+		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
 			  scratch, tmp);
 		r = -EINVAL;
 	}
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#5 lore raw
Quoted 26 lines · Pavel Machek
Quoted 16 lines · Christian König
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Christian König
Quoted 4 lines · Pavel Machek

Ring test failure is often caused by too high agpmode. Tell the user what to try.

Quoted 8 lines
Quoted 2 lines

NAK, the ring test can fail for any number of reasons and the agpmode is actually rather unlikely to be the cause.

Well, when I asked on the list "why this is happened" I got "umm, noone knows" response that was not exactly helpful. And then someone told me about agpmode.

If you know about the reasons it can fail, could you list them near the DRM_ERROR, at least as a comment?

Quoted 8 lines

Well as I said, that could be any number of reasons. Some of them even completely unrelated to the driver itself.

E.g. BIOS setting, faulty hardware, problems with the writeback etc... There is really not a list you could give here.

Lowering the agpmode usually helps more to prevent random corruptions and problems under load.

Quoted 8 lines

Take a look at

http://www.gossamer-threads.com/lists/linux/kernel/2197183

. I had a problem, you did not know how to debug it, but it already happened to pebolle at tiscali ... and yes, it was agpmode. That problem is clearly more common then you realize... So this should go in.

I agree with Christian, but at the very least, agpmode must not be mentioned if AGP isn't being used in the first place, i.e. either the GPU isn't AGP or is being forced to PCI(e) mode.

Signature · 2 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
maintainer
#6 lore raw
Quoted 29 lines · Michel Dänzer
Quoted 28 lines · Pavel Machek
Quoted 15 lines · Christian König
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Christian König
Quoted 4 lines · Pavel Machek

Ring test failure is often caused by too high agpmode. Tell the user what to try.

Quoted 8 lines
Quoted 2 lines

NAK, the ring test can fail for any number of reasons and the agpmode is actually rather unlikely to be the cause.

Well, when I asked on the list "why this is happened" I got "umm, noone knows" response that was not exactly helpful. And then someone told me about agpmode.

If you know about the reasons it can fail, could you list them near the DRM_ERROR, at least as a comment?

Quoted 8 lines

Well as I said, that could be any number of reasons. Some of them even completely unrelated to the driver itself.

E.g. BIOS setting, faulty hardware, problems with the writeback etc... There is really not a list you could give here.

Lowering the agpmode usually helps more to prevent random corruptions and problems under load.

Take a look at

http://www.gossamer-threads.com/lists/linux/kernel/2197183

Quoted 7 lines
Quoted 4 lines

. I had a problem, you did not know how to debug it, but it already happened to pebolle at tiscali ... and yes, it was agpmode. That problem is clearly more common then you realize... So this should go in.

I agree with Christian, but at the very least, agpmode must not be mentioned if AGP isn't being used in the first place, i.e. either the GPU isn't AGP or is being forced to PCI(e) mode.

Well maybe to explain the background, r100_ring_test() is used for a whole bunch of different hardware generations.

Most of them doesn't even have AGP, so mentioning this here would be even confusion for the majority of users.

Regards,
Christian.