Skip to contentSkip to conversation

imx: mx6: add missing return value

PATCH New Jeroen Hofstee 3 participants 4 messages Nov 29, 2015 – Dec 7, 2015 Arm (32-bit)

lore
Share & tools
lore

Jeroen Hofstee

author
#0 lore raw

PATCH 1/1 imx: mx6: add missing return value

cc Peng Fan <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

---
not tested ;)

 arch/arm/cpu/armv7/mx6/clock.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/cpu/armv7/mx6/clock.c +2 -0
index 67e0f32..4f6fe86 100644
@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
 	reg = readl(&imx_ccm->CCGR2);
 	reg |= MXC_CCM_CCGR2_LCD_MASK;
 	writel(reg, &imx_ccm->CCGR2);
+
+	return 0;
 }
 #endif
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 imx: mx6: add missing return value

Hi Jeroen,

Quoted 13 lines · Jeroen Hofstee
cc Peng Fan <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

---
not tested ;)

arch/arm/cpu/armv7/mx6/clock.c | 2 ++

1 file changed, 2 insertions(+)
arch/arm/cpu/armv7/mx6/clock.c +0 -0
index 67e0f32..4f6fe86 100644

arch/arm/cpu/armv7/mx6/clock.c int enable_lcdif_clock(u32 base_addr) · line 719

Quoted 5 lines
arch/arm/cpu/armv7/mx6/clock.c +2 -0
@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
 	reg = readl(&imx_ccm->CCGR2);
 	reg |= MXC_CCM_CCGR2_LCD_MASK;
 	writel(reg, &imx_ccm->CCGR2);
+
+	return 0;

I CCed i.MX branch maintainer for you.

Reviewed-by Peng Fan <[email protected]>

Regards,
Peng.

Quoted 6 lines
arch/arm/cpu/armv7/mx6/clock.c +0 -0
 }
 #endif
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 imx: mx6: add missing return value

Quoted 23 lines · Peng Fan

Hi Jeroen,

Quoted 13 lines · Jeroen Hofstee
cc Peng Fan <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

---
not tested ;)

arch/arm/cpu/armv7/mx6/clock.c | 2 ++

1 file changed, 2 insertions(+)
arch/arm/cpu/armv7/mx6/clock.c +0 -0
index 67e0f32..4f6fe86 100644

arch/arm/cpu/armv7/mx6/clock.c int enable_lcdif_clock(u32 base_addr) · line 719

Quoted 5 lines
arch/arm/cpu/armv7/mx6/clock.c +2 -0
@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
 	reg = readl(&imx_ccm->CCGR2);
 	reg |= MXC_CCM_CCGR2_LCD_MASK;
 	writel(reg, &imx_ccm->CCGR2);
+
+	return 0;

I CCed i.MX branch maintainer for you.

Quoted 2 lines
Reviewed-by Peng Fan <[email protected]>

Thanks.

Reviewed-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 imx: mx6: add missing return value

In reply to Peng Fan
Quoted 23 lines · Peng Fan

Hi Jeroen,

Quoted 13 lines · Jeroen Hofstee
cc Peng Fan <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

---
not tested ;)

arch/arm/cpu/armv7/mx6/clock.c | 2 ++

1 file changed, 2 insertions(+)
arch/arm/cpu/armv7/mx6/clock.c +0 -0
index 67e0f32..4f6fe86 100644

arch/arm/cpu/armv7/mx6/clock.c int enable_lcdif_clock(u32 base_addr) · line 719

Quoted 5 lines
arch/arm/cpu/armv7/mx6/clock.c +2 -0
@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
 	reg = readl(&imx_ccm->CCGR2);
 	reg |= MXC_CCM_CCGR2_LCD_MASK;
 	writel(reg, &imx_ccm->CCGR2);
+
+	return 0;

I CCed i.MX branch maintainer for you.

Quoted 2 lines
Reviewed-by Peng Fan <[email protected]>

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================