Skip to contentSkip to conversation

axs10x: add support of generic ECHI USB 2.0 controller

PATCH Superseded Alexey Brodkin 2 participants 5 messages Nov 30, 2015 – Dec 8, 2015 Synopsys ARC architecture

lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH v2 1/1 axs10x: add support of generic ECHI USB 2.0 controller

This commit adds support of USB 2.0 storage media on AXS10x boards.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>

---

Changes compared to v1:
* Explicitly enable CONFIG_USB_EHCI_GENERIC

 arch/arc/dts/axs10x.dts  | 6 ++++++
 configs/axs101_defconfig | 6 ++++++
 configs/axs103_defconfig | 6 ++++++
 3 files changed, 18 insertions(+)
arch/arc/dts/axs10x.dts +6 -0
index 8fe1837..80e6d6b 100644
@@ -42,4 +42,10 @@
 		clock-names = "stmmaceth";
 		max-speed = <100>;
 	};
+
+	ehci at 0xe0040000 {
+		compatible = "generic-ehci";
+		reg = < 0xe0040000 0x100 >;
+		interrupts = < 8 >;
+	};
 };
configs/axs101_defconfig +6 -0
index 52d5e2f..a541d9d 100644
@@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y

@@ -19,4 +20,9 @@ CONFIG_CLK=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
configs/axs103_defconfig +6 -0
index a7f3c38..3c65c83 100644
@@ -7,6 +7,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y

@@ -18,4 +19,9 @@ CONFIG_CLK=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
Signature · 1 line
2.5.0
#1 lore raw

PATCH v2 1/1 axs10x: add support of generic ECHI USB 2.0 controller

Quoted 6 lines · Alexey Brodkin

This commit adds support of USB 2.0 storage media on AXS10x boards.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>

---

Ad subject -- It's EHCI, not ECHI ;-)

[...]

Quoted 13 lines
configs/axs101_defconfig +1 -0
index 52d5e2f..a541d9d 100644
@@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y

configs/axs101_defconfig CONFIG_CLK=y · line 25

Quoted 6 lines
configs/axs101_defconfig +3 -0
@@ -19,4 +20,9 @@ CONFIG_CLK=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y

You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I think.

Quoted 16 lines
configs/axs101_defconfig +2 -0
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
configs/axs103_defconfig +1 -0
index a7f3c38..3c65c83 100644
@@ -7,6 +7,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y

configs/axs103_defconfig CONFIG_CLK=y · line 24

Quoted 6 lines
configs/axs103_defconfig +3 -0
@@ -18,4 +19,9 @@ CONFIG_CLK=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y

DTTO

Quoted 3 lines
configs/axs103_defconfig +2 -0
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
author
#2 lore raw

PATCH v2 1/1 axs10x: add support of generic ECHI USB 2.0 controller

Hi Marek,

Quoted 9 lines · Marek Vasut
Quoted 6 lines · Alexey Brodkin

This commit adds support of USB 2.0 storage media on AXS10x boards.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>

---

Ad subject -- It's EHCI, not ECHI ;-)

Good catch!

Quoted 14 lines
Quoted 14 lines
configs/axs101_defconfig +1 -0
index 52d5e2f..a541d9d 100644
@@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y

@@ -19,4 +20,9 @@ CONFIG_CLK=y
Quoted 8 lines

configs/axs101_defconfig CONFIG_CLK=y · line 25

Quoted 6 lines
configs/axs101_defconfig +3 -0
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y

You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I think.

Yeah but remember in drivers/usb/host it's not a dependency but conditional branch. That's why "savedefconfig" (but not me really) put EHCI_HCD here.

-Alexey

#3 lore raw

PATCH v2 1/1 axs10x: add support of generic ECHI USB 2.0 controller

Quoted 1 line · Alexey Brodkin

Hi Marek,

Hi!

Quoted 42 lines · Marek Vasut
Quoted 9 lines · Alexey Brodkin
Quoted 6 lines

This commit adds support of USB 2.0 storage media on AXS10x boards.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>

---

Ad subject -- It's EHCI, not ECHI ;-)

Good catch!

Quoted 22 lines
Quoted 22 lines
configs/axs101_defconfig +1 -0
index 52d5e2f..a541d9d 100644
@@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 
+CONFIG_CMD_USB=y

# CONFIG_CMD_SETEXPR is not set
CONFIG_CMD_DHCP=y
CONFIG_CMD_PING=y

configs/axs101_defconfig +0 -0
@@ -19,4 +20,9 @@ CONFIG_CLK=y
 
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
Quoted 6 lines

configs/axs101_defconfig CONFIG_CLK=y · line 25

Quoted 3 lines
configs/axs101_defconfig +3 -0
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y

You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I think.

Quoted 2 lines

Yeah but remember in drivers/usb/host it's not a dependency but conditional branch. That's why "savedefconfig" (but not me really) put EHCI_HCD here.

Right, got it.

Best regards,
Marek Vasut

author
#4 lore raw

PATCH v2 1/1 axs10x: add support of generic ECHI USB 2.0 controller

Hi Alexey,

Quoted 47 lines · Marek Vasut
Quoted 1 line · Alexey Brodkin

Hi Marek,

Hi!

Quoted 42 lines · Marek Vasut
Quoted 9 lines · Alexey Brodkin
Quoted 6 lines

This commit adds support of USB 2.0 storage media on AXS10x boards.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>

---

Ad subject -- It's EHCI, not ECHI ;-)

Good catch!

Quoted 28 lines
Quoted 17 lines
configs/axs101_defconfig +1 -0
index 52d5e2f..a541d9d 100644
@@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
 
 CONFIG_SYS_PROMPT="AXS# "
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 
+CONFIG_CMD_USB=y

# CONFIG_CMD_SETEXPR is not set
CONFIG_CMD_DHCP=y
CONFIG_CMD_PING=y

configs/axs101_defconfig CONFIG_CLK=y · line 25

Quoted 8 lines
configs/axs101_defconfig +3 -0
@@ -19,4 +20,9 @@ CONFIG_CLK=y
 
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
 
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y

You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I think.

Quoted 4 lines
Quoted 2 lines

Yeah but remember in drivers/usb/host it's not a dependency but conditional branch. That's why "savedefconfig" (but not me really) put EHCI_HCD here.

Right, got it.

Applied to U-Boot-ARC, thanks!

-Alexey