Skip to contentSkip to conversation

clk: imx: Replace clk error check with imx_check_clocks()

PATCH New Bai Ping 3 participants 3 messages Nov 26, 2015 – Dec 2, 2015

Subsystems (3)
Arm i.MX and Layerscape Common clk NXP i.MX clock drivers
lore
Share & tools
lore

Bai Ping

author
#0 lore raw

PATCH 1/1 clk: imx: Replace clk error check with imx_check_clocks()

As we already have a 'imx_check_clocks' to do the clock error check, so cleanup the error check code.

Signed-off-by Bai Ping <[email protected]>
---
 drivers/clk/imx/clk-imx6ul.c | 4 +---
 drivers/clk/imx/clk-imx7d.c  | 5 +----
 2 files changed, 2 insertions(+), 7 deletions(-)
drivers/clk/imx/clk-imx6ul.c +1 -3
index 01718d0..08692d7 100644
@@ -399,9 +399,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
 	/* mask handshake of mmdc */
 	writel_relaxed(BM_CCM_CCDR_MMDC_CH0_MASK, base + CCDR);
 
-	for (i = 0; i < ARRAY_SIZE(clks); i++)
-		if (IS_ERR(clks[i]))
-			pr_err("i.MX6UL clk %d: register failed with %ld\n", i, PTR_ERR(clks[i]));
+	imx_check_clocks(clks, ARRAY_SIZE(clks));
 
 	clk_data.clks = clks;
 	clk_data.clk_num = ARRAY_SIZE(clks);
drivers/clk/imx/clk-imx7d.c +1 -4
index 581b428..fbb6a8c 100644
@@ -839,10 +839,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
 					 clks[IMX7D_PLL_ARM_MAIN_CLK],
 					 clks[IMX7D_PLL_SYS_MAIN_CLK]);
 
-	for (i = 0; i < ARRAY_SIZE(clks); i++)
-		if (IS_ERR(clks[i]))
-			pr_err("i.MX7D clk %d: register failed with %ld\n",
-					i, PTR_ERR(clks[i]));
+	imx_check_clocks(clks, ARRAY_SIZE(clks));
 
 	clk_data.clks = clks;
 	clk_data.clk_num = ARRAY_SIZE(clks);
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 clk: imx: Replace clk error check with imx_check_clocks()

Quoted 5 lines · Bai Ping

As we already have a 'imx_check_clocks' to do the clock error check, so cleanup the error check code.

Signed-off-by Bai Ping <[email protected]>

---

Acked-by Stephen Boyd <[email protected]>
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project