Skip to contentSkip to conversation

pinctrl: freescale: add ZERO_OFFSET_VALID flag for vf610 pinctrl

PATCH New Shawn Guo 2 participants 3 messages Nov 25, 2015 – Dec 10, 2015

Subsystems (2)
lore
Share & tools
lore

Shawn Guo

author
#0 lore raw

PATCH 1/1 pinctrl: freescale: add ZERO_OFFSET_VALID flag for vf610 pinctrl

To support i.MX7D Low Power State Retention IOMUXC, commit e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero") changes the way of zero mux_reg offset support with a new flag ZERO_OFFSET_VALID. But, unfortunately, it forgot to add this flag for vf610 pinctrl which has zero mux_reg offset be valid as well, and hence breaks the vf610 support.

Fix the regression by adding flag ZERO_OFFSET_VALID for vf610 pinctrl driver.

Fixes e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero")
---
 drivers/pinctrl/freescale/pinctrl-vf610.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/freescale/pinctrl-vf610.c +1 -1
index 37a037543d29..587d1ff6210e 100644
@@ -299,7 +299,7 @@ static const struct pinctrl_pin_desc vf610_pinctrl_pads[] = {
 static struct imx_pinctrl_soc_info vf610_pinctrl_info = {
 	.pins = vf610_pinctrl_pads,
 	.npins = ARRAY_SIZE(vf610_pinctrl_pads),
-	.flags = SHARE_MUX_CONF_REG,
+	.flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
 };
 
 static const struct of_device_id vf610_pinctrl_of_match[] = {
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 pinctrl: freescale: add ZERO_OFFSET_VALID flag for vf610 pinctrl

Quoted 7 lines · Shawn Guo

To support i.MX7D Low Power State Retention IOMUXC, commit e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero") changes the way of zero mux_reg offset support with a new flag ZERO_OFFSET_VALID. But, unfortunately, it forgot to add this flag for vf610 pinctrl which has zero mux_reg offset be valid as well, and hence breaks the vf610 support.

Quoted 8 lines

Fix the regression by adding flag ZERO_OFFSET_VALID for vf610 pinctrl driver.

Fixes e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero")

Linus,

Can you help apply the fix for v4.4-rc?

Shawn

Quoted 21 lines
---
 drivers/pinctrl/freescale/pinctrl-vf610.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/freescale/pinctrl-vf610.c +1 -1
index 37a037543d29..587d1ff6210e 100644
@@ -299,7 +299,7 @@ static const struct pinctrl_pin_desc vf610_pinctrl_pads[] = {
 static struct imx_pinctrl_soc_info vf610_pinctrl_info = {
 	.pins = vf610_pinctrl_pads,
 	.npins = ARRAY_SIZE(vf610_pinctrl_pads),
-	.flags = SHARE_MUX_CONF_REG,
+	.flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
 };
 
 static const struct of_device_id vf610_pinctrl_of_match[] = {
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 pinctrl: freescale: add ZERO_OFFSET_VALID flag for vf610 pinctrl

In reply to Shawn Guo
Quoted 7 lines · Shawn Guo

To support i.MX7D Low Power State Retention IOMUXC, commit e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero") changes the way of zero mux_reg offset support with a new flag ZERO_OFFSET_VALID. But, unfortunately, it forgot to add this flag for vf610 pinctrl which has zero mux_reg offset be valid as well, and hence breaks the vf610 support.

Quoted 8 lines

Fix the regression by adding flag ZERO_OFFSET_VALID for vf610 pinctrl driver.

Fixes e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero")

Patch applied for fixes.

Sorry for the delay.

Yours,
Linus Walleij