Skip to contentSkip to conversation

sunxi: usb: Rename the sunxi usb driver DM entry

PATCH New Marek Vasut 2 participants 3 messages Nov 30, 2015 – Dec 1, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: usb: Rename the sunxi usb driver DM entry

The DM entry should be unique, otherwise it will collide with other drivers. Fix this by assigning the driver a more unique name than usb_ehci.

Cc Hans de Goede <[email protected]>
Cc Ian Campbell <[email protected]>
Cc Simon Glass <[email protected]>
---
 drivers/usb/host/ehci-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-sunxi.c +1 -1
index 38d5f92..d494ca1 100644
@@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
 	{ }
 };
 
-U_BOOT_DRIVER(usb_ehci) = {
+U_BOOT_DRIVER(ehci_sunxi) = {
 	.name	= "ehci_sunxi",
 	.id	= UCLASS_USB,
 	.of_match = ehci_usb_ids,
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 sunxi: usb: Rename the sunxi usb driver DM entry

Hi,

Quoted 8 lines · Marek Vasut

The DM entry should be unique, otherwise it will collide with other drivers. Fix this by assigning the driver a more unique name than usb_ehci.

Cc Hans de Goede <[email protected]>
Cc Ian Campbell <[email protected]>
Cc Simon Glass <[email protected]>

Looks good to me:

Marek, do you want me to take this upstream through the u-boot-sunxi tree, or will you pick this up yourself ?

Regards,

Hans

Quoted 18 lines
---
  drivers/usb/host/ehci-sunxi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-sunxi.c +1 -1
index 38d5f92..d494ca1 100644
@@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
  	{ }
  };
 
-U_BOOT_DRIVER(usb_ehci) = {
+U_BOOT_DRIVER(ehci_sunxi) = {
  	.name	= "ehci_sunxi",
  	.id	= UCLASS_USB,
  	.of_match = ehci_usb_ids,
#2 lore raw

PATCH 1/1 sunxi: usb: Rename the sunxi usb driver DM entry

Quoted 12 lines · Hans de Goede

Hi,

Quoted 8 lines · Marek Vasut

The DM entry should be unique, otherwise it will collide with other drivers. Fix this by assigning the driver a more unique name than usb_ehci.

Cc Hans de Goede <[email protected]>
Cc Ian Campbell <[email protected]>
Cc Simon Glass <[email protected]>
Quoted 6 lines

Looks good to me:

Marek, do you want me to take this upstream through the u-boot-sunxi tree, or will you pick this up yourself ?

I'll pick it through the USB at it fixes build issue there. Thanks!

Best regards,
Marek Vasut