Skip to contentSkip to conversation

manual: clarify policy when updating a package patch

PATCH Superseded Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Dec 1, 2015 – Dec 2, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 manual: clarify policy when updating a package patch

---
 docs/manual/patch-policy.txt | 4 ++++
 1 file changed, 4 insertions(+)
docs/manual/patch-policy.txt +4 -0
index 6e27e71..bb859bd 100644
@@ -106,6 +106,10 @@ upstream SCM software to generate the patch set.
 Otherwise, concatenate the header with the output of the
 +diff -purN package-version.orig/ package-version/+ command.
 
+If you update an existing patch (e.g. when bumping the package version),
+make sure the original author and existing Signed-off-by tags are not
+removed.
+
 At the end, the patch should look like:
 
 ---------------
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 manual: clarify policy when updating a package patch

Hi Arnout,

Quoted 11 lines · Arnout Vandecappelle (Essensium/Mind)
---
 docs/manual/patch-policy.txt | 4 ++++
 1 file changed, 4 insertions(+)
docs/manual/patch-policy.txt +0 -0
index 6e27e71..bb859bd 100644

docs/manual/patch-policy.txt upstream SCM software to generate the patch set. · line 111

Quoted 6 lines
docs/manual/patch-policy.txt +3 -0
@@ -106,6 +106,10 @@ upstream SCM software to generate the patch set.
 Otherwise, concatenate the header with the output of the
 +diff -purN package-version.orig/ package-version/+ command.
 
+If you update an existing patch (e.g. when bumping the package version),
+make sure the original author and existing Signed-off-by tags are not
+removed.

Since not all patches we carry have an author (From:) header this text might be a little confusing. Maybe:

... make sure the original author (the 'From:' header, when the patch has one) and existing Signed-off-by ...

It maybe also be worth a mention that not all existing patches have a sign-off tag.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -