ARM: DTS: LS1021A: add SATA node to DTS
PATCH v2 1/1 ARM: DTS: LS1021A: add SATA node to DTS
From: Tang Yuantian <[email protected]>
Added SATA node to LS1021A DTS to support SATA function.
Signed-off-by Tang Yuantian <[email protected]>
---
v2:
- put reg-names right after reg property
arch/arm/boot/dts/ls1021a.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/ls1021a.dtsi +10 -0
@@ -143,6 +143,16 @@ status = "disabled"; }; + sata: sata at 3200000 { + compatible = "fsl,ls1021a-ahci"; + reg = <0x0 0x3200000 0x0 0x10000>, + <0x0 0x20220520 0x0 0x4>; + reg-names = "ahci", "sata-ecc"; + interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&platform_clk 1>; + dma-coherent; + }; + scfg: scfg at 1570000 { compatible = "fsl,ls1021a-scfg", "syscon"; reg = <0x0 0x1570000 0x0 0x10000>;
Signature · 1 line
2.1.0.27.g96db324
PATCH v2 1/1 ARM: DTS: LS1021A: add SATA node to DTS
Quoted 5 lines · Yuantian.Tang at freescale.com
From: Tang Yuantian <[email protected]>
Added SATA node to LS1021A DTS to support SATA function.
Signed-off-by Tang Yuantian <[email protected]>
I think 'ARM: dts: ls1021a: ...' is a more idiomatic patch prefix for your patch.
Quoted 14 lines
---
v2:
- put reg-names right after reg propertyarch/arm/boot/dts/ls1021a.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/ls1021a.dtsi +0
-0@@ -143,6 +143,16 @@ status = "disabled"; };
arch/arm/boot/dts/ls1021a.dtsi line 154
Quoted 10 lines
arch/arm/boot/dts/ls1021a.dtsi +9
-0+ sata: sata at 3200000 { + compatible = "fsl,ls1021a-ahci"; + reg = <0x0 0x3200000 0x0 0x10000>, + <0x0 0x20220520 0x0 0x4>; + reg-names = "ahci", "sata-ecc"; + interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&platform_clk 1>; + dma-coherent; + };
Shouldn't it have the line below to get the device disabled in <soc>.dtsi by default, and let <board>.dts that has sata support to enable it?
status = "disabled";
Shawn
Quoted 8 lines
arch/arm/boot/dts/ls1021a.dtsi +1
-0+ scfg: scfg at 1570000 { compatible = "fsl,ls1021a-scfg", "syscon"; reg = <0x0 0x1570000 0x0 0x10000>;Signature · 1 line
2.1.0.27.g96db324