objdiff usage
Hi all,
I am looking for a guidance on ./scripts/objdiff usage, cant seem to find a goot example of the scenario where you for example make a bunch of changes (code style issues) in one folder and need to check if that?changes don't change the object file. That can speed up code cleaning quite a bi but all I found online are patches related to objdiff.
?
Thanks,Sasa
Hi Sasa,
Quoted 9 lines · Bogicevic Sasa
Hi all,
I am looking for a guidance on./scripts/objdiffusage, cant seem to find a goot example of the scenario where you for example make a bunch of changes (code style issues) in one folder and need to check if that?changes don't change the object file. That can speed up code cleaning quite a bi but all I found online are patches related to objdiff.?Thanks,Sasa
Example usage link can be fund in the objdiff commit thread:
https://lkml.org/lkml/2014/4/7/312
Regards,
Bojan
Quoted 14 lines · bojan prtvar
Hi Sasa,
Quoted 9 lines · Bogicevic Sasa
Hi all,
I am looking for a guidance on./scripts/objdiffusage, cant seem to find a goot example of the scenario where you for example make a bunch of changes (code style issues) in one folder and need to check if that?changes don't change the object file. That can speed up code cleaning quite a bi but all I found online are patches related to objdiff.?Thanks,Sasa
Quoted 5 lines
Example usage link can be fund in the objdiff commit thread:
https://lkml.org/lkml/2014/4/7/312Regards,
Bojan
Hvala Bojane :)
Thanks Bojan,
What about the case where you dont have object files to compare ? For example driver/pci/hotplug in my case ? How do you prove that your changes didn't brake something ?
Thanks, Sasa
{
name: Sasa Bogicevic
phone: +381:606006200
}Quoted 3 lines
What about the case where you dont have object files to compare ? For example driver/pci/hotplug in my case ? How do you prove that your changes didn't brake something ?
What do you mean by no object files in driver/pci/hotplug ? Is your HOTPLUG_PCI defined?
Bojan
Quoted 9 lines · bojan prtvar
Quoted 3 lines
What about the case where you dont have object files to compare ? For example driver/pci/hotplug in my case ? How do you prove that your changes didn't brake something ?
What do you mean by no object files in driver/pci/hotplug ? Is your
HOTPLUG_PCIdefined?Bojan
Well, when I pull staging tree and go to drivers/pci/hotplug I get c and h files. Am I supposed to first compile the kernel make changes and compile again to be anle to compare ?
Signature · 4 lines
{
name: Sasa Bogicevic
phone: +381606006200
}Quoted 3 lines · Bogicevic Sasa
Well, when I pull staging tree and go to
drivers/pci/hotplugI get c and h files. Am I supposed to first compile the kernel make changes and compile again to be anle to compare ?
Something like that. Take a look to the script itself, the usage example should be quite clear
+# usage example:
+#
+# $ git checkout COMMIT_A
+# $ <your fancy build command here>
+# $ ./scripts/objdiff record path/to/*.o
+#
+# $ git checkout COMMIT_B
+# $ <your fancy build command here>
+# $ ./scripts/objdiff record path/to/*.o
+#
+# $ ./scripts/objdiff diff COMMIT_A COMMIT_B
+# $
Regards,
Bojan
Quoted 23 lines · bojan prtvar
Quoted 3 lines · Bogicevic Sasa
Well, when I pull staging tree and go to
drivers/pci/hotplugI get c and h files. Am I supposed to first compile the kernel make changes and compile again to be anle to compare ?Something like that. Take a look to the script itself, the usage example should be quite clear
(quoted diff) +12
-0+# usage example: +# +# $ git checkout COMMIT_A +# $ <your fancy build command here> +# $ ./scripts/objdiff record path/to/*.o +# +# $ git checkout COMMIT_B +# $ <your fancy build command here> +# $ ./scripts/objdiff record path/to/*.o +# +# $ ./scripts/objdiff diff COMMIT_A COMMIT_B +# $
Quoted 2 lines
Regards,
Bojan
Ahhh all clear now, thanks a lot!
Sasa
{
name: Sasa Bogicevic
phone: +381606006200
}