Skip to contentSkip to conversation

vhost: don't send RESET_OWNER at stop]

PATCH New Michael S. Tsirkin 1 participant 1 message Dec 2, 2015

lore
Share & tools
lore

Michael S. Tsirkin

author
#0 lore raw

PATCH 2/2 vhost: don't send RESET_OWNER at stop]

Cc [email protected] as this fixes some clients.

----- Forwarded message from Yuanhan Liu <[email protected]> -----

Date: Fri, 13 Nov 2015 15:24:10 +0800
From: Yuanhan Liu <[email protected]>
To: [email protected]
Cc: [email protected], Yuanhan Liu <[email protected]>
Subject: [PATCH 2/2] vhost: don't send RESET_OWNER at stop
Message-Id: <[email protected]>
In-Reply-To: <[email protected]>

First of all, RESET_OWNER message is sent incorrectly, as it's sent before GET_VRING_BASE. And the reset message would let the later call get nothing correct.

And, sending SET_VRING_ENABLE at stop, which has already been done, makes more sense than RESET_OWNER.

Signed-off-by Yuanhan Liu <[email protected]>
---
 hw/net/vhost_net.c | 6 ------
 1 file changed, 6 deletions(-)
hw/net/vhost_net.c +0 -6
index d91b7b1..14337a4 100644
@@ -292,12 +292,6 @@ static void vhost_net_stop_one(struct vhost_net *net,
             int r = vhost_ops->vhost_net_set_backend(&net->dev, &file);
             assert(r >= 0);
         }
-    } else if (net->nc->info->type == NET_CLIENT_OPTIONS_KIND_VHOST_USER) {
-        for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
-            const VhostOps *vhost_ops = net->dev.vhost_ops;
-            int r = vhost_ops->vhost_reset_device(&net->dev);
-            assert(r >= 0);
-        }
     }
     if (net->nc->info->poll) {
         net->nc->info->poll(net->nc, true);
Signature · 3 lines
1.9.3

----- End forwarded message -----