Skip to contentSkip to conversation

mm:Correctly update number of rotated pages on active list.

PATCH In review Pradeep Goswami (Pradeep Kumar Goswami) 2 participants 3 messages Dec 3, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm:Correctly update number of rotated pages on active list.

This patch corrects the number of pages which are rotated on active list. The counter for rotated pages effects the number of pages
to be scanned on active pages list in low memory situations.

Cc Rebecca Schultz Zavin <[email protected]>
Cc Vladimir Davydov <[email protected]>
Cc Andrew Morton <[email protected]>

---

mm/vmscan.c 2015-11-19 14:37:31.189838998 +0800 renamed from mm/vmscan.c 2015-11-18 20:55:38.208838142 +0800 +1 -1
@@ -1806,7 +1806,6 @@ static void shrink_active_list(unsigned
 
                if (page_referenced(page, 0, sc->target_mem_cgroup,
                                    &vm_flags)) {
-                       nr_rotated += hpage_nr_pages(page);
                        /*  
                         * Identify referenced, file-backed active pages and 
                         * give them one more trip around the active list. So
@@ -1818,6 +1817,7 @@ static void shrink_active_list(unsigned
                         */  
                        if ((vm_flags & VM_EXEC) && page_is_file_cache(page)) {
                                list_add(&page->lru, &l_active);
+                               nr_rotated += hpage_nr_pages(page);
                                continue;
                        }   
                }   

Thanks,
Pradeep.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

reviewer
#1 lore raw
Quoted 3 lines · Pradeep Goswami (Pradeep Kumar Goswami)

This patch corrects the number of pages which are rotated on active list. The counter for rotated pages effects the number of pages
to be scanned on active pages list in low memory situations.

Why this should be changed?

This seems to be deliberate:
/*
* Count referenced pages from currently used mappings as rotated,
* even though only some of them are actually re-activated. This
* helps balance scan pressure between file and anonymous pages in
* get_scan_count.
*/
reclaim_stat->recent_rotated[file] += nr_rotated;

What kind of problem are you trying to fix?

Quoted 32 lines
Cc Rebecca Schultz Zavin <[email protected]>
Cc Vladimir Davydov <[email protected]>
Cc Andrew Morton <[email protected]>

---

mm/vmscan.c 2015-11-19 14:37:31.189838998 +0800 renamed from mm/vmscan.c 2015-11-18 20:55:38.208838142 +0800 +1 -1
@@ -1806,7 +1806,6 @@ static void shrink_active_list(unsigned
 
                if (page_referenced(page, 0, sc->target_mem_cgroup,
                                    &vm_flags)) {
-                       nr_rotated += hpage_nr_pages(page);
                        /*  
                         * Identify referenced, file-backed active pages and 
                         * give them one more trip around the active list. So
@@ -1818,6 +1817,7 @@ static void shrink_active_list(unsigned
                         */  
                        if ((vm_flags & VM_EXEC) && page_is_file_cache(page)) {
                                list_add(&page->lru, &l_active);
+                               nr_rotated += hpage_nr_pages(page);
                                continue;
                        }   
                }   

Thanks,
Pradeep.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Signature · 8 lines
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#2 lore raw
Quoted 16 lines · Michal Hocko
Quoted 3 lines · Pradeep Goswami (Pradeep Kumar Goswami)

This patch corrects the number of pages which are rotated on active list. The counter for rotated pages effects the number of pages
to be scanned on active pages list in low memory situations.

Why this should be changed?

This seems to be deliberate:
/*
* Count referenced pages from currently used mappings as rotated,
* even though only some of them are actually re-activated. This
* helps balance scan pressure between file and anonymous pages in
* get_scan_count.
*/
reclaim_stat->recent_rotated[file] += nr_rotated;

Quoted 1 line

What kind of problem are you trying to fix?

Actually the numeber of pages which are actually rotated are wrongly updated, So I thought this might be minor coding error but as pointed out above, this seems to be deliberate. Thanks for clarifying.

Quoted 37 lines
Quoted 33 lines
Cc Rebecca Schultz Zavin <[email protected]>
Cc Vladimir Davydov <[email protected]>
Cc Andrew Morton <[email protected]>

---

mm/vmscan.c 2015-11-19 14:37:31.189838998 +0800 renamed from mm/vmscan.c 2015-11-18 20:55:38.208838142 +0800 +1 -1
@@ -1806,7 +1806,6 @@ static void shrink_active_list(unsigned
 
                if (page_referenced(page, 0, sc->target_mem_cgroup,
                                    &vm_flags)) {
-                       nr_rotated += hpage_nr_pages(page);
                        /*  
                         * Identify referenced, file-backed active pages and 
                         * give them one more trip around the active list. So
@@ -1818,6 +1817,7 @@ static void shrink_active_list(unsigned
                         */  
                        if ((vm_flags & VM_EXEC) && page_is_file_cache(page)) {
                                list_add(&page->lru, &l_active);
+                               nr_rotated += hpage_nr_pages(page);
                                continue;
                        }   
                }   

Thanks,
Pradeep.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Signature · 2 lines
Michal Hocko
SUSE Labs