iocon: Disable FIT_VERBOSE
PATCH 1/1 iocon: Disable FIT_VERBOSE
In order to fit into image constraints again, remove this feature.
--- configs/iocon_defconfig | 1 + include/configs/iocon.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)
configs/iocon_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_PPC=y CONFIG_4xx=y CONFIG_TARGET_IOCON=y +CONFIG_FIT=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_STOP_STR=" " # CONFIG_CMD_ELF is not set
include/configs/iocon.h +0 -2
@@ -35,8 +35,6 @@#undef CONFIG_ZERO_BOOTDELAY_CHECK/* ignore keypress on bootdelay==0 */ /* new uImage format support */ -#define CONFIG_FIT -#define CONFIG_FIT_VERBOSE /* enable fit_format_{error,warning}() */ #define CONFIG_FIT_DISABLE_SHA256 #define CONFIG_ENV_IS_IN_FLASH /* use FLASH for environment vars */
Signature · 1 line
1.7.9.5
PATCH 1/1 iocon: Disable FIT_VERBOSE
Quoted 3 lines · Tom Rini
In order to fit into image constraints again, remove this feature.
Signed-off-by Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151201/61e66fe3/attachment.sig>
Dirk Eibach
NAKPATCH 1/1 iocon: Disable FIT_VERBOSE
In reply to Tom RiniHi Tom,
2015-12-01 21:50 GMT+01:00 Tom Rini <[email protected]>:
Quoted 34 lines
In order to fit into image constraints again, remove this feature.
Signed-off-by Tom Rini <[email protected]>--- configs/iocon_defconfig | 1 + include/configs/iocon.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)configs/iocon_defconfig +1
-0@@ -1,6 +1,7 @@ CONFIG_PPC=y CONFIG_4xx=y CONFIG_TARGET_IOCON=y +CONFIG_FIT=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_STOP_STR=" " # CONFIG_CMD_ELF is not setinclude/configs/iocon.h +0
-3@@ -35,8 +35,6 @@#undef CONFIG_ZERO_BOOTDELAY_CHECK/* ignore keypress on bootdelay==0 */ /* new uImage format support */ -#define CONFIG_FIT -#define CONFIG_FIT_VERBOSE /* enable fit_format_{error,warning}() */ #define CONFIG_FIT_DISABLE_SHA256 #define CONFIG_ENV_IS_IN_FLASH /* use FLASH for environment vars */ --
Quoted 1 line
1.7.9.5
NAK.CONFIG_FIT is an essential feature for this board.
It is unnerving to find our older PPC boards failing to compile because of size constraints after every new release. We are slowly running out of features to cut. Maybe we have a bloat problem here? I will have a look where we could squeeze out some bytes. I would hate to drop support for boards that are still in production :(
BTW is there a specific reason there was no CC to the board maintainer?
Cheers
Dirk
PATCH 1/1 iocon: Disable FIT_VERBOSE
Quoted 35 lines · Dirk Eibach
Hi Tom,
2015-12-01 21:50 GMT+01:00 Tom Rini <[email protected]>:
Quoted 32 lines
In order to fit into image constraints again, remove this feature.
Signed-off-by Tom Rini <[email protected]>--- configs/iocon_defconfig | 1 + include/configs/iocon.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)configs/iocon_defconfig +1
-0@@ -1,6 +1,7 @@ CONFIG_PPC=y CONFIG_4xx=y CONFIG_TARGET_IOCON=y +CONFIG_FIT=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_STOP_STR=" " # CONFIG_CMD_ELF is not setinclude/configs/iocon.h +0
-2@@ -35,8 +35,6 @@#undef CONFIG_ZERO_BOOTDELAY_CHECK/* ignore keypress on bootdelay==0 */ /* new uImage format support */ -#define CONFIG_FIT -#define CONFIG_FIT_VERBOSE /* enable fit_format_{error,warning}() */ #define CONFIG_FIT_DISABLE_SHA256
Quoted 6 lines
Quoted 3 lines
include/configs/iocon.h +0
-1#define CONFIG_ENV_IS_IN_FLASH /* use FLASH for environment vars */ --1.7.9.5
NAK.
CONFIG_FITis an essential feature for this board.
FIT is enabled (and migrated to the config file), FIT_VERBOSE is removed.
Quoted 5 lines
It is unnerving to find our older PPC boards failing to compile because of size constraints after every new release. We are slowly running out of features to cut. Maybe we have a bloat problem here? I will have a look where we could squeeze out some bytes. I would hate to drop support for boards that are still in production :(
It's also, potentially, toolchain related. I only saw this with I think gcc 5.2.
Quoted 1 line
BTW is there a specific reason there was no CC to the board maintainer?
Only because I forgot, sorry!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151203/dbd46eec/attachment.sig>
PATCH 1/1 iocon: Disable FIT_VERBOSE
Hi Tom,
2015-12-03 13:19 GMT+01:00 Tom Rini <[email protected]>:
Quoted 43 lines · Dirk Eibach
Quoted 35 lines
Hi Tom,
2015-12-01 21:50 GMT+01:00 Tom Rini <[email protected]>:
Quoted 32 lines
In order to fit into image constraints again, remove this feature.
Signed-off-by Tom Rini <[email protected]>--- configs/iocon_defconfig | 1 + include/configs/iocon.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)configs/iocon_defconfig +1
-0@@ -1,6 +1,7 @@ CONFIG_PPC=y CONFIG_4xx=y CONFIG_TARGET_IOCON=y +CONFIG_FIT=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_STOP_STR=" " # CONFIG_CMD_ELF is not setinclude/configs/iocon.h +0
-2@@ -35,8 +35,6 @@#undef CONFIG_ZERO_BOOTDELAY_CHECK/* ignore keypress on bootdelay==0 */ /* new uImage format support */ -#define CONFIG_FIT -#define CONFIG_FIT_VERBOSE /* enable fit_format_{error,warning}() */ #define CONFIG_FIT_DISABLE_SHA256 Quoted 6 lines
Quoted 3 lines
include/configs/iocon.h +0
-1#define CONFIG_ENV_IS_IN_FLASH /* use FLASH for environment vars */ --1.7.9.5
NAK.
CONFIG_FITis an essential feature for this board.
Quoted 2 lines
FIT is enabled (and migrated to the config file),
FIT_VERBOSEis removed.
Ooops. Sorry for the noise. So:
Cheers
Dirk