ixgbe: do not call check_link for ethtool in ixgbe_get_settings()
Subsystems (2)
PATCH 1/1 ixgbe: do not call check_link for ethtool in ixgbe_get_settings()
In ixgbe_get_settings() the link status and speed of the interface are determined based on a read from the LINKS register via the call to mac.ops.check.link(). This can cause issues where external drivers may end up with unknown speed when calling ethtool_get_setings().
Instead of calling the mac.ops.check_link() we can report the speed from the adapter structure which is populated by the driver.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +2 -5
@@ -185,9 +185,7 @@ static int ixgbe_get_settings(struct net_device *netdev,struct ixgbe_adapter *adapter =netdev_priv (netdev);struct ixgbe_hw *hw = &adapter->hw;ixgbe_link_speed supported_link; -u32 link_speed =0 ;bool autoneg = false; -bool link_up; hw->mac.ops.get_link_capabilities (hw, &supported_link, &autoneg);
@@ -313,9 +311,8 @@ static int ixgbe_get_settings(struct net_device *netdev,break ; } - hw->mac.ops.check_link (hw, &link_speed, &link_up, false); -if (link_up) { -switch (link_speed) { +if (netif_carrier_ok (netdev)) { +switch (adapter->link_speed) {case IXGBE_LINK_SPEED_10GB_FULL :ethtool_cmd_speed_set (ecmd,SPEED_10000 );break ;
Schmitt
PATCH 1/1 ixgbe: do not call check_link for ethtool in ixgbe_get_settings()
Quoted 14 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Emil Tantilov
Sent: Thursday, December 03, 2015 3:20 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: do not callcheck_linkfor ethtool inixgbe_get_settings()In
ixgbe_get_settings()the link status and speed of the interface are determined based on a read from the LINKS register via the call tomac.ops.check.link(). This can cause issues where external drivers may end up with unknown speed when callingethtool_get_setings().
Quoted 5 lines
Instead of calling the
mac.ops.check_link()we can report the speed from the adapter structure which is populated by the driver.Signed-off-by Emil Tantilov <[email protected]>---