x86/mm/ptdump: Make (debugfs)/kernel_page_tables read-only
Borislav Petkov
maintainerPATCH 1/1 x86/mm/ptdump: Make (debugfs)/kernel_page_tables read-only
From: Borislav Petkov <[email protected]>
File should be created with S_IRUSR and not with S_IWUSR too because writing to it doesn't make any sense. I mean, we don't have a ->write method anyway but let's have the permissions correct too.
--- arch/x86/mm/debug_pagetables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/mm/debug_pagetables.c +1 -1
@@ -26,7 +26,7 @@ static struct dentry *pe;static int __init pt_dump_debug_init (void ) { - pe =debugfs_create_file ("kernel_page_tables" ,0600 ,NULL ,NULL , + pe =debugfs_create_file ("kernel_page_tables" ,S_IRUSR ,NULL ,NULL , &ptdump_fops);if (!pe)return -ENOMEM ;
Signature · 1 line
2.3.5
tip-bot for Borislav Petkov
merge bot[tip:x86/mm] x86/mm/ptdump: Make (debugfs)/ kernel_page_tables read-only
x86/mm/ptdump: Make (debugfs)/kernel_page_tables read-only
Commit-ID: 071ac0c4e8e90d5de05f0779b03ae69ce84820d5 Gitweb: http://git.kernel.org/tip/071ac0c4e8e90d5de05f0779b03ae69ce84820d5 Author: Borislav Petkov <[email protected]> AuthorDate: Mon, 30 Nov 2015 13:12:59 +0100 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 4 Dec 2015 12:55:01 +0100
x86/mm/ptdump: Make (debugfs)/kernel_page_tables read-only
File should be created with S_IRUSR and not with S_IWUSR too because writing to it doesn't make any sense. I mean, we don't have a ->write method anyway but let's have the permissions correct too.
--- arch/x86/mm/debug_pagetables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/mm/debug_pagetables.c +1 -1
@@ -26,7 +26,7 @@ static struct dentry *pe;static int __init pt_dump_debug_init (void ) { - pe =debugfs_create_file ("kernel_page_tables" ,0600 ,NULL ,NULL , + pe =debugfs_create_file ("kernel_page_tables" ,S_IRUSR ,NULL ,NULL , &ptdump_fops);if (!pe)return -ENOMEM ;
Quoted 8 lines · Borislav Petkov
From: Borislav Petkov <[email protected]>
File should be created with
S_IRUSRand not withS_IWUSRtoo because writing to it doesn't make any sense. I mean, we don't have a ->write method anyway but let's have the permissions correct too.Signed-off-by Borislav Petkov <[email protected]>Cc Arjan van de Ven <[email protected]>
We need a EHAHANOPE errno and have write return that. ;)
-Kees
Quoted 25 lines
--- arch/x86/mm/debug_pagetables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/mm/debug_pagetables.c +1
-2@@ -26,7 +26,7 @@ static struct dentry *pe;static int __init pt_dump_debug_init (void ) { - pe =debugfs_create_file ("kernel_page_tables" ,0600 ,NULL ,NULL , + pe =debugfs_create_file ("kernel_page_tables" ,S_IRUSR ,NULL ,NULL , &ptdump_fops);if (!pe)return -ENOMEM ; --2.3.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 2 lines
Kees Cook Chrome OS & Brillo Security
Borislav Petkov
maintainerQuoted 1 line · Kees Cook
We need a EHAHANOPE errno and have write return that. ;)
Sure, lemme add it to glibc:
---
manual/errno.texi +6 -1
@@ -1279,6 +1279,12 @@ They are not yet documented.} @comment errno ???/??? @end deftypevr +@comment errno.h +@comment Linux: Haha, nope, you wish. +@deftypevar Macro int EHAHANOPE +@comment errno ???/??? +@end deftypevr + @node Error Messages, , Error Codes, Error Reporting @section Error Messages ---
:-P
Signature · 4 lines
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.