Skip to contentSkip to conversation

Remove unused variable in fds/drm.c.

PATCH Applied Vinson Lee 2 participants 3 messages Dec 4, 2015

lore
Share & tools
lore

Vinson Lee

author
#0 lore raw

PATCH v2 1/1 Remove unused variable in fds/drm.c.

Fix build error with GCC 5.2.1.

CC fds/drm.o
fds/drm.c: In function ‘open_drm_fds’:
fds/drm.c:70:15: error: unused variable ‘i’ [-Werror=unused-variable]

  unsigned int i;
               ^

---
v2 - Fixed typo in commit message.

 fds/drm.c | 1 -
 1 file changed, 1 deletion(-)
fds/drm.c +0 -1
index b7fc867..4c9b5c5 100644
@@ -67,7 +67,6 @@ static void add_drm_obj(int fd)
 
 static int open_drm_fds(void)
 {
-	unsigned int i;
 	int fd, dfd;
 	DIR *dir;
 	struct dirent *entry;
Signature · 1 line
2.6.3
Applied
#1 lore raw
Quoted 7 lines · Vinson Lee

Fix build error with GCC 5.2.1.

CC fds/drm.o
fds/drm.c: In function ‘open_drm_fds’:
fds/drm.c:70:15: error: unused variable ‘i’ [-Werror=unused-variable]

  unsigned int i;
               ^

Applied. I wonder why debian's 5.2.1 didn't pick up on this. Judging by your other patches, I'm guessing this is Fedora's version ?

Dave

author
#2 lore raw
Quoted 9 lines · Dave Jones
Quoted 7 lines · Vinson Lee

Fix build error with GCC 5.2.1.

CC fds/drm.o
fds/drm.c: In function ‘open_drm_fds’:
fds/drm.c:70:15: error: unused variable ‘i’ [-Werror=unused-variable]

  unsigned int i;
               ^
Quoted 5 lines

Applied. I wonder why debian's 5.2.1 didn't pick up on this. Judging by your other patches, I'm guessing this is Fedora's version ?

Dave

Yes, the error was from GCC on Fedora.

$  gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/5.2.1/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap
--enable-languages=c,c++,objc,obj-c++,fortran,ada,go,lto --prefix=/usr
--mandir=/usr/share/man --infodir=/usr/share/info
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared
--enable-threads=posix --enable-checking=release --enable-multilib
--with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-gnu-unique-object
--enable-linker-build-id --with-linker-hash-style=gnu --enable-plugin
--enable-initfini-array --disable-libgcj --with-isl --enable-libmpx
--enable-gnu-indirect-function --with-tune=generic --with-arch_32=i686
--build=x86_64-redhat-linux
Thread model: posix
gcc version 5.2.1 20151104 (Red Hat 5.2.1-5) (GCC)

Vinson