Skip to contentSkip to conversation

arm: socfpga: Don't redefine CONFIG_PHYLIB

PATCH New Pavel Machek 3 participants 7 messages Dec 5, 2015 – Dec 6, 2015

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

CONFIG_PHYLIB is already set by the config system, don't set it again. Avoids ton of warnings.

Signed-off-by Pavel Machek <[email protected]>
include/configs/socfpga_common.h +0 -1
index b3f65b6..86eccba 100644
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT		(15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

Quoted 1 line · Pavel Machek

CONFIG_PHYLIB is already set by the config system

Where exactly is it set by the config system ?

Quoted 2 lines

don't set it again.
Avoids ton of warnings.

Sorry, I don't seem to be able to replicate these warnings. Can you provide more details ?

include/configs/socfpga_common.h line 109

Quoted 13 lines
Signed-off-by Pavel Machek <[email protected]>
(quoted diff) +0 -0

b/include/configs/socfpga_common.h index b3f65b6..86eccba 100644

include/configs/socfpga_common.h +0 -1
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT		(15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif

Best regards,
Marek Vasut

author
#2 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

Quoted 10 lines · Marek Vasut
Quoted 1 line · Pavel Machek

CONFIG_PHYLIB is already set by the config system

Where exactly is it set by the config system ?

Quoted 2 lines

don't set it again.
Avoids ton of warnings.

Sorry, I don't seem to be able to replicate these warnings. Can you provide more details ?

U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .

pavel at duo:~/amp/u-boot$ grep -ri PHYLIB find . -name "Kconfig" ./drivers/net/Kconfig:config PHYLIB
./drivers/net/Kconfig: select PHYLIB
./drivers/net/Kconfig: 100Mbit and 1 Gbit operation. You must
enable CONFIG_PHYLIB to
./drivers/net/Kconfig: select PHYLIB

ALTERA_TSE selects it.

Let me know if you need more info.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

Quoted 14 lines · Pavel Machek
Quoted 10 lines · Marek Vasut
Quoted 1 line · Pavel Machek

CONFIG_PHYLIB is already set by the config system

Where exactly is it set by the config system ?

Quoted 2 lines

don't set it again.
Avoids ton of warnings.

Sorry, I don't seem to be able to replicate these warnings. Can you provide more details ?

U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .

Quoted 8 lines

pavel at duo:~/amp/u-boot$ grep -ri PHYLIB find . -name "Kconfig" ./drivers/net/Kconfig:config PHYLIB
./drivers/net/Kconfig: select PHYLIB
./drivers/net/Kconfig: 100Mbit and 1 Gbit operation. You must
enable CONFIG_PHYLIB to
./drivers/net/Kconfig: select PHYLIB

ALTERA_TSE selects it.

Altera TSE is not selected on any socfpga platform to my knowledge. Could it be your patch which is causing the interference ?

Best regards,
Marek Vasut

author
#4 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

Quoted 22 lines · Marek Vasut
Quoted 21 lines · Pavel Machek
Quoted 10 lines · Marek Vasut
Quoted 1 line · Pavel Machek

CONFIG_PHYLIB is already set by the config system

Where exactly is it set by the config system ?

Quoted 2 lines

don't set it again.
Avoids ton of warnings.

Sorry, I don't seem to be able to replicate these warnings. Can you provide more details ?

U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .

pavel at duo:~/amp/u-boot$ grep -ri PHYLIB find . -name "Kconfig" ./drivers/net/Kconfig:config PHYLIB
./drivers/net/Kconfig: select PHYLIB
./drivers/net/Kconfig: 100Mbit and 1 Gbit operation. You must
enable CONFIG_PHYLIB to
./drivers/net/Kconfig: select PHYLIB

Quoted 4 lines
Quoted 1 line

ALTERA_TSE selects it.

Altera TSE is not selected on any socfpga platform to my knowledge. Could it be your patch which is causing the interference ?

Ok, that explains why you don't see it. I have ALTERA_TSE enabled. ... which is probably useless, but still should not cause ton of warnings.

Question is: how to solve it properly?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

Quoted 25 lines · Pavel Machek
Quoted 24 lines · Marek Vasut
Quoted 22 lines · Pavel Machek
Quoted 10 lines · Marek Vasut
Quoted 1 line · Pavel Machek

CONFIG_PHYLIB is already set by the config system

Where exactly is it set by the config system ?

Quoted 2 lines

don't set it again.
Avoids ton of warnings.

Sorry, I don't seem to be able to replicate these warnings. Can you provide more details ?

U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .

pavel at duo:~/amp/u-boot$ grep -ri PHYLIB find . -name "Kconfig" ./drivers/net/Kconfig:config PHYLIB
./drivers/net/Kconfig: select PHYLIB
./drivers/net/Kconfig: 100Mbit and 1 Gbit operation. You must
enable CONFIG_PHYLIB to
./drivers/net/Kconfig: select PHYLIB

ALTERA_TSE selects it.

Quoted 8 lines
Quoted 2 lines

Altera TSE is not selected on any socfpga platform to my knowledge. Could it be your patch which is causing the interference ?

Ok, that explains why you don't see it. I have ALTERA_TSE enabled. ... which is probably useless, but still should not cause ton of warnings.

Question is: how to solve it properly?

Ccing Joe.

Best regards,
Marek Vasut

#6 lore raw

PATCH 1/1 arm: socfpga: Don't redefine CONFIG_PHYLIB

Hi Marek and Pavel,

Quoted 3 lines
Quoted 3 lines

Ok, that explains why you don't see it. I have ALTERA_TSE enabled. ... which is probably useless, but still should not cause ton of warnings.

The CONFIG_PHYLIB in socfpga_common.h should be moved to Kconfig. I will send a patch.

Best regards,
Thomas